From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8248640042 for ; Mon, 22 Aug 2022 15:27:13 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D329B68B75A; Mon, 22 Aug 2022 18:26:50 +0300 (EEST) Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5F95A68BA2F for ; Mon, 22 Aug 2022 18:26:44 +0300 (EEST) Received: by mail-lf1-f49.google.com with SMTP id be9so7832405lfb.12 for ; Mon, 22 Aug 2022 08:26:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf.com; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=Ab2fXCqaExS7bHmukV+siuKUQ1DWa+I6kb+MaKV06bc=; b=CSi1nUtNDgA7RWmOEUC/7C9yiKaFaxy2QPwGpFHOzj4is1/mX/mni5BO/FefcryXr8 sqlfqRY9t6QEQcMjp1uORokkL+KeSsRqIIzc3gwn1upXoGw685gQ7DU8a+khg8HNDHT1 I0QcJjtTX1xaM5XnOct1U9BkWM/22z6jekzaUZbLodE8Whfukq6nx2BuqGe2/EOLG7/a MaWx8KUcAEWfpLzdZRcG7MJPdX9BCZHLmLhotl4n5IaEu3KUlN3xvi7cQl7Y4FCPF/Yi p7huRJOmWIUqxcDlk108DmBM5Rx/bZ5IrquQKv7302mqAZQTRDnwPXbQLAZ7eQWR8q5M CjOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=Ab2fXCqaExS7bHmukV+siuKUQ1DWa+I6kb+MaKV06bc=; b=Wkc3FyEE1wNOsIHDXshRwNMKuOI9sGdYvp7LIk22l2K2ShAVyxHflfrcYsd6TP8lQn qoFvverfG+IAAhOUeIVZ4mf0ja2TgILbPfr8ym0fNcakNOrO7s57Q3QO3x2SpGprOw1d rP2EnNA67kgIS57GUBKoDZAE5hO5nisFAtbm+ZheGICDqmgyL3RaCz6OusowLSN4JAvp ERj6V9vWAEp1QWBcnkK99x+/xlkQcAD+ELONd4CSI4cRo24q3iD/GdZvpRRcOWI6yQXn L2/cH7f7EmYC8Hl0Kk961ynmEWX8hjADF2RMMyJNpqOBRHy/FHWN1mpJvAR/tf6IS+3V aASQ== X-Gm-Message-State: ACgBeo15tzt7eJkURDjdgoJ2+CdGuA3FXlbaL1VhK8PgDB0a6ycU4hqz cYjh26w8ke9qm7CaYUliKTzVW0IgBUkAtw== X-Google-Smtp-Source: AA6agR52LG1PCh3XooSF52rKrMapLirevFBM/WQgGVwEpIWG2T9fueHxZC2JWPVXIFVoKS5qHSitrg== X-Received: by 2002:a05:6512:2294:b0:492:e136:5211 with SMTP id f20-20020a056512229400b00492e1365211mr2601676lfu.273.1661182003381; Mon, 22 Aug 2022 08:26:43 -0700 (PDT) Received: from hum-HP-ProBook-440-G7.office.semihalf.net ([83.142.187.84]) by smtp.gmail.com with ESMTPSA id z13-20020a056512370d00b00492f21c161esm2921lfr.123.2022.08.22.08.26.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Aug 2022 08:26:43 -0700 (PDT) From: Hubert Mazur To: ffmpeg-devel@ffmpeg.org Date: Mon, 22 Aug 2022 17:26:25 +0200 Message-Id: <20220822152627.1992008-4-hum@semihalf.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220822152627.1992008-1-hum@semihalf.com> References: <20220822152627.1992008-1-hum@semihalf.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 3/5] lavc/aarch64: Add neon implementation for vsad_intra16 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: gjb@semihalf.com, upstream@semihalf.com, jswinney@amazon.com, Hubert Mazur , martin@martin.st, mw@semihalf.com, spop@amazon.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Provide optimized implementation for vsad_intra16 function for arm64. Performance comparison tests are shown below. - vsad_4_c: 177.2 - vsad_4_neon: 24.5 Benchmarks and tests are run with checkasm tool on AWS Gravtion 3. Signed-off-by: Hubert Mazur --- libavcodec/aarch64/me_cmp_init_aarch64.c | 3 ++ libavcodec/aarch64/me_cmp_neon.S | 58 ++++++++++++++++++++++++ 2 files changed, 61 insertions(+) diff --git a/libavcodec/aarch64/me_cmp_init_aarch64.c b/libavcodec/aarch64/me_cmp_init_aarch64.c index 7b81e48d16..af83f7ed1e 100644 --- a/libavcodec/aarch64/me_cmp_init_aarch64.c +++ b/libavcodec/aarch64/me_cmp_init_aarch64.c @@ -43,6 +43,8 @@ int sse4_neon(MpegEncContext *v, const uint8_t *pix1, const uint8_t *pix2, int vsad16_neon(MpegEncContext *c, const uint8_t *s1, const uint8_t *s2, ptrdiff_t stride, int h); +int vsad_intra16_neon(MpegEncContext *c, const uint8_t *s, const uint8_t *dummy, + ptrdiff_t stride, int h) ; int vsse16_neon(MpegEncContext *c, const uint8_t *s1, const uint8_t *s2, ptrdiff_t stride, int h); @@ -64,6 +66,7 @@ av_cold void ff_me_cmp_init_aarch64(MECmpContext *c, AVCodecContext *avctx) c->sse[2] = sse4_neon; c->vsad[0] = vsad16_neon; + c->vsad[4] = vsad_intra16_neon; c->vsse[0] = vsse16_neon; } diff --git a/libavcodec/aarch64/me_cmp_neon.S b/libavcodec/aarch64/me_cmp_neon.S index 279bae7cb5..126e267fdc 100644 --- a/libavcodec/aarch64/me_cmp_neon.S +++ b/libavcodec/aarch64/me_cmp_neon.S @@ -756,3 +756,61 @@ function vsse16_neon, export=1 ret endfunc + +function vsad_intra16_neon, export=1 + // x0 unused + // x1 uint8_t *pix1 + // x2 uint8_t *dummy + // x3 ptrdiff_t stride + // w4 int h + + sub w4, w4, #1 // we need to make h-1 iterations + add x5, x1, x3 // pix1 + stride + cmp w4, #4 + movi v16.8h, #0 + + b.lt 2f + +// make 4 iterations at once +1: + // v = abs( pix1[0] - pix1[0 + stride] ) + // score = sum(v) + // abs(x) = ( (x > 0) ? (x) : (-x) ) + + ld1 {v0.16b}, [x1], x3 + ld1 {v1.16b}, [x5], x3 + ld1 {v2.16b}, [x1], x3 + uabal v16.8h, v0.8b, v1.8b + ld1 {v3.16b}, [x5], x3 + uabal2 v16.8h, v0.16b, v1.16b + ld1 {v4.16b}, [x1], x3 + uabal v16.8h, v2.8b, v3.8b + ld1 {v5.16b}, [x5], x3 + uabal2 v16.8h, v2.16b, v3.16b + ld1 {v6.16b}, [x1], x3 + uabal v16.8h, v4.8b, v5.8b + ld1 {v7.16b}, [x5], x3 + uabal2 v16.8h, v4.16b, v5.16b + sub w4, w4, #4 + uabal v16.8h, v6.8b, v7.8b + cmp w4, #4 + uabal2 v16.8h, v6.16b, v7.16b + + b.ge 1b + cbz w4, 3f + +// iterate by one +2: + ld1 {v0.16b}, [x1], x3 + ld1 {v1.16b}, [x5], x3 + subs w4, w4, #1 + uabal v16.8h, v0.8b, v1.8b + uabal2 v16.8h, v0.16b, v1.16b + cbnz w4, 2b + +3: + uaddlv s17, v16.8h + fmov w0, s17 + + ret +endfunc -- 2.34.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".