From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 750F743E9C for ; Tue, 16 Aug 2022 17:29:35 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2F0D568B8F2; Tue, 16 Aug 2022 20:29:33 +0300 (EEST) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A905A68B2D5 for ; Tue, 16 Aug 2022 20:29:26 +0300 (EEST) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id EA0D2240004 for ; Tue, 16 Aug 2022 17:29:25 +0000 (UTC) Date: Tue, 16 Aug 2022 19:29:24 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20220816172924.GY2088045@pb2> References: <20220814213313.37948-1-philipl@overt.org> <20220814213313.37948-3-philipl@overt.org> <20220815221049.GV2088045@pb2> <20220815152329.33af8c40@app.nyansa.com> MIME-Version: 1.0 In-Reply-To: <20220815152329.33af8c40@app.nyansa.com> Subject: Re: [FFmpeg-devel] [PATCH 2/3] lavc/vaapi: Add support for remaining 10/12bit profiles X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============6486634966270859324==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============6486634966270859324== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="FkhOn4hPPRcnTymj" Content-Disposition: inline --FkhOn4hPPRcnTymj Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 15, 2022 at 03:23:29PM -0700, Philip Langdale wrote: > On Tue, 16 Aug 2022 00:10:49 +0200 > Michael Niedermayer wrote: >=20 > > On Sun, Aug 14, 2022 at 02:33:12PM -0700, Philip Langdale wrote: > > > With the necessary pixel formats defined, we can now expose support > > > for the remaining 10/12bit combinations that VAAPI can handle. > > >=20 > > > Specifically, we are adding support for: > > >=20 > > > * HEVC > > > ** 12bit 420 > > > ** 10bit 422 > > > ** 12bit 422 > > > ** 10bit 444 > > > ** 12bit 444 > > >=20 > > > * VP9 > > > ** 10bit 422 > > > ** 10bit 444 > > >=20 > > > These obviously require actual hardware support to be usable, but > > > where that exists, it is now enabled. > > >=20 > > > I had to make some adjustments to the encode logic for matching bit > > > depth as the existing code assumed that the picture depth and the > > > pixel format depth were always the same, which is not true for > > > 12bit content which uses 16bit pixel formats. =20 > >=20 > > breaks build on ubuntu x86-64, assuming i did not miss any patch > > make > > CC libavutil/hwcontext_vaapi.o > > libavutil/hwcontext_vaapi.c:103:9: error: =E2=80=98VA_RT_FORMAT_YUV420_= 12=E2=80=99 > > undeclared here (not in a function); did you mean > > =E2=80=98VA_RT_FORMAT_YUV420=E2=80=99? VA_RT_FORMAT_ ## rt, \ ^ > > libavutil/hwcontext_vaapi.c:137:5: note: in expansion of macro =E2=80= =98MAP=E2=80=99 > > MAP(P016, YUV420_12, P016, 0), > > ^~~ > > ffbuild/common.mak:81: recipe for target > > 'libavutil/hwcontext_vaapi.o' failed make: *** > > [libavutil/hwcontext_vaapi.o] Error 1 > >=20 >=20 > I guess there's probably a libva version dependency I need to guard > for. What version do you have installed? ii libva-dev:amd64 = 2.1.0-3 amd64 = Video Acceleration (VA) API for Linux -- development files ii libva-drm2:amd64 = 2.1.0-3 amd64 = Video Acceleration (VA) API for Linux -- DRM runtime ii libva-glx2:amd64 = 2.1.0-3 amd64 = Video Acceleration (VA) API for Linux -- GLX runtime ii libva-wayland2:amd64 = 2.1.0-3 amd64 = Video Acceleration (VA) API for Linux -- Wayland runtime ii libva-x11-2:amd64 = 2.1.0-3 amd64 = Video Acceleration (VA) API for Linux -- X11 runtime ii libva2:amd64 = 2.1.0-3 amd64 = Video Acceleration (VA) API for Linux -- runtime thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Breaking DRM is a little like attempting to break through a door even though the window is wide open and the only thing in the house is a bunch of things you dont want and which you would get tomorrow for free anyway --FkhOn4hPPRcnTymj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCYvvT8AAKCRBhHseHBAsP qx8TAJwJVsZXU1/HPWX1XpuLy4yDRxfy9wCeInroxYHMbRdh7TPEFDMPITmrOXE= =gXVC -----END PGP SIGNATURE----- --FkhOn4hPPRcnTymj-- --===============6486634966270859324== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============6486634966270859324==--