Re: [FFmpeg-devel] [PATCH 2/3] lavc/vaapi: Add support for remaining 10/12bit profiles

[Michael Niedermayer <michael@niedermayer.cc>]

[-- Attachment #1.1: Type: text/plain, Size: 3347 bytes --]

On Mon, Aug 15, 2022 at 03:23:29PM -0700, Philip Langdale wrote:
> On Tue, 16 Aug 2022 00:10:49 +0200
> Michael Niedermayer <michael@niedermayer.cc> wrote:
> 
> > On Sun, Aug 14, 2022 at 02:33:12PM -0700, Philip Langdale wrote:
> > > With the necessary pixel formats defined, we can now expose support
> > > for the remaining 10/12bit combinations that VAAPI can handle.
> > > 
> > > Specifically, we are adding support for:
> > > 
> > > * HEVC
> > > ** 12bit 420
> > > ** 10bit 422
> > > ** 12bit 422
> > > ** 10bit 444
> > > ** 12bit 444
> > > 
> > > * VP9
> > > ** 10bit 422
> > > ** 10bit 444
> > > 
> > > These obviously require actual hardware support to be usable, but
> > > where that exists, it is now enabled.
> > > 
> > > I had to make some adjustments to the encode logic for matching bit
> > > depth as the existing code assumed that the picture depth and the
> > > pixel format depth were always the same, which is not true for
> > > 12bit content which uses 16bit pixel formats.  
> > 
> > breaks build on ubuntu x86-64, assuming i did not miss any patch
> > make
> > CC	libavutil/hwcontext_vaapi.o
> > libavutil/hwcontext_vaapi.c:103:9: error: ‘VA_RT_FORMAT_YUV420_12’
> > undeclared here (not in a function); did you mean
> > ‘VA_RT_FORMAT_YUV420’? VA_RT_FORMAT_ ## rt, \ ^
> > libavutil/hwcontext_vaapi.c:137:5: note: in expansion of macro ‘MAP’
> >      MAP(P016, YUV420_12, P016, 0),
> >      ^~~
> > ffbuild/common.mak:81: recipe for target
> > 'libavutil/hwcontext_vaapi.o' failed make: ***
> > [libavutil/hwcontext_vaapi.o] Error 1
> > 
> 
> I guess there's probably a libva version dependency I need to guard
> for. What version do you have installed?

ii  libva-dev:amd64                                                          2.1.0-3                                   amd64                                     Video Acceleration (VA) API for Linux -- development files
ii  libva-drm2:amd64                                                         2.1.0-3                                   amd64                                     Video Acceleration (VA) API for Linux -- DRM runtime
ii  libva-glx2:amd64                                                         2.1.0-3                                   amd64                                     Video Acceleration (VA) API for Linux -- GLX runtime
ii  libva-wayland2:amd64                                                     2.1.0-3                                   amd64                                     Video Acceleration (VA) API for Linux -- Wayland runtime
ii  libva-x11-2:amd64                                                        2.1.0-3                                   amd64                                     Video Acceleration (VA) API for Linux -- X11 runtime
ii  libva2:amd64                                                             2.1.0-3                                   amd64                                     Video Acceleration (VA) API for Linux -- runtime

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Breaking DRM is a little like attempting to break through a door even
though the window is wide open and the only thing in the house is a bunch
of things you dont want and which you would get tomorrow for free anyway

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".