From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 98B2E43E26 for ; Mon, 15 Aug 2022 22:22:00 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9EDEF68B922; Tue, 16 Aug 2022 01:21:57 +0300 (EEST) Received: from relay10.mail.gandi.net (relay10.mail.gandi.net [217.70.178.230]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0AB4E68B49A for ; Tue, 16 Aug 2022 01:21:51 +0300 (EEST) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 56187240002 for ; Mon, 15 Aug 2022 22:21:51 +0000 (UTC) Date: Tue, 16 Aug 2022 00:21:50 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20220815222150.GW2088045@pb2> References: MIME-Version: 1.0 In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 1/7] avcodec/h263dec: Remove redundant code to set cur_pic_ptr X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============3200027918018329251==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============3200027918018329251== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qCb2VTfFGdRLn6RH" Content-Disposition: inline --qCb2VTfFGdRLn6RH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 15, 2022 at 01:49:24PM +0200, Andreas Rheinhardt wrote: > It is done later in ff_mpv_frame_start() (and nobody uses > current_picture_ptr between setting it in ff_mpv_frame_start()). >=20 > (The reason the vsynth*-h263-obmc code changes is because > the call to ff_find_unused_picture() now happens after the older > pictures have been unreferenced in ff_mpv_frame_start(), > so that their slots in the picture array can be immediately > reused; the obmc code is somehow buggy and changes its output > depending on the earlier contents of the motion_val buffer.) >=20 > Signed-off-by: Andreas Rheinhardt > --- > I'd like to take this opportunity to once again ask anyone familiar > with H.263 to take a look at this OBMC issue. Iam too busy ATM :( i might look at some point but its not very high on my todo as it works :) security & release is more important but i can say this breaks fate as it is: --- ./tests/ref/vsynth/vsynth1-h263-obmc 2022-08-16 00:19:00.345967181 +0200 +++ tests/data/fate/vsynth1-h263-obmc 2022-08-16 00:19:05.262017999 +0200 @@ -1,4 +1,4 @@ 7dec64380f375e5118b66f3baaaa1e24 *tests/data/fate/vsynth1-h263-obmc.avi 657320 tests/data/fate/vsynth1-h263-obmc.avi -f5048b5f0c98833a1d11f8034fb1827f *tests/data/fate/vsynth1-h263-obmc.out.ra= wvideo -stddev: 8.12 PSNR: 29.93 MAXDIFF: 113 bytes: 7603200/ 7603200 +2a69f6b37378aa34418dfd04ec98c1c8 *tests/data/fate/vsynth1-h263-obmc.out.ra= wvideo +stddev: 8.38 PSNR: 29.66 MAXDIFF: 116 bytes: 7603200/ 7603200 Test vsynth1-h263-obmc failed. Look at tests/data/fate/vsynth1-h263-obmc.er= r for details. tests/Makefile:304: recipe for target 'fate-vsynth1-h263-obmc' failed make: *** [fate-vsynth1-h263-obmc] Error 1 [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Does the universe only have a finite lifespan? No, its going to go on forever, its just that you wont like living in it. -- Hiranya Peiri --qCb2VTfFGdRLn6RH Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCYvrG+gAKCRBhHseHBAsP q8cyAJ4hkIKqQjnVhqM2hcSMzxJOI/bJKgCeJhklPNKn72V2qh/Zl0N6t40cE/I= =Obta -----END PGP SIGNATURE----- --qCb2VTfFGdRLn6RH-- --===============3200027918018329251== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============3200027918018329251==--