From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1D24543E1D for ; Mon, 15 Aug 2022 22:11:00 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B03B268B8CC; Tue, 16 Aug 2022 01:10:57 +0300 (EEST) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 504C568B49A for ; Tue, 16 Aug 2022 01:10:51 +0300 (EEST) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 93F39240004 for ; Mon, 15 Aug 2022 22:10:50 +0000 (UTC) Date: Tue, 16 Aug 2022 00:10:49 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20220815221049.GV2088045@pb2> References: <20220814213313.37948-1-philipl@overt.org> <20220814213313.37948-3-philipl@overt.org> MIME-Version: 1.0 In-Reply-To: <20220814213313.37948-3-philipl@overt.org> Subject: Re: [FFmpeg-devel] [PATCH 2/3] lavc/vaapi: Add support for remaining 10/12bit profiles X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============1007672035571771364==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============1007672035571771364== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3e0+L7380OK+0MAI" Content-Disposition: inline --3e0+L7380OK+0MAI Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Aug 14, 2022 at 02:33:12PM -0700, Philip Langdale wrote: > With the necessary pixel formats defined, we can now expose support for > the remaining 10/12bit combinations that VAAPI can handle. >=20 > Specifically, we are adding support for: >=20 > * HEVC > ** 12bit 420 > ** 10bit 422 > ** 12bit 422 > ** 10bit 444 > ** 12bit 444 >=20 > * VP9 > ** 10bit 422 > ** 10bit 444 >=20 > These obviously require actual hardware support to be usable, but where > that exists, it is now enabled. >=20 > I had to make some adjustments to the encode logic for matching bit > depth as the existing code assumed that the picture depth and the pixel > format depth were always the same, which is not true for 12bit content > which uses 16bit pixel formats. breaks build on ubuntu x86-64, assuming i did not miss any patch make CC libavutil/hwcontext_vaapi.o libavutil/hwcontext_vaapi.c:103:9: error: =E2=80=98VA_RT_FORMAT_YUV420_12= =E2=80=99 undeclared here (not in a function); did you mean =E2=80=98VA_RT_= FORMAT_YUV420=E2=80=99? VA_RT_FORMAT_ ## rt, \ ^ libavutil/hwcontext_vaapi.c:137:5: note: in expansion of macro =E2=80=98MAP= =E2=80=99 MAP(P016, YUV420_12, P016, 0), ^~~ ffbuild/common.mak:81: recipe for target 'libavutil/hwcontext_vaapi.o' fail= ed make: *** [libavutil/hwcontext_vaapi.o] Error 1 [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Republics decline into democracies and democracies degenerate into despotisms. -- Aristotle --3e0+L7380OK+0MAI Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCYvrEZQAKCRBhHseHBAsP q2S7AJ9qq0nzMPs/N4seG//hRZ2rshpYeQCffNXIp2F3JyiWSCUmAkw7IQwq+IA= =vwUB -----END PGP SIGNATURE----- --3e0+L7380OK+0MAI-- --===============1007672035571771364== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============1007672035571771364==--