From: Michael Niedermayer <michael@niedermayer.cc> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Subject: Re: [FFmpeg-devel] [PATCH 08/11] avutil/half2float: move non-inline init code out of header Date: Mon, 15 Aug 2022 20:09:53 +0200 Message-ID: <20220815180953.GR2088045@pb2> (raw) In-Reply-To: <DB6PR0101MB2214FCCC2C56E8AAB33D976D8F689@DB6PR0101MB2214.eurprd01.prod.exchangelabs.com> [-- Attachment #1.1: Type: text/plain, Size: 2678 bytes --] On Mon, Aug 15, 2022 at 06:20:45AM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > On Thu, Aug 11, 2022 at 11:31:32PM +0200, Andreas Rheinhardt wrote: [...] > > make distclean ; ../configure --enable-shared --cc='ccache clang-6.0' --enable-pthreads --samples=fate/fate-suite/ --enable-version3 --extra-cflags='-O1 -fno-omit-frame-pointer' && make -j32 > > > > LD ffmpeg_g > > LD ffplay_g > > LD ffprobe_g > > libswscale/libswscale.so: undefined reference to `ff_init_half2float_tables' > > clang: error: linker command failed with exit code 1 (use -v to see invocation) > > Makefile:131: recipe for target 'ffprobe_g' failed > > make: *** [ffprobe_g] Error 1 > > make: *** Waiting for unfinished jobs.... > > libswscale/libswscale.so: undefined reference to `ff_init_half2float_tables' > > clang: error: linker command failed with exit code 1 (use -v to see invocation) > > Makefile:131: recipe for target 'ffplay_g' failed > > make: *** [ffplay_g] Error 1 > > libswscale/libswscale.so: undefined reference to `ff_init_half2float_tables' > > clang: error: linker command failed with exit code 1 (use -v to see invocation) > > Makefile:131: recipe for target 'ffmpeg_g' failed > > make: *** [ffmpeg_g] Error 1 > > > > git grep ff_init_half2float_tables > > libavcodec/exr.c: ff_init_half2float_tables(&s->h2f_tables); > > libavcodec/pnmdec.c: ff_init_half2float_tables(&s->h2f_tables); > > libavutil/half2float.c:void ff_init_half2float_tables(Half2FloatTables *t) > > libavutil/half2float.h:void ff_init_half2float_tables(Half2FloatTables *t); > > libswscale/slice.c: ff_init_half2float_tables(c->h2f_tables); > > > > libavcodec/half2float.c:#include "libavutil/half2float.c" > > libswscale/half2float.c:#include "libavutil/half2float.c" > > > > git grep half2float.o > > libavcodec/Makefile:OBJS-$(CONFIG_EXR_DECODER) += exr.o exrdsp.o half2float.o > > libavcodec/Makefile:OBJS-$(CONFIG_PHM_DECODER) += pnmdec.o pnm.o half2float.o > > libavutil/Makefile: half2float.o \ > > > > also i tried this: > > -#include "libavutil/half2float.c" > > +#inklude "libavutil/half2float.c" > > > > and still it fails at linking stage not compile, really impressive the compiler > > speaks german C too > > > > No, the libswscale/half2float.c file is just not compiled at all, see above. You seem to have a failure in humor.so thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB It is a danger to trust the dream we wish for rather than the science we have, -- Dr. Kenneth Brown [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 195 bytes --] [-- Attachment #2: Type: text/plain, Size: 251 bytes --] _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-08-15 18:10 UTC|newest] Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-08-10 20:47 [FFmpeg-devel] [PATCH 01/11] lavu/pixfmt: add packed RGBA float16 format Timo Rothenpieler 2022-08-10 20:47 ` [FFmpeg-devel] [PATCH 02/11] avutil/hwcontext_d3d11va: add support for rgbaf16 pixel format Timo Rothenpieler 2022-08-10 20:47 ` [FFmpeg-devel] [PATCH 03/11] avfilter/vsrc_ddagrab: add rgbaf16 output support Timo Rothenpieler 2022-08-10 20:47 ` [FFmpeg-devel] [PATCH 04/11] avfilter/vsrc_ddagrab: add options for more control over output format fallback Timo Rothenpieler 2022-08-10 20:47 ` [FFmpeg-devel] [PATCH 05/11] avutil: move half-precision float helper to avutil Timo Rothenpieler 2022-08-10 20:47 ` [FFmpeg-devel] [PATCH 06/11] avutil/half2float: adjust conversion of NaN Timo Rothenpieler 2022-08-10 21:24 ` Andreas Rheinhardt 2022-08-10 21:36 ` Timo Rothenpieler 2022-08-10 21:43 ` Andreas Rheinhardt 2022-08-10 21:53 ` Timo Rothenpieler 2022-08-10 22:14 ` Mark Reid 2022-08-10 22:18 ` James Almer 2022-08-10 22:28 ` Timo Rothenpieler 2022-08-10 22:37 ` Mark Reid 2022-08-10 22:55 ` Timo Rothenpieler 2022-08-11 2:18 ` Mark Reid 2022-08-10 20:47 ` [FFmpeg-devel] [PATCH 07/11] avutil/half2float: move tables to header-internal structs Timo Rothenpieler 2022-08-10 20:47 ` [FFmpeg-devel] [PATCH 08/11] avutil/half2float: move non-inline init code out of header Timo Rothenpieler 2022-08-11 20:46 ` Michael Niedermayer 2022-08-11 20:50 ` Andreas Rheinhardt 2022-08-11 21:16 ` Michael Niedermayer 2022-08-11 21:31 ` Andreas Rheinhardt 2022-08-14 19:32 ` Michael Niedermayer 2022-08-15 4:20 ` Andreas Rheinhardt 2022-08-15 18:09 ` Michael Niedermayer [this message] 2022-08-14 21:54 ` Timo Rothenpieler 2022-08-10 20:47 ` [FFmpeg-devel] [PATCH 09/11] avutil/half2float: use native _Float16 if available Timo Rothenpieler 2022-08-10 21:03 ` Andreas Rheinhardt 2022-08-10 21:58 ` Timo Rothenpieler 2022-08-10 22:02 ` James Almer 2022-08-10 22:51 ` [FFmpeg-devel] [PATCH v2 " Timo Rothenpieler 2022-08-11 0:14 ` James Almer 2022-08-11 11:50 ` Timo Rothenpieler 2022-08-10 20:47 ` [FFmpeg-devel] [PATCH 10/11] swscale: add SwsContext parameter to input functions Timo Rothenpieler 2022-08-10 20:52 ` Timo Rothenpieler 2022-08-10 21:55 ` Andreas Rheinhardt 2022-08-10 22:02 ` Timo Rothenpieler 2022-08-10 20:47 ` [FFmpeg-devel] [PATCH 11/11] swscale/input: add rgbaf16 input support Timo Rothenpieler 2022-08-10 21:37 ` Timo Rothenpieler
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220815180953.GR2088045@pb2 \ --to=michael@niedermayer.cc \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git