From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2AECE4351F for ; Mon, 15 Aug 2022 17:53:18 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4D3F768B955; Mon, 15 Aug 2022 20:53:15 +0300 (EEST) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9503A68B70B for ; Mon, 15 Aug 2022 20:53:08 +0300 (EEST) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id E34ED240003 for ; Mon, 15 Aug 2022 17:53:07 +0000 (UTC) Date: Mon, 15 Aug 2022 19:53:06 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20220815175306.GQ2088045@pb2> References: <20220810222708.186270-1-derek.buitenhuis@gmail.com> MIME-Version: 1.0 In-Reply-To: <20220810222708.186270-1-derek.buitenhuis@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH] ipfsgateway: Remove default gateway X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============7605714527645398389==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============7605714527645398389== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="H5oeNUPfJ0vte6JU" Content-Disposition: inline --H5oeNUPfJ0vte6JU Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 10, 2022 at 11:27:08PM +0100, Derek Buitenhuis wrote: > A gateway can see everything, and we should not be shipping a hardcoded > default from a third party company; it's a security risk. >=20 > Signed-off-by: Derek Buitenhuis > --- > libavformat/ipfsgateway.c | 11 ++++------- > 1 file changed, 4 insertions(+), 7 deletions(-) >=20 > diff --git a/libavformat/ipfsgateway.c b/libavformat/ipfsgateway.c > index 5a5178c563..907b61b017 100644 > --- a/libavformat/ipfsgateway.c > +++ b/libavformat/ipfsgateway.c > @@ -240,13 +240,8 @@ static int translate_ipfs_to_http(URLContext *h, con= st char *uri, int flags, AVD > ret =3D populate_ipfs_gateway(h); > =20 > if (ret < 1) { > - // We fallback on dweb.link (managed by Protocol Labs). > - snprintf(c->gateway_buffer, sizeof(c->gateway_buffer), "http= s://dweb.link"); > - > - av_log(h, AV_LOG_WARNING, > - "IPFS does not appear to be running. " > - "You=E2=80=99re now using the public gateway at dweb.= link.\n"); > - av_log(h, AV_LOG_INFO, > + av_log(h, AV_LOG_ERROR, > + "IPFS does not appear to be running.\n\n" > "Installing IPFS locally is recommended to " > "improve performance and reliability, " > "and not share all your activity with a single IPFS g= ateway.\n" > @@ -259,6 +254,8 @@ static int translate_ipfs_to_http(URLContext *h, cons= t char *uri, int flags, AVD > "3. Define an $IPFS_PATH environment variable " > "and point it to the IPFS data path " > "- this is typically ~/.ipfs\n"); > + ret =3D AVERROR(EINVAL); > + goto err; > } > } Before this patch, only "experts" needed to change the IPFS settings. After this patch everyone who wants to use IPFS needs to change the IPFS settings. The printed text is adequate to experts but not to the average user. It should either explain the privacy & security implications of the different options or point to some external documentation. Such external documentation needs to stay available at the given link also for the lifetime of the releases it is part of Said differently, a user choosing a gateway needs to understand that this choice can affect her privacy. Similarly that the choice betweem gateway and node affects privacy too Please add better documentation to achieve that. (maybe in a seperate patch would be cleanest) thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I do not agree with what you have to say, but I'll defend to the death your right to say it. -- Voltaire --H5oeNUPfJ0vte6JU Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCYvqH/gAKCRBhHseHBAsP q63PAJ4yyMuFb4uEs03ut40oxwuNA2driwCeNYldlfNrZsl97a30eYs0giIjJRg= =/oQR -----END PGP SIGNATURE----- --H5oeNUPfJ0vte6JU-- --===============7605714527645398389== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============7605714527645398389==--