From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7DEA043AC0 for ; Thu, 11 Aug 2022 20:46:27 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9A36D68B934; Thu, 11 Aug 2022 23:46:24 +0300 (EEST) Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 82AF368B8E5 for ; Thu, 11 Aug 2022 23:46:17 +0300 (EEST) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id DCD021BF207 for ; Thu, 11 Aug 2022 20:46:16 +0000 (UTC) Date: Thu, 11 Aug 2022 22:46:16 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20220811204616.GF2088045@pb2> References: <20220810204712.3123-1-timo@rothenpieler.org> <20220810204712.3123-8-timo@rothenpieler.org> MIME-Version: 1.0 In-Reply-To: <20220810204712.3123-8-timo@rothenpieler.org> Subject: Re: [FFmpeg-devel] [PATCH 08/11] avutil/half2float: move non-inline init code out of header X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============2410079866437704186==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============2410079866437704186== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ou2/pFdZC1wHLsdF" Content-Disposition: inline --ou2/pFdZC1wHLsdF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 10, 2022 at 10:47:09PM +0200, Timo Rothenpieler wrote: > --- > libavcodec/Makefile | 8 +++--- > libavcodec/exr.c | 2 +- > libavcodec/exrenc.c | 2 +- > libavcodec/float2half.c | 19 +++++++++++++ > libavcodec/half2float.c | 19 +++++++++++++ > libavcodec/pnmdec.c | 2 +- > libavcodec/pnmenc.c | 2 +- > libavutil/float2half.c | 53 ++++++++++++++++++++++++++++++++++ > libavutil/float2half.h | 36 ++--------------------- > libavutil/half2float.c | 63 +++++++++++++++++++++++++++++++++++++++++ > libavutil/half2float.h | 46 ++---------------------------- > 11 files changed, 166 insertions(+), 86 deletions(-) > create mode 100644 libavcodec/float2half.c > create mode 100644 libavcodec/half2float.c > create mode 100644 libavutil/float2half.c > create mode 100644 libavutil/half2float.c >=20 > diff --git a/libavcodec/Makefile b/libavcodec/Makefile > index 029f1bad3d..cb80f73d99 100644 > --- a/libavcodec/Makefile > +++ b/libavcodec/Makefile > @@ -337,8 +337,8 @@ OBJS-$(CONFIG_EIGHTSVX_FIB_DECODER) +=3D 8svx.o > OBJS-$(CONFIG_ESCAPE124_DECODER) +=3D escape124.o > OBJS-$(CONFIG_ESCAPE130_DECODER) +=3D escape130.o > OBJS-$(CONFIG_EVRC_DECODER) +=3D evrcdec.o acelp_vectors.o ls= p.o > -OBJS-$(CONFIG_EXR_DECODER) +=3D exr.o exrdsp.o > -OBJS-$(CONFIG_EXR_ENCODER) +=3D exrenc.o > +OBJS-$(CONFIG_EXR_DECODER) +=3D exr.o exrdsp.o half2float.o > +OBJS-$(CONFIG_EXR_ENCODER) +=3D exrenc.o float2half.o > OBJS-$(CONFIG_FASTAUDIO_DECODER) +=3D fastaudio.o > OBJS-$(CONFIG_FFV1_DECODER) +=3D ffv1dec.o ffv1.o > OBJS-$(CONFIG_FFV1_ENCODER) +=3D ffv1enc.o ffv1.o > @@ -570,8 +570,8 @@ OBJS-$(CONFIG_PGMYUV_DECODER) +=3D pnmdec.o = pnm.o > OBJS-$(CONFIG_PGMYUV_ENCODER) +=3D pnmenc.o > OBJS-$(CONFIG_PGSSUB_DECODER) +=3D pgssubdec.o > OBJS-$(CONFIG_PGX_DECODER) +=3D pgxdec.o > -OBJS-$(CONFIG_PHM_DECODER) +=3D pnmdec.o pnm.o > -OBJS-$(CONFIG_PHM_ENCODER) +=3D pnmenc.o > +OBJS-$(CONFIG_PHM_DECODER) +=3D pnmdec.o pnm.o half2float.o > +OBJS-$(CONFIG_PHM_ENCODER) +=3D pnmenc.o float2half.o > OBJS-$(CONFIG_PHOTOCD_DECODER) +=3D photocd.o > OBJS-$(CONFIG_PICTOR_DECODER) +=3D pictordec.o cga_data.o > OBJS-$(CONFIG_PIXLET_DECODER) +=3D pixlet.o > diff --git a/libavcodec/exr.c b/libavcodec/exr.c > index 825354873d..a3582bfdd6 100644 > --- a/libavcodec/exr.c > +++ b/libavcodec/exr.c > @@ -2208,7 +2208,7 @@ static av_cold int decode_init(AVCodecContext *avct= x) > float one_gamma =3D 1.0f / s->gamma; > avpriv_trc_function trc_func =3D NULL; > =20 > - init_half2float_tables(&s->h2f_tables); > + ff_init_half2float_tables(&s->h2f_tables); [...] > diff --git a/libavutil/float2half.c b/libavutil/float2half.c > new file mode 100644 > index 0000000000..dba14cef5d > --- /dev/null > +++ b/libavutil/float2half.c [...] > +void ff_init_float2half_tables(float2half_tables *t) this will need avpriv or break linking with shared libs thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB "You are 36 times more likely to die in a bathtub than at the hands of a terrorist. Also, you are 2.5 times more likely to become a president and 2 times more likely to become an astronaut, than to die in a terrorist attack." -- Thoughty2 --ou2/pFdZC1wHLsdF Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCYvVqlAAKCRBhHseHBAsP q2y0AJ9WlBCFDGdxsQwbknC2ZfPa5qXLxwCfcSwurLKfGzRJiURqrpjnBqF/BIQ= =jGVG -----END PGP SIGNATURE----- --ou2/pFdZC1wHLsdF-- --===============2410079866437704186== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============2410079866437704186==--