From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9FD8240BCF for ; Sat, 6 Aug 2022 10:30:22 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id F24A368B6B1; Sat, 6 Aug 2022 13:30:12 +0300 (EEST) Received: from mail.overt.org (mail.overt.org [157.230.92.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2C65968B462 for ; Sat, 6 Aug 2022 13:30:06 +0300 (EEST) Received: from authenticated-user (mail.overt.org [157.230.92.47]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by mail.overt.org (Postfix) with ESMTPSA id C8E7C3F3EB for ; Fri, 5 Aug 2022 22:23:11 -0500 (CDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=overt.org; s=mail; t=1659756192; bh=6+mcyPDCdUwDjVS3vKp9HqaDTKleWi7paNgGZkXaPl8=; h=Date:From:To:Subject:In-Reply-To:References:From; b=WrY2cG59k1JNDe+tXrFbYDlhnYdMUXw7iDPZ3j4Z0UQYm0qIH73D8NPvZdapwmtrA Y+4aJ7RTGpHG5y6XhxCJUeOHEnjxXLY8SVMoZ/9gjzXWbMbPYJq4hPZ9Acz4aNymS1 7fx0X4zDpmsQ3dHIg8oJ79IKBZoy3+xbFJW5mR7ph/p6U2HikNpF3bS71bjZax+Sdn t7sk4Mp9R601q7i0JM30+mVnUGLe3bb2d9tSDL1uET0MpTmZsdgR5llmogYqwlpC8D p/DMzwftyyan/Gx8rmY0NmzscwemCALj6fbZltGmQKGADs/gLRLsfBf2vs+PdcqEXy a/gQkglKdbXCQ== Date: Fri, 5 Aug 2022 20:23:10 -0700 From: Philip Langdale To: ffmpeg-devel@ffmpeg.org Message-ID: <20220805202310.08ceb658@fido7> In-Reply-To: <20220805061119.812692-2-fei.w.wang@intel.com> References: <20220805061119.812692-1-fei.w.wang@intel.com> <20220805061119.812692-2-fei.w.wang@intel.com> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH v2 2/2] lavfi/overlay_vaapi: set defalut alpha value as 1.0 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, 5 Aug 2022 14:11:19 +0800 Fei Wang wrote: > The present default value of 0 will render the overlay video > invisible. A default of 1.0 is consistent with most common use cases. > > Signed-off-by: Fei Wang > --- > doc/filters.texi | 2 +- > libavfilter/vf_overlay_vaapi.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/doc/filters.texi b/doc/filters.texi > index a66b750d57..da0a946a6f 100644 > --- a/doc/filters.texi > +++ b/doc/filters.texi > @@ -26170,7 +26170,7 @@ Default value is the height of input overlay > video. @item alpha > Set transparency of overlaid video. Allowed range is 0.0 to 1.0. > Higher value means lower transparency. > -Default value is @code{0.0}. > +Default value is @code{1.0}. > > @end table > > diff --git a/libavfilter/vf_overlay_vaapi.c > b/libavfilter/vf_overlay_vaapi.c index b3a624ae15..3e6a0de13f 100644 > --- a/libavfilter/vf_overlay_vaapi.c > +++ b/libavfilter/vf_overlay_vaapi.c > @@ -380,7 +380,7 @@ static const AVOption overlay_vaapi_options[] = { > { "h", "Overlay height", > OFFSET(overlay_oh), AV_OPT_TYPE_INT, { .i64 = 0 }, 0, INT_MAX, > .flags = FLAGS }, { "alpha", "Overlay global alpha", > - OFFSET(alpha), AV_OPT_TYPE_FLOAT, { .dbl = 0.0}, 0.0, 1.0, > .flags = FLAGS}, > + OFFSET(alpha), AV_OPT_TYPE_FLOAT, { .dbl = 1.0}, 0.0, 1.0, > .flags = FLAGS}, { NULL }, > }; > LGTM --phil _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".