From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 68CF1439CA for ; Thu, 4 Aug 2022 12:40:20 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8D10268B9B5; Thu, 4 Aug 2022 15:40:17 +0300 (EEST) Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id F000468B99A for ; Thu, 4 Aug 2022 15:40:10 +0300 (EEST) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 208281C0007 for ; Thu, 4 Aug 2022 12:40:09 +0000 (UTC) Date: Thu, 4 Aug 2022 14:40:09 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20220804124009.GI2088045@pb2> References: <20220803135844.16662-1-anton@khirnov.net> <20220803135844.16662-7-anton@khirnov.net> MIME-Version: 1.0 In-Reply-To: <20220803135844.16662-7-anton@khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH 07/25] fftools/ffmpeg: remove OutputStream.stream_copy X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============1015037251873017499==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============1015037251873017499== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="9jVH9MMcXWLfwoO6" Content-Disposition: inline --9jVH9MMcXWLfwoO6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 03, 2022 at 03:58:26PM +0200, Anton Khirnov wrote: > There are currently three possible modes for an output stream: > 1) The stream is produced by encoding output from some filtergraph. This > is true when ost->enc_ctx !=3D NULL, or equivalently when > ost->encoding_needed !=3D 0. > 2) The stream is produced by copying some input stream's packets. This > is true when ost->enc_ctx =3D=3D NULL && ost->source_index >=3D 0. > 3) The stream is produced by attaching some file directly. This is true > when ost->enc_ctx =3D=3D NULL && ost->source_index < 0. >=20 > OutputStream.stream_copy is currently used to identify case 2), and > sometimes to confusingly (or even incorrectly) identify case 1). Remove > it, replacing its usage with checking enc_ctx/source_index values. > --- > fftools/ffmpeg.c | 23 +++++++++-------------- > fftools/ffmpeg.h | 1 - > fftools/ffmpeg_opt.c | 33 ++++++++++++--------------------- > 3 files changed, 21 insertions(+), 36 deletions(-) seems to break build with shared libs: CC fftools/ffmpeg.o src/fftools/ffmpeg.c:405:32: warning: suggest braces around initialization = of subobject [-Wmissing-braces] struct sigaction action =3D {0}; ^ {} src/fftools/ffmpeg.c:1612:37: error: address argument to atomic operation m= ust be a pointer to non-const _Atomic type ('const atomic_uint_least64_t *'= (aka 'const _Atomic(uint_least64_t) *') invalid) uint64_t frame_number =3D atomic_load(&ost->packets_written); ^ ~~~~~~~~~~~~~~~~~~~~~ /usr/lib/llvm-6.0/lib/clang/6.0.0/include/stdatomic.h:134:29: note: expande= d from macro 'atomic_load' #define atomic_load(object) __c11_atomic_load(object, __ATOMIC_SEQ_CST) ^ ~~~~~~ 1 warning and 1 error generated. src/ffbuild/common.mak:81: recipe for target 'fftools/ffmpeg.o' failed make: *** [fftools/ffmpeg.o] Error 1 [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB In a rich man's house there is no place to spit but his face. -- Diogenes of Sinope --9jVH9MMcXWLfwoO6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCYuu+JQAKCRBhHseHBAsP q6eqAJ9wue77JQ/Vui6rs4NqyQBg3qoH+wCbBvdXXNdy/tAiZ/dxFG8NSgbAWPg= =8F5c -----END PGP SIGNATURE----- --9jVH9MMcXWLfwoO6-- --===============1015037251873017499== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============1015037251873017499==--