From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id CCA6140A9E for ; Wed, 3 Aug 2022 15:48:37 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 86D7B68B8E4; Wed, 3 Aug 2022 18:48:35 +0300 (EEST) Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1D97068B6DF for ; Wed, 3 Aug 2022 18:48:28 +0300 (EEST) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 3114120004 for ; Wed, 3 Aug 2022 15:48:26 +0000 (UTC) Date: Wed, 3 Aug 2022 17:48:26 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20220803154826.GH2088045@pb2> References: <20220730171239.GE2088045@pb2> <165943263921.15471.1512917784463747668@lain.khirnov.net> <20220803152816.GG2088045@pb2> MIME-Version: 1.0 In-Reply-To: <20220803152816.GG2088045@pb2> Subject: Re: [FFmpeg-devel] [PATCH 34/39] avcodec/mpegvideoencdsp: Allow pointers to const where possible X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============2414232617791173214==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============2414232617791173214== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="MKyq+TZLpK62LzFe" Content-Disposition: inline --MKyq+TZLpK62LzFe Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 03, 2022 at 05:28:16PM +0200, Michael Niedermayer wrote: > On Tue, Aug 02, 2022 at 11:30:39AM +0200, Anton Khirnov wrote: > > Quoting Michael Niedermayer (2022-07-30 19:12:39) > > > On Sat, Jul 30, 2022 at 11:55:45AM +0200, Andreas Rheinhardt wrote: > > > > Michael Niedermayer: > > > > > On Wed, Jul 27, 2022 at 12:08:09AM +0200, Andreas Rheinhardt wrot= e: > > > > >> Signed-off-by: Andreas Rheinhardt > > > > >> --- > > > > >> libavcodec/arm/mpegvideoencdsp_init_arm.c | 4 ++-- > > > > >> libavcodec/mips/h263dsp_mips.h | 2 +- > > > > >> libavcodec/mips/mpegvideoencdsp_msa.c | 4 ++-- > > > > >> libavcodec/mpegvideoencdsp.c | 10 +++++----- > > > > >> libavcodec/mpegvideoencdsp.h | 10 +++++----- > > > > >> libavcodec/ppc/mpegvideoencdsp.c | 8 ++++---- > > > > >> libavcodec/x86/mpegvideoenc_qns_template.c | 4 ++-- > > > > >> libavcodec/x86/mpegvideoencdsp.asm | 4 ++-- > > > > >> libavcodec/x86/mpegvideoencdsp_init.c | 6 +++--- > > > > >> 9 files changed, 26 insertions(+), 26 deletions(-) > > > > >=20 > > > > > LGTM, also all similar things should be ok > > > > >=20 > > > > > [...] > > > > >=20 > > > >=20 > > > > Unfortunately, it is not so easy. The first version of this patchset > > > > (this here) forgot to update the definitions of several loongarch > > > > functions, leading to lots of red on patchwork. The second version = fixed > > > > the compilation error, but forgot some constifications due to > > > > unfortunate oversights. For the third version, I wanted to actually > > > > compile loongarch instead of just staring at the code; but the > > > > GCC-cross-compiler does not seem to support lsx and lasx (and looki= ng at > > > > the loongarch-code in GCC makes me believe that they are just not > > > > supported (yet)). Therefore I resorted to creating dummy-functions = for > > > > all the __lasx_* and __lsx_* functions (they show no more > > > > const-warnings). I wanted to let the FATE-loongarch-box test this o= nce > > > > more (and tell me whether there are still any issues left), yet thi= s box > > > > is no longer active since a few days (for reasons unknown). Can you > > > > compile the lsx and lasx code (after all, you committed all the > > > > loongarch code)? > > >=20 > > > i have no easy way to test loongarch, what i can test is qemu-mips. > > > i think i have said that a few times already. > > >=20 > > > I do have a loongson box that is IIRC ready to be shipped (within EU)= to > > > whoever volunteers to maintain that box for FFmpeg. I dont know if th= at > > > box would help with the current code. The OS will liklely need to be = updated > > > and IIRC this has no normal update mechanism) I didnt touch this box = for a > > > really long time. > >=20 > > What OS is it? >=20 > looking thorugh past emails (so i dont have to get the box and unpack it = again) >=20 > its some custom fedora/redhat > that additional info i found while double checking the OS: >=20 > according to /proc/cpuinfo, 4 core > system type=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 : lst-loongson3-eva > machine=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 : Unknown > processor=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 : 0 > cpu model=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 : ICT Loongson-3A V0= =2E5=A0 FPU V0.1 > BogoMIPS=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 : 717.28 > ... > with 500gb 7200rpm WD Caviar Blue HDD > 4gb memory >=20 >=20 > >=20 > > I could conceivably host such a machine and give other devs SSH access > > to it, if it does not require too much maintenance and/or electricity. >=20 > given the tiny heatsink/fan on the CPU i dont think it would require alot= of power > send me teh target address and ill get it shipped to you assuming the box= is still where > it was and i find it more precisse power usage: (from 2015) ~1W when OFF ~44W when IDLE ~48W when running fate tests in 2015 with FFmpeg from 2015: 4m49.192s for time ./configure --enable-gpl --enable-pthreads --samples=3D/= home/loongson/fate/ --enable-nonfree --enable-version3 --assert-level=3D2 -= -cpu=3Dloongson3a --enable-loongson3 19m31.114s for make -j4 time make fate -j4 -k >& fatelist8 real 28m32.631s user 98m50.422s sys 12m53.547s CPU coolong fan was also replaced with a Noctua NF-A6x25 FLX as the origina= l was really loud thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Elect your leaders based on what they did after the last election, not based on what they say before an election. --MKyq+TZLpK62LzFe Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCYuqYxgAKCRBhHseHBAsP q1jvAJ94Zxy5kKJjTEgCGLoohopJXoWFywCgm4mfrnbUOCXBZNh2R0J5PsibWm0= =XzQ1 -----END PGP SIGNATURE----- --MKyq+TZLpK62LzFe-- --===============2414232617791173214== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============2414232617791173214==--