* [FFmpeg-devel] [PATCH] configure: Check for DXGI_OUTDUPL_FRAME_INFO for the ddagrab filter
@ 2022-08-01 12:35 Martin Storsjö
2022-08-01 12:36 ` Timo Rothenpieler
2022-08-01 12:48 ` Hendrik Leppkes
0 siblings, 2 replies; 6+ messages in thread
From: Martin Storsjö @ 2022-08-01 12:35 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Martin Storsjö, Timo Rothenpieler
The DXGI_OUTDUPL_FRAME_INFO type isn't available in Windows API
subsets other than "desktop", while the IDXGIOutput1 interface is
available for all API subsets.
This fixes compilation for UWP/"Windows Store" configurations (and
older API subsets like Windows Phone).
Signed-off-by: Martin Storsjö <martin@martin.st>
---
configure | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/configure b/configure
index 8c7e8c9d1d..eb413a6716 100755
--- a/configure
+++ b/configure
@@ -3158,7 +3158,7 @@ overlay_cuda_filter_deps="ffnvcodec"
overlay_cuda_filter_deps_any="cuda_nvcc cuda_llvm"
sharpen_npp_filter_deps="ffnvcodec libnpp"
-ddagrab_filter_deps="d3d11va IDXGIOutput1"
+ddagrab_filter_deps="d3d11va IDXGIOutput1 DXGI_OUTDUPL_FRAME_INFO"
amf_deps_any="libdl LoadLibrary"
nvenc_deps="ffnvcodec"
@@ -6395,6 +6395,7 @@ check_struct "sys/time.h sys/resource.h" "struct rusage" ru_maxrss
check_type "windows.h dxva.h" "DXVA_PicParams_AV1" -DWINAPI_FAMILY=WINAPI_FAMILY_DESKTOP_APP -D_CRT_BUILD_DESKTOP_APP=0
check_type "windows.h dxva.h" "DXVA_PicParams_HEVC" -DWINAPI_FAMILY=WINAPI_FAMILY_DESKTOP_APP -D_CRT_BUILD_DESKTOP_APP=0
check_type "windows.h dxva.h" "DXVA_PicParams_VP9" -DWINAPI_FAMILY=WINAPI_FAMILY_DESKTOP_APP -D_CRT_BUILD_DESKTOP_APP=0
+check_type "windows.h dxgi1_2.h" "DXGI_OUTDUPL_FRAME_INFO"
check_type "windows.h dxgi1_2.h" "IDXGIOutput1"
check_type "windows.h dxgi1_5.h" "IDXGIOutput5"
check_type "windows.h d3d11.h" "ID3D11VideoDecoder"
--
2.25.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [FFmpeg-devel] [PATCH] configure: Check for DXGI_OUTDUPL_FRAME_INFO for the ddagrab filter
2022-08-01 12:35 [FFmpeg-devel] [PATCH] configure: Check for DXGI_OUTDUPL_FRAME_INFO for the ddagrab filter Martin Storsjö
@ 2022-08-01 12:36 ` Timo Rothenpieler
2022-08-01 12:48 ` Hendrik Leppkes
1 sibling, 0 replies; 6+ messages in thread
From: Timo Rothenpieler @ 2022-08-01 12:36 UTC (permalink / raw)
To: Martin Storsjö, ffmpeg-devel
Very weird decision by Microsoft there for sure.
Patch LGTM
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [FFmpeg-devel] [PATCH] configure: Check for DXGI_OUTDUPL_FRAME_INFO for the ddagrab filter
2022-08-01 12:35 [FFmpeg-devel] [PATCH] configure: Check for DXGI_OUTDUPL_FRAME_INFO for the ddagrab filter Martin Storsjö
2022-08-01 12:36 ` Timo Rothenpieler
@ 2022-08-01 12:48 ` Hendrik Leppkes
2022-08-01 12:56 ` Martin Storsjö
1 sibling, 1 reply; 6+ messages in thread
From: Hendrik Leppkes @ 2022-08-01 12:48 UTC (permalink / raw)
To: FFmpeg development discussions and patches
On Mon, Aug 1, 2022 at 2:36 PM Martin Storsjö <martin@martin.st> wrote:
>
> The DXGI_OUTDUPL_FRAME_INFO type isn't available in Windows API
> subsets other than "desktop", while the IDXGIOutput1 interface is
> available for all API subsets.
>
> This fixes compilation for UWP/"Windows Store" configurations (and
> older API subsets like Windows Phone).
The entire desktop duplication API is not present on Phone targets
(its called "desktop" duplication afterall). I think it would be
better to check for a primary DDA function, instead of some auxiliary
structure.
- Hendrik
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [FFmpeg-devel] [PATCH] configure: Check for DXGI_OUTDUPL_FRAME_INFO for the ddagrab filter
2022-08-01 12:48 ` Hendrik Leppkes
@ 2022-08-01 12:56 ` Martin Storsjö
2022-08-01 13:49 ` Hendrik Leppkes
0 siblings, 1 reply; 6+ messages in thread
From: Martin Storsjö @ 2022-08-01 12:56 UTC (permalink / raw)
To: FFmpeg development discussions and patches
On Mon, 1 Aug 2022, Hendrik Leppkes wrote:
> On Mon, Aug 1, 2022 at 2:36 PM Martin Storsjö <martin@martin.st> wrote:
>>
>> The DXGI_OUTDUPL_FRAME_INFO type isn't available in Windows API
>> subsets other than "desktop", while the IDXGIOutput1 interface is
>> available for all API subsets.
>>
>> This fixes compilation for UWP/"Windows Store" configurations (and
>> older API subsets like Windows Phone).
>
> The entire desktop duplication API is not present on Phone targets
> (its called "desktop" duplication afterall). I think it would be
> better to check for a primary DDA function, instead of some auxiliary
> structure.
FWIW, based on the MSVC error output
(http://fate.ffmpeg.org/log.cgi?log=compile&slot=arm-msvc2019-phone&time=20220730152801),
the only hard errors it listed were the undefined types
(DXGI_OUTDUPL_POINTER_SHAPE_INFO and DXGI_OUTDUPL_FRAME_INFO) - but I
presume that IDXGIOutputDuplication_AcquireNextFrame and
IDXGIOutputDuplication_ReleaseFrame could be good candidates for checking
too - I don't see anything else in that error log that one could check
for?
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [FFmpeg-devel] [PATCH] configure: Check for DXGI_OUTDUPL_FRAME_INFO for the ddagrab filter
2022-08-01 12:56 ` Martin Storsjö
@ 2022-08-01 13:49 ` Hendrik Leppkes
2022-08-01 13:52 ` Timo Rothenpieler
0 siblings, 1 reply; 6+ messages in thread
From: Hendrik Leppkes @ 2022-08-01 13:49 UTC (permalink / raw)
To: FFmpeg development discussions and patches
On Mon, Aug 1, 2022 at 2:56 PM Martin Storsjö <martin@martin.st> wrote:
>
> On Mon, 1 Aug 2022, Hendrik Leppkes wrote:
>
> > On Mon, Aug 1, 2022 at 2:36 PM Martin Storsjö <martin@martin.st> wrote:
> >>
> >> The DXGI_OUTDUPL_FRAME_INFO type isn't available in Windows API
> >> subsets other than "desktop", while the IDXGIOutput1 interface is
> >> available for all API subsets.
> >>
> >> This fixes compilation for UWP/"Windows Store" configurations (and
> >> older API subsets like Windows Phone).
> >
> > The entire desktop duplication API is not present on Phone targets
> > (its called "desktop" duplication afterall). I think it would be
> > better to check for a primary DDA function, instead of some auxiliary
> > structure.
>
> FWIW, based on the MSVC error output
> (http://fate.ffmpeg.org/log.cgi?log=compile&slot=arm-msvc2019-phone&time=20220730152801),
> the only hard errors it listed were the undefined types
> (DXGI_OUTDUPL_POINTER_SHAPE_INFO and DXGI_OUTDUPL_FRAME_INFO) - but I
> presume that IDXGIOutputDuplication_AcquireNextFrame and
> IDXGIOutputDuplication_ReleaseFrame could be good candidates for checking
> too - I don't see anything else in that error log that one could check
> for?
I guess it doesn't really matter what we check for, and checking for
types seems easier then those macro'ed COM function wrappers. It just
felt slightly odd. But since its in already, no need to worry.
- Hendrik
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-08-01 13:53 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-01 12:35 [FFmpeg-devel] [PATCH] configure: Check for DXGI_OUTDUPL_FRAME_INFO for the ddagrab filter Martin Storsjö
2022-08-01 12:36 ` Timo Rothenpieler
2022-08-01 12:48 ` Hendrik Leppkes
2022-08-01 12:56 ` Martin Storsjö
2022-08-01 13:49 ` Hendrik Leppkes
2022-08-01 13:52 ` Timo Rothenpieler
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git