From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0E17C437B9 for ; Thu, 28 Jul 2022 22:04:05 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 54FCC68B9B9; Fri, 29 Jul 2022 01:04:03 +0300 (EEST) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 240CE68B8FC for ; Fri, 29 Jul 2022 01:03:57 +0300 (EEST) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 5707460002 for ; Thu, 28 Jul 2022 22:03:55 +0000 (UTC) Date: Fri, 29 Jul 2022 00:03:55 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20220728220355.GA2088045@pb2> References: MIME-Version: 1.0 In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 37/39] avcodec/mpegvideo_motion: Constify ff_mpv_motion X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============0465373781872353561==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============0465373781872353561== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5LK7OEqpP/xdrAG9" Content-Disposition: inline --5LK7OEqpP/xdrAG9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 27, 2022 at 12:08:12AM +0200, Andreas Rheinhardt wrote: > Also constify the corresponding code in mpegvideo.c that handles > lowres. > (Unfortunately, not everything that is const could be constified: > ref_picture could be made const uint8_t* const* if C allowed the > safe automatic conversion from uint8_t**; and pix_op, qpix_op > could be made to point to const function pointers, but C's handling > of const in pointers to arrays is broken.) >=20 > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/mpegvideo.c | 24 ++++++++++---------- > libavcodec/mpegvideo.h | 2 +- > libavcodec/mpegvideo_motion.c | 41 ++++++++++++++++++----------------- > libavcodec/wmv2.c | 4 ++-- > libavcodec/wmv2.h | 2 +- > 5 files changed, 37 insertions(+), 36 deletions(-) LGTM thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB If you drop bombs on a foreign country and kill a hundred thousand innocent people, expect your government to call the consequence "unprovoked inhuman terrorist attacks" and use it to justify dropping more bombs and killing more people. The technology changed, the idea is old. --5LK7OEqpP/xdrAG9 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCYuMHygAKCRBhHseHBAsP q9clAJ9JORsbep+IhQd2phobilq+kYzLBACfaAmeu1CfmZpvxsKQSo06GNrH/8M= =R42F -----END PGP SIGNATURE----- --5LK7OEqpP/xdrAG9-- --===============0465373781872353561== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============0465373781872353561==--