Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Niklas Haas <ffmpeg@haasn.xyz>
To: ffmpeg-devel@ffmpeg.org
Cc: Niklas Haas <git@haasn.dev>
Subject: [FFmpeg-devel] [PATCH v4 7/7] fate/png: add test for ICC profile parsing
Date: Thu, 28 Jul 2022 16:50:02 +0200
Message-ID: <20220728145002.102600-8-ffmpeg@haasn.xyz> (raw)
In-Reply-To: <20220728145002.102600-1-ffmpeg@haasn.xyz>

From: Niklas Haas <git@haasn.dev>

This tests the new "-flags2 icc_profiles" option by making sure the
embedded ICC profile gets correctly detected as sRGB.

Signed-off-by: Niklas Haas <git@haasn.dev>
---
 tests/fate/image.mak         |  4 +++
 tests/ref/fate/png-icc-parse | 48 ++++++++++++++++++++++++++++++++++++
 2 files changed, 52 insertions(+)
 create mode 100644 tests/ref/fate/png-icc-parse

diff --git a/tests/fate/image.mak b/tests/fate/image.mak
index fca4eaf60a..03e794dc48 100644
--- a/tests/fate/image.mak
+++ b/tests/fate/image.mak
@@ -392,6 +392,10 @@ fate-png-side-data: CMD = run ffprobe$(PROGSSUF)$(EXESUF) -show_frames \
 FATE_PNG_TRANSCODE-$(call TRANSCODE, PNG, IMAGE2 IMAGE_PNG_PIPE) += fate-png-icc
 fate-png-icc: CMD = transcode png_pipe $(TARGET_SAMPLES)/png1/lena-int_rgb24.png image2 "-c png" "" "-show_frames"
 
+FATE_PNG_PROBE-$(call ALLYES, LCMS2) += fate-png-icc-parse
+fate-png-icc-parse: CMD = run ffprobe$(PROGSSUF)$(EXESUF) -show_frames \
+    -flags2 icc_profiles $(TARGET_SAMPLES)/png1/lena-int_rgb24.png
+
 FATE_PNG-$(call DEMDEC, IMAGE2, PNG) += $(FATE_PNG)
 FATE_PNG_PROBE-$(call DEMDEC, IMAGE2, PNG) += $(FATE_PNG_PROBE)
 FATE_IMAGE_FRAMECRC += $(FATE_PNG-yes)
diff --git a/tests/ref/fate/png-icc-parse b/tests/ref/fate/png-icc-parse
new file mode 100644
index 0000000000..18bb18a804
--- /dev/null
+++ b/tests/ref/fate/png-icc-parse
@@ -0,0 +1,48 @@
+[FRAME]
+media_type=video
+stream_index=0
+key_frame=1
+pts=0
+pts_time=0.000000
+pkt_dts=0
+pkt_dts_time=0.000000
+best_effort_timestamp=0
+best_effort_timestamp_time=0.000000
+pkt_duration=1
+pkt_duration_time=0.040000
+duration=1
+duration_time=0.040000
+pkt_pos=0
+pkt_size=40194
+width=128
+height=128
+pix_fmt=rgb24
+sample_aspect_ratio=1:1
+pict_type=I
+coded_picture_number=0
+display_picture_number=0
+interlaced_frame=1
+top_field_first=0
+repeat_pict=0
+color_range=pc
+color_space=unknown
+color_primaries=bt709
+color_transfer=iec61966-2-1
+chroma_location=unspecified
+[SIDE_DATA]
+side_data_type=ICC profile
+name=Photoshop ICC profile
+size=3144
+[/SIDE_DATA]
+[SIDE_DATA]
+side_data_type=Mastering display metadata
+red_x=63999/100000
+red_y=33001/100000
+green_x=30000/100000
+green_y=60000/100000
+blue_x=15000/100000
+blue_y=5999/100000
+white_point_x=31269/100000
+white_point_y=32899/100000
+[/SIDE_DATA]
+[/FRAME]
-- 
2.37.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  parent reply	other threads:[~2022-07-28 14:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-28 14:49 [FFmpeg-devel] [PATCH v4 0/7] ICC profile support in avcodec Niklas Haas
2022-07-28 14:49 ` [FFmpeg-devel] [PATCH v4 1/7] fflcms2: move to libavcodec Niklas Haas
2022-07-28 14:49 ` [FFmpeg-devel] [PATCH v4 2/7] avcodec/codec_internal: add cap for ICC profile support Niklas Haas
2022-07-28 14:49 ` [FFmpeg-devel] [PATCH v4 3/7] avcodec: add API for automatic handling of icc profiles Niklas Haas
2022-07-28 14:49 ` [FFmpeg-devel] [PATCH v4 4/7] avcodec: add common fflcms2 boilerplate Niklas Haas
2022-07-28 14:50 ` [FFmpeg-devel] [PATCH v4 5/7] avcodec/decode: parse ICC profiles Niklas Haas
2022-07-28 14:50 ` [FFmpeg-devel] [PATCH v4 6/7] avcodec/encode:: generate " Niklas Haas
2022-07-28 14:50 ` Niklas Haas [this message]
2022-07-30  9:59 ` [FFmpeg-devel] [PATCH v4 0/7] ICC profile support in avcodec Niklas Haas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220728145002.102600-8-ffmpeg@haasn.xyz \
    --to=ffmpeg@haasn.xyz \
    --cc=ffmpeg-devel@ffmpeg.org \
    --cc=git@haasn.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git