From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E04A942094 for ; Wed, 27 Jul 2022 12:36:24 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4232968B984; Wed, 27 Jul 2022 15:36:18 +0300 (EEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id DFA6468B766 for ; Wed, 27 Jul 2022 15:36:11 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1658925377; x=1690461377; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ECiABz4inPlIKZpBpRswovB+bUEw26dlRbU2M7KkBZk=; b=kZdumus4qoLqqXTQZ35WxRQN8RXUiDaowQOx03RASnl1yAPI72jPBtp6 sFUTSCn+u/yAFsYx7WDgUQ284lHnxCuIrXTkr06RrkIvc+tfJoxwoU60/ mWlVGe7xuDybQz9cQuIAt9s8JySD0NlzNqeUvXKQKNB8hF1CDfJ38EJq5 ShBTk42zTIUWQzjpMtLfW/ddoBv8H4yr/8gElwKPlnBF+KSuF3EefduFd 7F2WYC5YAqOa+QU5w2p1RQC8mEF0NSLFYdRlt5FVGNjG562cGGevCUAvl aUiwMUtWZYzaEDI4eomp6KXdW593/Tt25o/VbFaGSoa6KZgnyTE6WImnt A==; X-IronPort-AV: E=McAfee;i="6400,9594,10420"; a="288231448" X-IronPort-AV: E=Sophos;i="5.93,195,1654585200"; d="scan'208";a="288231448" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jul 2022 05:36:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,195,1654585200"; d="scan'208";a="927772759" Received: from t.sh.intel.com ([10.239.159.159]) by fmsmga005.fm.intel.com with ESMTP; 27 Jul 2022 05:36:02 -0700 From: Fei Wang To: ffmpeg-devel@ffmpeg.org Date: Wed, 27 Jul 2022 20:36:31 +0800 Message-Id: <20220727123631.314004-2-fei.w.wang@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220727123631.314004-1-fei.w.wang@intel.com> References: <20220727123631.314004-1-fei.w.wang@intel.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v1 2/2] lavfi/overlay_vaapi: Set defalut alpha value as 1.0 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Fei Wang Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Previous default value 0.0 means 100% transparency for overlaid video, which make overlaid invisible. Change to 1.0 will let output video much more clear and less confuse if user doesn't specify alpha value. Signed-off-by: Fei Wang --- doc/filters.texi | 2 +- libavfilter/vf_overlay_vaapi.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index 47ac4dc7f4..76168955c6 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -26119,7 +26119,7 @@ Default value is the height of input overlay video. @item alpha Set transparency of overlaid video. Allowed range is 0.0 to 1.0, higher value means lower transparency. -Default value is @code{0.0}. +Default value is @code{1.0}. @end table diff --git a/libavfilter/vf_overlay_vaapi.c b/libavfilter/vf_overlay_vaapi.c index b3a624ae15..3e6a0de13f 100644 --- a/libavfilter/vf_overlay_vaapi.c +++ b/libavfilter/vf_overlay_vaapi.c @@ -380,7 +380,7 @@ static const AVOption overlay_vaapi_options[] = { { "h", "Overlay height", OFFSET(overlay_oh), AV_OPT_TYPE_INT, { .i64 = 0 }, 0, INT_MAX, .flags = FLAGS }, { "alpha", "Overlay global alpha", - OFFSET(alpha), AV_OPT_TYPE_FLOAT, { .dbl = 0.0}, 0.0, 1.0, .flags = FLAGS}, + OFFSET(alpha), AV_OPT_TYPE_FLOAT, { .dbl = 1.0}, 0.0, 1.0, .flags = FLAGS}, { NULL }, }; -- 2.25.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".