From: Fei Wang <fei.w.wang-at-intel.com@ffmpeg.org>
To: ffmpeg-devel@ffmpeg.org
Cc: Fei Wang <fei.w.wang@intel.com>
Subject: [FFmpeg-devel] [PATCH v1 2/2] lavfi/overlay_vaapi: Set defalut alpha value as 1.0
Date: Wed, 27 Jul 2022 20:36:31 +0800
Message-ID: <20220727123631.314004-2-fei.w.wang@intel.com> (raw)
In-Reply-To: <20220727123631.314004-1-fei.w.wang@intel.com>
Previous default value 0.0 means 100% transparency for overlaid video,
which make overlaid invisible. Change to 1.0 will let output video much
more clear and less confuse if user doesn't specify alpha value.
Signed-off-by: Fei Wang <fei.w.wang@intel.com>
---
doc/filters.texi | 2 +-
libavfilter/vf_overlay_vaapi.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/filters.texi b/doc/filters.texi
index 47ac4dc7f4..76168955c6 100644
--- a/doc/filters.texi
+++ b/doc/filters.texi
@@ -26119,7 +26119,7 @@ Default value is the height of input overlay video.
@item alpha
Set transparency of overlaid video. Allowed range is 0.0 to 1.0,
higher value means lower transparency.
-Default value is @code{0.0}.
+Default value is @code{1.0}.
@end table
diff --git a/libavfilter/vf_overlay_vaapi.c b/libavfilter/vf_overlay_vaapi.c
index b3a624ae15..3e6a0de13f 100644
--- a/libavfilter/vf_overlay_vaapi.c
+++ b/libavfilter/vf_overlay_vaapi.c
@@ -380,7 +380,7 @@ static const AVOption overlay_vaapi_options[] = {
{ "h", "Overlay height",
OFFSET(overlay_oh), AV_OPT_TYPE_INT, { .i64 = 0 }, 0, INT_MAX, .flags = FLAGS },
{ "alpha", "Overlay global alpha",
- OFFSET(alpha), AV_OPT_TYPE_FLOAT, { .dbl = 0.0}, 0.0, 1.0, .flags = FLAGS},
+ OFFSET(alpha), AV_OPT_TYPE_FLOAT, { .dbl = 1.0}, 0.0, 1.0, .flags = FLAGS},
{ NULL },
};
--
2.25.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-07-27 12:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-27 12:36 [FFmpeg-devel] [PATCH v1 1/2] doc/filters: correct description of overlay_vaapi Fei Wang
2022-07-27 12:36 ` Fei Wang [this message]
2022-07-27 13:21 ` [FFmpeg-devel] [PATCH v1 2/2] lavfi/overlay_vaapi: Set defalut alpha value as 1.0 Gyan Doshi
2022-08-05 6:12 ` Wang, Fei W
2022-07-27 13:14 ` [FFmpeg-devel] [PATCH v1 1/2] doc/filters: correct description of overlay_vaapi Gyan Doshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220727123631.314004-2-fei.w.wang@intel.com \
--to=fei.w.wang-at-intel.com@ffmpeg.org \
--cc=fei.w.wang@intel.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git