From: Tom Yan <tom.ty89@gmail.com> To: ffmpeg-devel@ffmpeg.org Cc: Tom Yan <tom.ty89@gmail.com> Subject: [FFmpeg-devel] [PATCH] avformat/riffdec: fix support for WAVEFORMAT Date: Mon, 25 Jul 2022 17:36:47 +0800 Message-ID: <20220725093647.4417-1-tom.ty89@gmail.com> (raw) WAVEFORMAT can be used for 16-bit PCM as well. Signed-off-by: Tom Yan <tom.ty89@gmail.com> --- libavformat/riffdec.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavformat/riffdec.c b/libavformat/riffdec.c index 3946ecb72f..8289438f08 100644 --- a/libavformat/riffdec.c +++ b/libavformat/riffdec.c @@ -94,7 +94,7 @@ static void parse_waveformatex(AVFormatContext *s, AVIOContext *pb, AVCodecParam int ff_get_wav_header(AVFormatContext *s, AVIOContext *pb, AVCodecParameters *par, int size, int big_endian) { - int id, channels; + int id, channels = 0; uint64_t bitrate = 0; if (size < 14) { @@ -118,15 +118,15 @@ int ff_get_wav_header(AVFormatContext *s, AVIOContext *pb, bitrate = avio_rb32(pb) * 8LL; par->block_align = avio_rb16(pb); } - if (size == 14) { /* We're dealing with plain vanilla WAVEFORMAT */ - par->bits_per_coded_sample = 8; - } else { + if (size >= 16) { /* We're dealing with PCMWAVEFORMAT */ if (!big_endian) { par->bits_per_coded_sample = avio_rl16(pb); } else { par->bits_per_coded_sample = avio_rb16(pb); } - } + } else if (channels && par->sample_rate) { /* We're dealing with WAVEFORMAT */ + par->bits_per_coded_sample = bitrate / channels / par->sample_rate; + } /* Apparently size would be >= 32 if id == 0x0165; see below */ if (id == 0xFFFE) { par->codec_tag = 0; } else { -- 2.37.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
reply other threads:[~2022-07-25 9:37 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220725093647.4417-1-tom.ty89@gmail.com \ --to=tom.ty89@gmail.com \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git