From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id BA95842417 for ; Tue, 19 Jul 2022 22:11:53 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8138E68B606; Wed, 20 Jul 2022 01:11:50 +0300 (EEST) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 87FB568B312 for ; Wed, 20 Jul 2022 01:11:43 +0300 (EEST) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 9400E240002 for ; Tue, 19 Jul 2022 22:11:42 +0000 (UTC) Date: Wed, 20 Jul 2022 00:11:41 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20220719221141.GW2088045@pb2> References: <20220719165656.640869-1-emil.l.velikov@gmail.com> <20220719165656.640869-2-emil.l.velikov@gmail.com> MIME-Version: 1.0 In-Reply-To: <20220719165656.640869-2-emil.l.velikov@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH 1/3] hwcontext_vaapi: do not link against libva-x11.so X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============7018766095808524466==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============7018766095808524466== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="cxfMsoqvp1jUizWj" Content-Disposition: inline --cxfMsoqvp1jUizWj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 19, 2022 at 05:56:54PM +0100, Emil Velikov wrote: > From: Emil Velikov >=20 > There is an internal ABI between libva.so the libva-XXX.so libraries. >=20 > With a recent change, the internal va_fool API was removed breaking the > ABI. So if libva.so and libva-x11.so are from different version, the > whole stack will crash. >=20 > Instead we can dlopen() the libva-x11 library and gracefully error out. >=20 > Cc: Mark Thompson > Signed-off-by: Emil Velikov > --- > Greetings team, please consider backporting this for the stable > releases. >=20 > I've noticed that we've got plenty of pre-existing memory and state > leaks in vaapi_device_create(). Would it make sense to fix those up? If > so I can follow-up with a patch. > --- > configure | 2 +- > libavutil/hwcontext_vaapi.c | 34 +++++++++++++++++++++++++++++++++- > 2 files changed, 34 insertions(+), 2 deletions(-) =2E./configure --enable-gpl --cc=3D'ccache gcc' --enable-version3 --ena= ble-vdpau make -j32 =2E.. LD ffmpeg_g /usr/bin/ld: libavutil/libavutil.a(hwcontext_vaapi.o): undefined reference = to symbol 'dlclose@@GLIBC_2.2.5' //lib/x86_64-linux-gnu/libdl.so.2: error adding symbols: DSO missing from c= ommand line collect2: error: ld returned 1 exit status /home/michael/ffmpeg-git/ffmpeg/Makefile:131: recipe for target 'ffmpeg_g' = failed make: *** [ffmpeg_g] Error 1 [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB If you think the mosad wants you dead since a long time then you are either wrong or dead since a long time. --cxfMsoqvp1jUizWj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCYtcsHQAKCRBhHseHBAsP q2j5AKCSw0AxiF0VTp2vR3h+OxphHo0AVwCeOy0qgPGza0tFKlxDe8w+lSX+ZxA= =9dev -----END PGP SIGNATURE----- --cxfMsoqvp1jUizWj-- --===============7018766095808524466== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============7018766095808524466==--