From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E97AE43B8B for ; Tue, 19 Jul 2022 17:53:21 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 63B8968ABD8; Tue, 19 Jul 2022 20:53:18 +0300 (EEST) Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A2A4068ABD8 for ; Tue, 19 Jul 2022 20:53:11 +0300 (EEST) Received: by mail-wm1-f49.google.com with SMTP id a11so3287966wmq.3 for ; Tue, 19 Jul 2022 10:53:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=2Z5oMODHCLEbzV5rWWRnBkxnPzymy6KWHn383mRo6+Y=; b=iWsoZPxlYH50ybRPqN0SRVT8mx+9TL78WP2Hvxyz263b5F8KG5yKGzOOJLU2rXSqhk PiEgC6xu7nWNBIBgkjWw9QvQy+TQdEnRD8Bpqa4z8XBe6uKUiBRqiGRTEa4zokWq8sAL KeemKdlmkptEIyRXRDiLHPIAz3fTDG7LgMPWFw73bBWtl6gRLCaiifI2GaMzncH8Hg52 PigMu0FhzgvzOCh571Foy1BZtWFd15cLm/1jDU8VmdvKUeFXnewykS8Qw0uaNfm4i6+L zCrJeceibH7vdPLFBAdjhfLEL/U+UydM3awp6RD9tsfbkBwCBjHeKiBG2tE5QqJzPUt+ YArA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=2Z5oMODHCLEbzV5rWWRnBkxnPzymy6KWHn383mRo6+Y=; b=Y7Yj6ToQsRP2yVHw3YjUdhgtrmMyxHoFPvoRV8VRWpjx+K/8Kv8duteCEvmh95b5wm 9jCnhm292BOH1WrNEN2LpgihkbxRIBCSaUKy+eAqhPaYwas/tj0p4JBmH+lmyDUkQoEr AgiPHj23ANxQkkjAtB41jcGqKFLfGMskfvtnnD7IWm/pgrvpcaNsv1q7qniPnT0AKm6z snnuQ6C9MXYXRMZb1cm3SE1wJ7hKff3CaqmWZ2vvIjYwinvgxxbrTCKyPLofcb+XcRk3 tc81x6EMmi6RZVJ/n4UXIgu9+7O9X6g47pCdVIOHIEGXqn2gIsDeoJaDH+cZUM9aM4SI IJ8g== X-Gm-Message-State: AJIora+XhwrBl4PDz7hZRT7yzUOH0o6+lKWS7dzB/hGzSBFY243A5Mt8 Nx2IWjnzTlw/rY/B2pN3VUHecCKzIpImow== X-Google-Smtp-Source: AGRyM1vnh1kZg8a/CygY8yIAKL37WdFlSGeqjO/I/gdW+XfNwUr9LTpF/TybDmZBE5/yLzKn51ZJug== X-Received: by 2002:a05:600c:1e8f:b0:3a3:1cfc:ba6 with SMTP id be15-20020a05600c1e8f00b003a31cfc0ba6mr388507wmb.177.1658253190961; Tue, 19 Jul 2022 10:53:10 -0700 (PDT) Received: from localhost ([2a00:5f00:102:0:ed02:7072:7dbf:2431]) by smtp.gmail.com with UTF8SMTPSA id k20-20020a05600c1c9400b003a31fd05e0fsm5452664wms.2.2022.07.19.10.53.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Jul 2022 10:53:10 -0700 (PDT) From: Emil Velikov To: ffmpeg-devel@ffmpeg.org Date: Tue, 19 Jul 2022 18:53:07 +0100 Message-Id: <20220719175310.647621-1-emil.l.velikov@gmail.com> X-Mailer: git-send-email 2.37.0 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v2 0/3] hwcontext_vaapi: dlopen libva-x11 and libva-drm X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Mark Thompson , emil.l.velikov@gmail.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Greetings everyone, As you may know the libva* set of libraries share an internal ABI between them. In a resent libva commit, the va_fool API was removed. Thus if one is to mix different versions of libva.so and libva-x11.so they will get an error, leading to a crash of the whole stack. The simple solution is to dlopen() the winsys components, like libva-x11 and libva-drm. The changes are pretty minor and allow us to handle this king of issues. Comments and suggestions are welcome, but please me gentle it's my first time hacking on ffmpeg :-P Thanks Emil Changes in v2: - add linkage against libdl Aside: - Please consider backporting it to the stable branches in due time. - I've noticed that we leak state in the error paths, happy to send follow-up patches if you'd like those fixed. - My TODO includes reducing the massive ABI between libva* and backend drivers, to a single extra "registration" API entrypoint. Emil Velikov (3): hwcontext_vaapi: do not link against libva-x11.so hwcontext_vaapi: do not link against libva-drm.so hwcontext_vaapi: #if guard VAAPI_DRM specifics configure | 2 +- libavutil/hwcontext_vaapi.c | 92 +++++++++++++++++++++++++++++++++++-- 2 files changed, 90 insertions(+), 4 deletions(-) -- 2.37.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".