From: Emil Velikov <emil.l.velikov@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Cc: Mark Thompson <sw@jkqxz.net>, emil.l.velikov@gmail.com
Subject: [FFmpeg-devel] [PATCH v2 0/3] hwcontext_vaapi: dlopen libva-x11 and libva-drm
Date: Tue, 19 Jul 2022 18:53:07 +0100
Message-ID: <20220719175310.647621-1-emil.l.velikov@gmail.com> (raw)
Greetings everyone,
As you may know the libva* set of libraries share an internal ABI
between them. In a resent libva commit, the va_fool API was removed.
Thus if one is to mix different versions of libva.so and libva-x11.so
they will get an error, leading to a crash of the whole stack.
The simple solution is to dlopen() the winsys components, like libva-x11
and libva-drm. The changes are pretty minor and allow us to handle this
king of issues.
Comments and suggestions are welcome, but please me gentle it's my first
time hacking on ffmpeg :-P
Thanks
Emil
Changes in v2:
- add linkage against libdl
Aside:
- Please consider backporting it to the stable branches in due time.
- I've noticed that we leak state in the error paths, happy to send
follow-up patches if you'd like those fixed.
- My TODO includes reducing the massive ABI between libva* and
backend drivers, to a single extra "registration" API entrypoint.
Emil Velikov (3):
hwcontext_vaapi: do not link against libva-x11.so
hwcontext_vaapi: do not link against libva-drm.so
hwcontext_vaapi: #if guard VAAPI_DRM specifics
configure | 2 +-
libavutil/hwcontext_vaapi.c | 92 +++++++++++++++++++++++++++++++++++--
2 files changed, 90 insertions(+), 4 deletions(-)
--
2.37.0
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next reply other threads:[~2022-07-19 17:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-19 17:53 Emil Velikov [this message]
2022-07-19 18:16 ` Nicolas George
2022-07-20 16:41 ` Emil Velikov
2022-07-21 20:47 ` Mark Thompson
2022-07-27 19:51 ` Emil Velikov
2022-07-27 20:00 ` Timo Rothenpieler
2022-07-29 16:43 ` Emil Velikov
2022-08-03 13:16 ` Emil Velikov
2022-07-20 10:56 Emil Velikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220719175310.647621-1-emil.l.velikov@gmail.com \
--to=emil.l.velikov@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=sw@jkqxz.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git