From: Emil Velikov <emil.l.velikov@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Cc: Mark Thompson <sw@jkqxz.net>, emil.l.velikov@gmail.com
Subject: [FFmpeg-devel] [PATCH 3/3] hwcontext_vaapi: #if guard VAAPI_DRM specifics
Date: Tue, 19 Jul 2022 17:56:56 +0100
Message-ID: <20220719165656.640869-4-emil.l.velikov@gmail.com> (raw)
In-Reply-To: <20220719165656.640869-1-emil.l.velikov@gmail.com>
From: Emil Velikov <emil.velikov@collabora.com>
Similar to the VAAPI_X11 bits, guard all the VAAPI_DRM parts behind an
disabled.
Cc: Mark Thompson <sw@jkqxz.net>
Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
---
libavutil/hwcontext_vaapi.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/libavutil/hwcontext_vaapi.c b/libavutil/hwcontext_vaapi.c
index 7734a50fc0..7aea3e7b96 100644
--- a/libavutil/hwcontext_vaapi.c
+++ b/libavutil/hwcontext_vaapi.c
@@ -18,6 +18,10 @@
#include "config.h"
+#if !HAVE_VAAPI_X11 && !HAVE_VAAPI_DRM
+#error "At least one VAAPI winsys is required X11 or DRM"
+#endif
+
#if CONFIG_VAAPI_1
# define VA_ABI ".2"
#else
@@ -68,8 +72,10 @@ typedef struct VAAPIDevicePriv {
Display *x11_display;
#endif
+#if HAVE_VAAPI_DRM
void *libva_drm;
int drm_fd;
+#endif
} VAAPIDevicePriv;
typedef struct VAAPISurfaceFormat {
@@ -1583,10 +1589,12 @@ static void vaapi_device_free(AVHWDeviceContext *ctx)
XCloseDisplay(priv->x11_display);
#endif
+#if HAVE_VAAPI_DRM
if (priv->drm_fd >= 0)
close(priv->drm_fd);
if (priv->libva_drm)
dlclose(priv->libva_drm);
+#endif
av_freep(&priv);
}
@@ -1645,7 +1653,9 @@ static int vaapi_device_create(AVHWDeviceContext *ctx, const char *device,
if (!priv)
return AVERROR(ENOMEM);
+#if HAVE_VAAPI_DRM
priv->drm_fd = -1;
+#endif
ctx->user_opaque = priv;
ctx->free = vaapi_device_free;
--
2.37.0
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-07-19 16:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-19 16:56 [FFmpeg-devel] [PATCH 0/3] hwcontext_vaapi: dlopen libva-x11 and libva-drm Emil Velikov
2022-07-19 16:56 ` [FFmpeg-devel] [PATCH 1/3] hwcontext_vaapi: do not link against libva-x11.so Emil Velikov
2022-07-19 22:11 ` Michael Niedermayer
2022-07-19 16:56 ` [FFmpeg-devel] [PATCH 2/3] hwcontext_vaapi: do not link against libva-drm.so Emil Velikov
2022-07-19 16:56 ` Emil Velikov [this message]
2022-07-19 17:20 ` [FFmpeg-devel] [PATCH 0/3] hwcontext_vaapi: dlopen libva-x11 and libva-drm Emil Velikov
-- strict thread matches above, loose matches on Subject: below --
2022-07-19 16:56 [FFmpeg-devel] [PATCH 1/3] hwcontext_vaapi: do not link against libva-x11.so Emil Velikov
2022-07-19 16:56 ` [FFmpeg-devel] [PATCH 3/3] hwcontext_vaapi: #if guard VAAPI_DRM specifics Emil Velikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220719165656.640869-4-emil.l.velikov@gmail.com \
--to=emil.l.velikov@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=sw@jkqxz.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git