From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 21501435FF for ; Tue, 19 Jul 2022 12:18:43 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0660368B3FF; Tue, 19 Jul 2022 15:18:40 +0300 (EEST) Received: from haasn.dev (haasn.dev [78.46.187.166]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 88D1C68B2BA for ; Tue, 19 Jul 2022 15:18:33 +0300 (EEST) Received: from haasn.dev (unknown [10.30.0.2]) by haasn.dev (Postfix) with ESMTP id 011ED4A906 for ; Tue, 19 Jul 2022 14:18:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=haasn.xyz; s=mail; t=1658233112; bh=d9QLHCkdWre9VUDZHYPRFnMXdF/TUFYrYY0L/E49xlw=; h=Date:From:To:Subject:In-Reply-To:References:From; b=b5O3NoqWw7pIomfPw06ysbgimkxtG+8vFCCu5FMmIWQY//1rkdwfDQvOXWM9+5lI5 j2h/24+J8jEKxIxBtvOrtY8JIqyimzETJOB0CDDGpF1ibmUxlY4JgKr4SUsD1hbMDb XvrclrA6J/bdmQdTg9MqtiQTRiA7zNjsROUNa9Mc= Date: Tue, 19 Jul 2022 14:18:31 +0200 Message-ID: <20220719141831.GC36985@haasn.xyz> From: Niklas Haas To: FFmpeg development discussions and patches In-Reply-To: <165711454150.31466.7860347731374018477@lain.khirnov.net> References: <20220629101251.13236-1-ffmpeg@haasn.xyz> <20220629101251.13236-7-ffmpeg@haasn.xyz> <165711454150.31466.7860347731374018477@lain.khirnov.net> MIME-Version: 1.0 Content-Disposition: inline Subject: Re: [FFmpeg-devel] [PATCH v2 6/6] avcodec/encode:: generate ICC profiles X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Wed, 06 Jul 2022 15:35:41 +0200 Anton Khirnov wrote: > Quoting Niklas Haas (2022-06-29 12:12:51) > > From: Niklas Haas > > > > Only if requested, and only if the codec signals support for ICC > > profiles. Implementation roughly matches the functionality of the > > existing vf_iccgen filter, albeit with some reduced flexibility and no > > caching. > > > > Ideally, we'd also only do this on the first frame (e.g. mjpeg, apng), > > but there's no meaningful way for us to distinguish between this case > > and e.g. somebody using the image2 muxer, in which case we'd want to > > attach ICC profiles to every frame in the stream. > > AV_CODEC_FLAG_GLOBAL_HEADER? This seems marginally unrelated - apng etc. don't have extradata, and none of the relevant codecs set this flag either. At best we could introduce a new flag, but to be honest I don't think it's a huge issue because apng and mjpeg with ICC profiles are exceptionally rare, and the worst case is merely wasting some file space. > > -- > Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".