From: Niklas Haas <ffmpeg@haasn.xyz>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v2 6/6] avcodec/encode:: generate ICC profiles
Date: Tue, 19 Jul 2022 14:18:31 +0200
Message-ID: <20220719141831.GC36985@haasn.xyz> (raw)
In-Reply-To: <165711454150.31466.7860347731374018477@lain.khirnov.net>
On Wed, 06 Jul 2022 15:35:41 +0200 Anton Khirnov <anton@khirnov.net> wrote:
> Quoting Niklas Haas (2022-06-29 12:12:51)
> > From: Niklas Haas <git@haasn.dev>
> >
> > Only if requested, and only if the codec signals support for ICC
> > profiles. Implementation roughly matches the functionality of the
> > existing vf_iccgen filter, albeit with some reduced flexibility and no
> > caching.
> >
> > Ideally, we'd also only do this on the first frame (e.g. mjpeg, apng),
> > but there's no meaningful way for us to distinguish between this case
> > and e.g. somebody using the image2 muxer, in which case we'd want to
> > attach ICC profiles to every frame in the stream.
>
> AV_CODEC_FLAG_GLOBAL_HEADER?
This seems marginally unrelated - apng etc. don't have extradata, and
none of the relevant codecs set this flag either. At best we could
introduce a new flag, but to be honest I don't think it's a huge issue
because apng and mjpeg with ICC profiles are exceptionally rare, and the
worst case is merely wasting some file space.
>
> --
> Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-07-19 12:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 10:12 [FFmpeg-devel] [PATCH v2 0/6] ICC profile support in avcodec Niklas Haas
2022-06-29 10:12 ` [FFmpeg-devel] [PATCH v2 1/6] fflcms2: move to libavcodec Niklas Haas
2022-07-06 14:18 ` Andreas Rheinhardt
2022-07-12 12:09 ` Niklas Haas
2022-06-29 10:12 ` [FFmpeg-devel] [PATCH v2 2/6] avcodec/codec_internal: add cap for ICC profile support Niklas Haas
2022-06-29 10:12 ` [FFmpeg-devel] [PATCH v2 3/6] avcodec: add API for automatic handling of icc profiles Niklas Haas
2022-07-06 13:34 ` Anton Khirnov
2022-06-29 10:12 ` [FFmpeg-devel] [PATCH v2 4/6] avcodec: add common fflcms2 boilerplate Niklas Haas
2022-06-29 10:12 ` [FFmpeg-devel] [PATCH v2 5/6] avcodec/decode: parse ICC profiles Niklas Haas
2022-06-29 10:12 ` [FFmpeg-devel] [PATCH v2 6/6] avcodec/encode:: generate " Niklas Haas
2022-07-06 13:35 ` Anton Khirnov
2022-07-19 12:18 ` Niklas Haas [this message]
2022-07-02 21:05 ` [FFmpeg-devel] [PATCH v2 0/6] ICC profile support in avcodec Niklas Haas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220719141831.GC36985@haasn.xyz \
--to=ffmpeg@haasn.xyz \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git