From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id BFA82412D0 for ; Tue, 19 Jul 2022 11:54:52 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CA91F68B59C; Tue, 19 Jul 2022 14:54:49 +0300 (EEST) Received: from relay10.mail.gandi.net (relay10.mail.gandi.net [217.70.178.230]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B0A6368B1F1 for ; Tue, 19 Jul 2022 14:54:43 +0300 (EEST) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id DE356240003 for ; Tue, 19 Jul 2022 11:54:42 +0000 (UTC) Date: Tue, 19 Jul 2022 13:54:41 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20220719115441.GV2088045@pb2> References: <20220711214417.12286-1-michael@niedermayer.cc> MIME-Version: 1.0 In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 1/3] avformat/mxfdec: SMPTE RDD 48:2018 support X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============2242572307226846151==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============2242572307226846151== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="s0H35NU0PUc8VBh+" Content-Disposition: inline --s0H35NU0PUc8VBh+ Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 18, 2022 at 08:35:00PM +0200, Tomas H=E4rdin wrote: > m=E5n 2022-07-11 klockan 23:44 +0200 skrev Michael Niedermayer: > > Signed-off-by: Michael Niedermayer > > --- > > =A0libavformat/mxf.c=A0=A0=A0 |=A0 3 +++ > > =A0libavformat/mxf.h=A0=A0=A0 |=A0 1 + > > =A0libavformat/mxfdec.c | 48 > > ++++++++++++++++++++++++++++++++++++++++++++ > > =A03 files changed, 52 insertions(+) > >=20 > > diff --git a/libavformat/mxf.c b/libavformat/mxf.c > > index 36d662b58c..8ef928b8fc 100644 > > --- a/libavformat/mxf.c > > +++ b/libavformat/mxf.c > > @@ -66,6 +66,9 @@ const MXFCodecUL ff_mxf_codec_uls[] =3D { > > =A0=A0=A0=A0 { { > > 0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x0A,0x04,0x01,0x02,0x01,0x01,0x02 > > ,0x02,0x01 }, 16,=A0=A0=A0=A0=A0=A0 AV_CODEC_ID_V210 }, /* V210 */ > > =A0=A0=A0=A0 { { > > 0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x01,0x0E,0x04,0x02,0x01,0x02,0x11 > > ,0x00,0x00 }, 14,=A0=A0=A0=A0 AV_CODEC_ID_PRORES }, /* Avid MC7 ProRes = */ > > =A0=A0=A0=A0 { { > > 0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x0D,0x04,0x01,0x02,0x02,0x03,0x06 > > ,0x00,0x00 }, 14,=A0=A0=A0=A0 AV_CODEC_ID_PRORES }, /* Apple ProRes */ > > +=A0=A0=A0 { { > > 0x06,0x0e,0x2b,0x34,0x04,0x01,0x01,0x0D,0x04,0x01,0x02,0x02,0x03,0x09 > > ,0x01,0x00 }, 15,=A0=A0=A0=A0=A0=A0 AV_CODEC_ID_FFV1 }, /*FFV1 V0 */ > > +=A0=A0=A0 { { > > 0x06,0x0e,0x2b,0x34,0x04,0x01,0x01,0x0D,0x04,0x01,0x02,0x02,0x03,0x09 > > ,0x02,0x00 }, 15,=A0=A0=A0=A0=A0=A0 AV_CODEC_ID_FFV1 }, /*FFV1 V1 */ > > +=A0=A0=A0 { { > > 0x06,0x0e,0x2b,0x34,0x04,0x01,0x01,0x0D,0x04,0x01,0x02,0x02,0x03,0x09 > > ,0x04,0x00 }, 15,=A0=A0=A0=A0=A0=A0 AV_CODEC_ID_FFV1 }, /*FFV1 V3 */ >=20 > I do not see these ULs listed in the spec. Are they in some appropriate > RP? >=20 > > +static const uint8_t mxf_ffv1_extradata[]=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0 =3D { > > 0x06,0x0e,0x2b,0x34,0x01,0x01,0x01,0x0e,0x04,0x01,0x06,0x0c,0x01,0x00 > > ,0x00,0x00 }; >=20 > Nor do I see this UL. In fact the spec doesn't seem to mention FFV1 at > all unless my eyes deceive me. you need this: SMPTE RDD 48:2018 Amendment 1:2022 i will update the patch to list this correctly [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB "Nothing to hide" only works if the folks in power share the values of you and everyone you know entirely and always will -- Tom Scott --s0H35NU0PUc8VBh+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCYtabgQAKCRBhHseHBAsP q7udAJ0egkI9Gu6nU95Vd1lEnYPqaZ16vgCfSB+zNlUipIGBXnHHeAEKuXVWYbo= =ZvvY -----END PGP SIGNATURE----- --s0H35NU0PUc8VBh+-- --===============2242572307226846151== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============2242572307226846151==--