From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9CF5C43606 for ; Tue, 19 Jul 2022 11:45:07 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0E2F668B495; Tue, 19 Jul 2022 14:45:05 +0300 (EEST) Received: from relay12.mail.gandi.net (relay12.mail.gandi.net [217.70.178.232]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1DA9A68B1AE for ; Tue, 19 Jul 2022 14:44:58 +0300 (EEST) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 41E48200003 for ; Tue, 19 Jul 2022 11:44:57 +0000 (UTC) Date: Tue, 19 Jul 2022 13:44:56 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20220719114456.GU2088045@pb2> References: <20220717220619.GO2088045@pb2> <20220718071225.4446-1-anton@khirnov.net> <8f3313ba-de91-6ea7-6bef-03ea0dfe0d33@gmail.com> <165816813316.15564.17775576086260685988@lain.khirnov.net> <165816899644.15564.7193672473745920414@lain.khirnov.net> MIME-Version: 1.0 In-Reply-To: <165816899644.15564.7193672473745920414@lain.khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH] lavc/libx264: support AV_CODEC_CAP_ENCODER_RECON_FRAME X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============8969807562302678593==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============8969807562302678593== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fxBYc4U7HLIDBZ2G" Content-Disposition: inline --fxBYc4U7HLIDBZ2G Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 18, 2022 at 08:29:56PM +0200, Anton Khirnov wrote: > Quoting James Almer (2022-07-18 20:18:16) > >=20 > >=20 > > On 7/18/2022 3:15 PM, Anton Khirnov wrote: > > > Quoting James Almer (2022-07-18 14:23:58) > > >> On 7/18/2022 4:12 AM, Anton Khirnov wrote: > > >>> --- > > >>> libavcodec/libx264.c | 52 ++++++++++++++++++++++++++++++++++++++= +++++- > > >>> 1 file changed, 51 insertions(+), 1 deletion(-) > > >>> > > >>> diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c > > >>> index 98ec030865..5e360682e6 100644 > > >>> --- a/libavcodec/libx264.c > > >>> +++ b/libavcodec/libx264.c > > >>> @@ -311,6 +311,25 @@ static void free_picture(AVCodecContext *ctx) > > >>> pic->extra_sei.num_payloads =3D 0; > > >>> } > > >>> =20 > > >>> +static enum AVPixelFormat csp_to_pixfmt(int csp) > > >>> +{ > > >>> + switch (csp) { > > >>> +#ifdef X264_CSP_I400 > > >>> + case X264_CSP_I400: return AV_PIX_FMT_= GRAY8; > > >>> + case X264_CSP_I400 | X264_CSP_HIGH_DEPTH: return AV_PIX_FMT_= GRAY10; > > >>> +#endif > > >>> + case X264_CSP_I420: return AV_PIX_FMT_= YUV420P; > > >>> + case X264_CSP_I420 | X264_CSP_HIGH_DEPTH: return AV_PIX_FMT_= YUV420P10; > > >>> + case X264_CSP_I422: return AV_PIX_FMT_= YUV422P; > > >>> + case X264_CSP_I422 | X264_CSP_HIGH_DEPTH: return AV_PIX_FMT_= YUV422P10; > > >>> + case X264_CSP_I444: return AV_PIX_FMT_= YUV444P; > > >>> + case X264_CSP_I444 | X264_CSP_HIGH_DEPTH: return AV_PIX_FMT_= YUV444P10; > > >> > > >> We're still supporting old x264 versions, so you should add some > > >> considerations for 9 bit pixfmts. On X264_BUILD < 153, just check the > > >> value of x264_bit_depth. > > >=20 > > > Is there much point in continuing to support 5.5 year old x264? We co= uld > > > drop a lot of ugliness, including the abominable X264_init_static(). > >=20 > > Afaik we tend to support what's shipped with not yet EOL'd big distros= =20 > > like Debian and Ubuntu. I assume Michael's Ubuntu setup is one of those= ,=20 > > and it has a libx264 without X264_CSP_I400, for example. >=20 > Debian oldstable has libx264 155 at least. Ubuntu 18.04LTS has 152 https://packages.ubuntu.com/search?keywords=3Dx264&searchon=3Dnames&suite= =3Dbionic§ion=3Dall [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I have never wished to cater to the crowd; for what I know they do not approve, and what they approve I do not know. -- Epicurus --fxBYc4U7HLIDBZ2G Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCYtaZMAAKCRBhHseHBAsP q1trAJ97MocAq8fKwaUk3MhszxusHVUD/gCeOeEvbQqku0gx6yfC8Tnvc2KOGKw= =3fIS -----END PGP SIGNATURE----- --fxBYc4U7HLIDBZ2G-- --===============8969807562302678593== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============8969807562302678593==--