Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: facefunk <facefunk@fcfnk.com>
To: ffmpeg-devel@ffmpeg.org
Subject: [FFmpeg-devel] (no subject)
Date: Sun, 17 Jul 2022 14:32:54 +0100
Message-ID: <20220717133256.35929-1-facefunk@fcfnk.com> (raw)

Hi FFMDevs,

I've managed to get forced mov_text subtitles working in VLC Player. -disposition:s:0 +forced is honored but I'm not 100% sure about my approach.

The attached patch represents the best idea I came up with so far as the code is minimal and it doesn't require the user to set any extra parameters, however it does puncture an abstraction boundary ever so slightly by copying stream data to the codec, perhaps this isn't a problem.

If there's anybody who could look over my patch and let me know if there's a better way of going about this, that would be greatly appreciated. 

Love your work!

Kind regards,

facefunk

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

             reply	other threads:[~2022-07-17 13:33 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-17 13:32 facefunk [this message]
2022-07-17 13:32 ` [FFmpeg-devel] [PATCH 1/2] Typos facefunk
2022-07-17 13:32 ` [FFmpeg-devel] [PATCH 2/2] Copy AVStream disposition to AVCodecContext and use to set DISPLAY_FLAG_ALL_SAMPLES_FORCED in movtextenc.c facefunk
2022-07-18 16:08 ` [FFmpeg-devel] Make disposition forced work with mov_text subtitles facefunk
2022-07-18 16:08   ` [FFmpeg-devel] [PATCH 1/3] libavcodec: " facefunk
2022-07-18 16:57     ` Michael Niedermayer
2022-07-18 20:00     ` [FFmpeg-devel] " facefunk
2022-07-18 20:00       ` [FFmpeg-devel] [PATCH v3] libavcodec: " facefunk
2022-07-18 16:08   ` [FFmpeg-devel] [PATCH 2/3] libavcodec: Correct typo in mov_text encoder class name facefunk
2022-07-18 16:08   ` [FFmpeg-devel] [PATCH 3/3] libavutil: Correct number of parameters in flag type options documentation facefunk
2022-07-18 17:48   ` [FFmpeg-devel] Make disposition forced work with mov_text subtitles Leo Izen
2022-07-18 18:01     ` facefunk
2022-07-18 20:07     ` facefunk
2023-02-09 14:25 [FFmpeg-devel] [PATCH] avdevice/xcbgrab: enable window resizing aline.gondimsantos
2023-02-09 18:19 ` [FFmpeg-devel] (no subject) Aline Gondim Santos
2023-07-17  7:08 Водянников Александр
2023-10-14  8:39 Logan.Lyu
2023-10-14  8:39 Logan.Lyu
2023-10-14  8:40 Logan.Lyu
2023-10-14  8:40 Logan.Lyu
2024-04-18  7:36 pengxu
2024-04-18  9:42 pengxu
2024-08-07 15:58 cyfdel-at-hotmail.com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220717133256.35929-1-facefunk@fcfnk.com \
    --to=facefunk@fcfnk.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git