From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v2 4/5] libswscale: Enable hscale_avx2 for all input sizes.
Date: Thu, 14 Jul 2022 18:56:12 +0200
Message-ID: <20220714165612.GC2088045@pb2> (raw)
In-Reply-To: <20220217100420.1113388-1-alankelly@google.com>
[-- Attachment #1.1: Type: text/plain, Size: 2060 bytes --]
On Thu, Feb 17, 2022 at 11:04:20AM +0100, Alan Kelly wrote:
> ff_shuffle_filter_coefficients shuffles the tail as required.
> ---
> libswscale/utils.c | 19 ++++++++++++++++---
> libswscale/x86/swscale.c | 6 ++----
> 2 files changed, 18 insertions(+), 7 deletions(-)
it seems patch 3 and 4 together fail fate with current git master
(i think 1 & 2 are already applied)
make V=2 fate-checkasm-sw_scale
TEST checkasm-sw_scale
./tests/fate-run.sh fate-checkasm-sw_scale "fate-suite/" "" "ffmpeg" 'run tests/checkasm/checkasm --test=sw_scale' 'null' '' '' '1' '' '' '' '' '' '' '' '' '' ''
ffmpeg/tests/checkasm/checkasm --test=sw_scale
Test checkasm-sw_scale failed. Look at tests/data/fate/checkasm-sw_scale.err for details.
checkasm: using random seed 1761410321
MMXEXT:
- sw_scale.yuv2yuvX [OK]
SSE2:
- sw_scale.hscale [OK]
SSE3:
- sw_scale.yuv2yuvX [OK]
SSSE3:
- sw_scale.hscale [OK]
SSE4.1:
- sw_scale.hscale [OK]
AVX2:
hscale_8_to_15__fs_4_dstW_8_avx2 (sw_scale.c:235)
hscale_8_to_15__fs_4_dstW_24_avx2 (sw_scale.c:235)
hscale_8_to_15__fs_8_dstW_8_avx2 (sw_scale.c:235)
hscale_8_to_15__fs_8_dstW_24_avx2 (sw_scale.c:235)
hscale_8_to_15__fs_12_dstW_8_avx2 (sw_scale.c:235)
hscale_8_to_15__fs_12_dstW_24_avx2 (sw_scale.c:235)
hscale_8_to_15__fs_16_dstW_8_avx2 (sw_scale.c:235)
hscale_8_to_15__fs_16_dstW_24_avx2 (sw_scale.c:235)
hscale_8_to_15__fs_32_dstW_8_avx2 (sw_scale.c:235)
hscale_8_to_15__fs_32_dstW_24_avx2 (sw_scale.c:235)
hscale_8_to_15__fs_40_dstW_8_avx2 (sw_scale.c:235)
hscale_8_to_15__fs_40_dstW_24_avx2 (sw_scale.c:235)
- sw_scale.hscale [FAILED]
- sw_scale.yuv2yuvX [OK]
checkasm: 12 of 504 tests have failed
tests/Makefile:304: recipe for target 'fate-checkasm-sw_scale' failed
make: *** [fate-checkasm-sw_scale] Error 1
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
While the State exists there can be no freedom; when there is freedom there
will be no State. -- Vladimir Lenin
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-07-14 16:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-17 10:04 Alan Kelly
2022-04-22 8:04 ` Alan Kelly
2022-07-13 8:05 ` Alan Kelly
2022-07-14 16:56 ` Michael Niedermayer [this message]
2022-07-15 14:59 ` Alan Kelly
2022-07-15 15:03 ` Alan Kelly
2022-07-16 11:14 ` Michael Niedermayer
2022-07-18 7:54 ` Alan Kelly
2022-07-18 16:49 ` Michael Niedermayer
2022-08-15 8:36 ` Alan Kelly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220714165612.GC2088045@pb2 \
--to=michael@niedermayer.cc \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git