* [FFmpeg-devel] [PATCH] libavcodec/qsvenc: Fix a log format issue
@ 2022-07-07 5:57 Wenbin Chen
2022-07-07 7:37 ` "zhilizhao(赵志立)"
0 siblings, 1 reply; 3+ messages in thread
From: Wenbin Chen @ 2022-07-07 5:57 UTC (permalink / raw)
To: ffmpeg-devel
Add a line feed to fix a log format issue.
Signed-off-by: Wenbin Chen <wenbin.chen@intel.com>
---
libavcodec/qsvenc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c
index 2382c2f5f7..81d93235d7 100644
--- a/libavcodec/qsvenc.c
+++ b/libavcodec/qsvenc.c
@@ -308,6 +308,7 @@ static void dump_video_param(AVCodecContext *avctx, QSVEncContext *q,
case MFX_B_REF_PYRAMID: av_log(avctx, AV_LOG_VERBOSE, "pyramid"); break;
default: av_log(avctx, AV_LOG_VERBOSE, "auto"); break;
}
+ av_log(avctx, AV_LOG_VERBOSE, "\n");
av_log(avctx, AV_LOG_VERBOSE,
"MinQPI: %"PRIu8"; MaxQPI: %"PRIu8"; MinQPP: %"PRIu8"; MaxQPP: %"PRIu8"; MinQPB: %"PRIu8"; MaxQPB: %"PRIu8"\n",
--
2.32.0
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] [PATCH] libavcodec/qsvenc: Fix a log format issue
2022-07-07 5:57 [FFmpeg-devel] [PATCH] libavcodec/qsvenc: Fix a log format issue Wenbin Chen
@ 2022-07-07 7:37 ` "zhilizhao(赵志立)"
2022-07-07 8:47 ` Chen, Wenbin
0 siblings, 1 reply; 3+ messages in thread
From: "zhilizhao(赵志立)" @ 2022-07-07 7:37 UTC (permalink / raw)
To: FFmpeg development discussions and patches
> On Jul 7, 2022, at 1:57 PM, Wenbin Chen <wenbin.chen-at-intel.com@ffmpeg.org> wrote:
>
> Add a line feed to fix a log format issue.
>
> Signed-off-by: Wenbin Chen <wenbin.chen@intel.com>
> ---
> libavcodec/qsvenc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c
> index 2382c2f5f7..81d93235d7 100644
> --- a/libavcodec/qsvenc.c
> +++ b/libavcodec/qsvenc.c
> @@ -308,6 +308,7 @@ static void dump_video_param(AVCodecContext *avctx, QSVEncContext *q,
> case MFX_B_REF_PYRAMID: av_log(avctx, AV_LOG_VERBOSE, "pyramid"); break;
> default: av_log(avctx, AV_LOG_VERBOSE, "auto"); break;
> }
> + av_log(avctx, AV_LOG_VERBOSE, "\n");
It’s not thread safe. There are multiple such cases, better be fixed together.
>
> av_log(avctx, AV_LOG_VERBOSE,
> "MinQPI: %"PRIu8"; MaxQPI: %"PRIu8"; MinQPP: %"PRIu8"; MaxQPP: %"PRIu8"; MinQPB: %"PRIu8"; MaxQPB: %"PRIu8"\n",
> --
> 2.32.0
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] [PATCH] libavcodec/qsvenc: Fix a log format issue
2022-07-07 7:37 ` "zhilizhao(赵志立)"
@ 2022-07-07 8:47 ` Chen, Wenbin
0 siblings, 0 replies; 3+ messages in thread
From: Chen, Wenbin @ 2022-07-07 8:47 UTC (permalink / raw)
To: FFmpeg development discussions and patches
> > On Jul 7, 2022, at 1:57 PM, Wenbin Chen <wenbin.chen-at-
> intel.com@ffmpeg.org> wrote:
> >
> > Add a line feed to fix a log format issue.
> >
> > Signed-off-by: Wenbin Chen <wenbin.chen@intel.com>
> > ---
> > libavcodec/qsvenc.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c
> > index 2382c2f5f7..81d93235d7 100644
> > --- a/libavcodec/qsvenc.c
> > +++ b/libavcodec/qsvenc.c
> > @@ -308,6 +308,7 @@ static void dump_video_param(AVCodecContext
> *avctx, QSVEncContext *q,
> > case MFX_B_REF_PYRAMID: av_log(avctx, AV_LOG_VERBOSE,
> "pyramid"); break;
> > default: av_log(avctx, AV_LOG_VERBOSE, "auto"); break;
> > }
> > + av_log(avctx, AV_LOG_VERBOSE, "\n");
>
> It’s not thread safe. There are multiple such cases, better be fixed together.
Ok, I will fix them together.
Thanks
>
> >
> > av_log(avctx, AV_LOG_VERBOSE,
> > "MinQPI: %"PRIu8"; MaxQPI: %"PRIu8"; MinQPP: %"PRIu8";
> MaxQPP: %"PRIu8"; MinQPB: %"PRIu8"; MaxQPB: %"PRIu8"\n",
> > --
> > 2.32.0
> >
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel@ffmpeg.org
> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
> > To unsubscribe, visit link above, or email
> > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-07 8:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-07 5:57 [FFmpeg-devel] [PATCH] libavcodec/qsvenc: Fix a log format issue Wenbin Chen
2022-07-07 7:37 ` "zhilizhao(赵志立)"
2022-07-07 8:47 ` Chen, Wenbin
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git