From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8D09A43A22 for ; Tue, 5 Jul 2022 22:36:37 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4034868BA16; Wed, 6 Jul 2022 01:36:34 +0300 (EEST) Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 69ED168B85B for ; Wed, 6 Jul 2022 01:36:27 +0300 (EEST) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 7E88AC0003 for ; Tue, 5 Jul 2022 22:36:26 +0000 (UTC) Date: Wed, 6 Jul 2022 00:36:25 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20220705223625.GN396728@pb2> References: <20220628121400.20444-1-michael@niedermayer.cc> <20220628121400.20444-2-michael@niedermayer.cc> <165657934670.10358.3564375213466122817@lain.khirnov.net> <20220701195300.GV396728@pb2> <165675110681.31466.8599184593020973018@lain.khirnov.net> <20220702125650.GC396728@pb2> <165704030809.31466.17645589382042923396@lain.khirnov.net> MIME-Version: 1.0 In-Reply-To: <165704030809.31466.17645589382042923396@lain.khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH 2/2] fftools/ffmpeg_filter: Fix audio_drift_threshold check X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============2304097304133257932==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============2304097304133257932== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="LbwruFyjFQ4msdRH" Content-Disposition: inline --LbwruFyjFQ4msdRH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 05, 2022 at 06:58:28PM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2022-07-02 14:56:50) > > On Sat, Jul 02, 2022 at 10:38:26AM +0200, Anton Khirnov wrote: > > > Quoting Michael Niedermayer (2022-07-01 21:53:00) > > > > On Thu, Jun 30, 2022 at 10:55:46AM +0200, Anton Khirnov wrote: > > > > > Variant 2 is less bad, but the whole check seems hacky to me, sin= ce it > > > > > seems to make assumptions about swr defaults > > > > >=20 > > > > > Won't setting this unconditionally have the same effect? > > > >=20 > > > > it has the same effect but its not so nice to the user to recommand= extra > > > > arguments which make no difference > > >=20 > > > Sorry, I don't follow. What is recommending any arguments to the user > > > here? > >=20 > > i meant this thing here: > > ./ffmpeg -i matrixbench_mpeg2.mpg -async 1 -f null - 2>&1 | grep asy= nc > >=20 > > -async is forwarded to lavfi similarly to -af aresample=3Dasync=3D1:min= _hard_comp=3D0.100000:first_pts=3D0. > >=20 > > vs. > >=20 > > -async is forwarded to lavfi similarly to -af aresample=3Dasync=3D1:fir= st_pts=3D0. >=20 > I don't see a problem - why would the user care how it is forwarded? The user may want to perform the equivalent operation inside a filter chain= /graph or with a tool different from ffmpeg or even via the API its really a very minor thing if these defaults are displayed too, it just feels a bit cleaner to skip them thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB If you drop bombs on a foreign country and kill a hundred thousand innocent people, expect your government to call the consequence "unprovoked inhuman terrorist attacks" and use it to justify dropping more bombs and killing more people. The technology changed, the idea is old. --LbwruFyjFQ4msdRH Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCYsS85QAKCRBhHseHBAsP q4u+AJ9IkpgwCXRVJFcyWQ4BLziygBktVwCgk3EsbiHSaIcn/L2lsjg0g/lkmtY= =QEaR -----END PGP SIGNATURE----- --LbwruFyjFQ4msdRH-- --===============2304097304133257932== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============2304097304133257932==--