From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id DC7C343A04 for ; Tue, 5 Jul 2022 17:05:23 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4B11268BA03; Tue, 5 Jul 2022 20:05:21 +0300 (EEST) Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0A9CA68B9CA for ; Tue, 5 Jul 2022 20:05:14 +0300 (EEST) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id A3C871BF207 for ; Tue, 5 Jul 2022 17:05:13 +0000 (UTC) Date: Tue, 5 Jul 2022 19:05:12 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20220705170512.GL396728@pb2> References: <20220705001101.111869-1-ffmpeg@haasn.xyz> MIME-Version: 1.0 In-Reply-To: <20220705001101.111869-1-ffmpeg@haasn.xyz> Subject: Re: [FFmpeg-devel] [PATCH] lavu: always provide symbols from hwcontext_vulkan.h X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============8100014348552391112==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============8100014348552391112== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="OO26Ec7kKr0HQ07l" Content-Disposition: inline --OO26Ec7kKr0HQ07l Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 05, 2022 at 02:11:01AM +0200, Niklas Haas wrote: > From: Niklas Haas >=20 > This header is unconditionally installed, even though the utility > functions defined by it may be missing from the built library. >=20 > A precedent set by e.g. libavcodec/qsv.h (and others) is to always > provide these functions by compiling stub functions in the absence of > CONFIG_*. Make hwcontext_vulkan.h match this convention. >=20 > Fixes downstream issues, e.g. > https://github.com/haasn/libplacebo/issues/120 >=20 > Signed-off-by: Niklas Haas > --- > libavutil/Makefile | 2 +- > libavutil/hwcontext_vulkan.c | 26 ++++++++++++++++++++++++-- > 2 files changed, 25 insertions(+), 3 deletions(-) breaks build with shared libs LD libavutil/libavutil.so.57 libavutil/hwcontext_vulkan.o: In function `av_vk_frame_alloc': ffmpeg/linux64shared/src/libavutil/hwcontext_vulkan.c:4177: multiple defini= tion of `av_vk_frame_alloc' libavutil/hwcontext_stub.o:ffmpeg/linux64shared/src/libavutil/hwcontext_stu= b.c:37: first defined here libavutil/hwcontext_vulkan.o: In function `av_vkfmt_from_pixfmt': ffmpeg/linux64shared/src/libavutil/hwcontext_vulkan.c:4182: multiple defini= tion of `av_vkfmt_from_pixfmt' libavutil/hwcontext_stub.o:ffmpeg/linux64shared/src/libavutil/hwcontext_stu= b.c:32: first defined here clang: error: linker command failed with exit code 1 (use -v to see invocat= ion) ffmpeg/ffbuild/library.mak:118: recipe for target 'libavutil/libavutil.so.5= 7' failed make: *** [libavutil/libavutil.so.57] Error 1 [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Breaking DRM is a little like attempting to break through a door even though the window is wide open and the only thing in the house is a bunch of things you dont want and which you would get tomorrow for free anyway --OO26Ec7kKr0HQ07l Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCYsRvRQAKCRBhHseHBAsP q7NAAJ9bpDX2fGosK0RwPbZ1pGfFzpzn1QCZAQ7vqsS7jWMBHGA/hgE5C6i3DrA= =ufWO -----END PGP SIGNATURE----- --OO26Ec7kKr0HQ07l-- --===============8100014348552391112== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============8100014348552391112==--