Re: [FFmpeg-devel] [PATCH] lavu: always provide symbols from hwcontext_vulkan.h

From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] lavu: always provide symbols from hwcontext_vulkan.h
Date: Tue, 5 Jul 2022 19:05:12 +0200
Message-ID: <20220705170512.GL396728@pb2> (raw)
In-Reply-To: <20220705001101.111869-1-ffmpeg@haasn.xyz>

[-- Attachment #1.1: Type: text/plain, Size: 1887 bytes --]

On Tue, Jul 05, 2022 at 02:11:01AM +0200, Niklas Haas wrote:
> From: Niklas Haas <git@haasn.dev>
> 
> This header is unconditionally installed, even though the utility
> functions defined by it may be missing from the built library.
> 
> A precedent set by e.g. libavcodec/qsv.h (and others) is to always
> provide these functions by compiling stub functions in the absence of
> CONFIG_*. Make hwcontext_vulkan.h match this convention.
> 
> Fixes downstream issues, e.g.
> https://github.com/haasn/libplacebo/issues/120
> 
> Signed-off-by: Niklas Haas <git@haasn.dev>
> ---
>  libavutil/Makefile           |  2 +-
>  libavutil/hwcontext_vulkan.c | 26 ++++++++++++++++++++++++--
>  2 files changed, 25 insertions(+), 3 deletions(-)

breaks build with shared libs

LD	libavutil/libavutil.so.57
libavutil/hwcontext_vulkan.o: In function `av_vk_frame_alloc':
ffmpeg/linux64shared/src/libavutil/hwcontext_vulkan.c:4177: multiple definition of `av_vk_frame_alloc'
libavutil/hwcontext_stub.o:ffmpeg/linux64shared/src/libavutil/hwcontext_stub.c:37: first defined here
libavutil/hwcontext_vulkan.o: In function `av_vkfmt_from_pixfmt':
ffmpeg/linux64shared/src/libavutil/hwcontext_vulkan.c:4182: multiple definition of `av_vkfmt_from_pixfmt'
libavutil/hwcontext_stub.o:ffmpeg/linux64shared/src/libavutil/hwcontext_stub.c:32: first defined here
clang: error: linker command failed with exit code 1 (use -v to see invocation)
ffmpeg/ffbuild/library.mak:118: recipe for target 'libavutil/libavutil.so.57' failed
make: *** [libavutil/libavutil.so.57] Error 1

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Breaking DRM is a little like attempting to break through a door even
though the window is wide open and the only thing in the house is a bunch
of things you dont want and which you would get tomorrow for free anyway

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".