Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: TADANO Tokumei <aimingoff@pc.nifty.jp>
To: ffmpeg-devel@ffmpeg.org
Cc: TADANO Tokumei <aimingoff@pc.nifty.jp>
Subject: [FFmpeg-devel] [PATCH v5 3/4] lavf/mpegts.c: set some properties for ARIB caption
Date: Sun,  3 Jul 2022 19:26:26 +0900
Message-ID: <20220703102627.398185-4-aimingoff@pc.nifty.jp> (raw)
In-Reply-To: <20220703102627.398185-1-aimingoff@pc.nifty.jp>

Some additional properties are set for ARIB caption.
* need_parsing = 0
  ARIB caption doesn't require any parser.
  This avoids "parser not found" warning message.
* need_context_update = 1
  When any profiles are changed, set this flag to notify.
* codecpar->width / codecpar->height
  Find best video stream and set frame size for ARIB_PROFILE_A
  type of ARIB caption.

Signed-off-by: TADANO Tokumei <aimingoff@pc.nifty.jp>
---
 libavformat/mpegts.c | 19 ++++++++++++++++++-
 1 file changed, 18 insertions(+), 1 deletion(-)

diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c
index 8a3436f2be..45b866c5f4 100644
--- a/libavformat/mpegts.c
+++ b/libavformat/mpegts.c
@@ -2145,6 +2145,7 @@ int ff_parse_mpeg2_descriptor(AVFormatContext *fc, AVStream *st, int stream_type
             // Vol. 3, Section 2, 4.2.8.1
             int actual_component_tag = sti->stream_identifier - 1;
             int picked_profile = FF_PROFILE_UNKNOWN;
+            AVStream *v_st = NULL;
             int data_component_id = get16(pp, desc_end);
             if (data_component_id < 0)
                 return AVERROR_INVALIDDATA;
@@ -2155,7 +2156,12 @@ int ff_parse_mpeg2_descriptor(AVFormatContext *fc, AVStream *st, int stream_type
                 // non-mobile captioning service ("profile A").
                 if (actual_component_tag >= 0x30 &&
                     actual_component_tag <= 0x37) {
+                    int v_index;
                     picked_profile = FF_PROFILE_ARIB_PROFILE_A;
+                    v_index = av_find_best_stream(fc, AVMEDIA_TYPE_VIDEO,
+                                                  -1, 1, NULL, 0);
+                    if (v_index >= 0)
+                        v_st = fc->streams[v_index];
                 }
                 break;
             case 0x0012:
@@ -2174,8 +2180,19 @@ int ff_parse_mpeg2_descriptor(AVFormatContext *fc, AVStream *st, int stream_type
 
             st->codecpar->codec_type = AVMEDIA_TYPE_SUBTITLE;
             st->codecpar->codec_id   = AV_CODEC_ID_ARIB_CAPTION;
-            st->codecpar->profile    = picked_profile;
+            if (st->codecpar->profile != picked_profile) {
+                st->codecpar->profile = picked_profile;
+                sti->need_context_update = 1;
+            }
+            if (v_st &&
+                (st->codecpar->width != v_st->codecpar->width ||
+                 st->codecpar->height != v_st->codecpar->height)) {
+                st->codecpar->width = v_st->codecpar->width;
+                st->codecpar->height = v_st->codecpar->height;
+                sti->need_context_update = 1;
+            }
             sti->request_probe = 0;
+            sti->need_parsing = 0;
         }
         break;
     case 0xb0: /* DOVI video stream descriptor */
-- 
2.30.2

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  parent reply	other threads:[~2022-07-03 10:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-03 10:26 [FFmpeg-devel] [PATCH v5 0/4] add ARIB caption decoder using libaribcaption TADANO Tokumei
2022-07-03 10:26 ` [FFmpeg-devel] [PATCH v5 1/4] lavc/libaribcaption.c: " TADANO Tokumei
2022-07-03 10:26 ` [FFmpeg-devel] [PATCH v5 2/4] lavc/codec_desc.c: remove AV_CODEC_PROP_TEXT_SUB property TADANO Tokumei
2022-07-03 10:26 ` TADANO Tokumei [this message]
2022-07-03 10:26 ` [FFmpeg-devel] [PATCH v5 4/4] doc/decoders.texi: add document of aribcaption decoder TADANO Tokumei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220703102627.398185-4-aimingoff@pc.nifty.jp \
    --to=aimingoff@pc.nifty.jp \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git