Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: "Jan Ekström" <jeebjp@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: [FFmpeg-devel] [PATCH v5 7/7] avformat/movenc: limit ISOBMFF AC-3 mapping to bsids <=8
Date: Thu, 30 Jun 2022 09:42:38 +0300
Message-ID: <20220630064238.45315-8-jeebjp@gmail.com> (raw)
In-Reply-To: <20220630064238.45315-1-jeebjp@gmail.com>

From: Jan Ekström <jan.ekstrom@24i.com>

This leaves out RealAudio DolbyNet, which utilizes bsids 9 and 10,

It is not clear whether the interpreted bit rate value (divided by
2 or 4 depending on the variant), or the original bit rate value
should be utilized to receive the bit_rate_code index.

Signed-off-by: Jan Ekström <jan.ekstrom@24i.com>
---
 libavformat/movenc.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/libavformat/movenc.c b/libavformat/movenc.c
index 022fab675e..3c605f6474 100644
--- a/libavformat/movenc.c
+++ b/libavformat/movenc.c
@@ -374,6 +374,14 @@ static int mov_write_ac3_tag(AVFormatContext *s, AVIOContext *pb, MOVTrack *trac
         return AVERROR(EINVAL);
     }
 
+    if (info->substream[0].bsid > 8) {
+        av_log(s, AV_LOG_ERROR,
+               "RealAudio AC-3/DolbyNet with bsid %d is not defined by the "
+               "ISOBMFF specification in ETSI TS 102 366!\n",
+               info->substream[0].bsid);
+        return AVERROR(EINVAL);
+    }
+
     if (info->ac3_bit_rate_code < 0) {
         av_log(s, AV_LOG_ERROR,
                "No valid AC3 bit rate code for data rate of %d!\n",
-- 
2.36.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  parent reply	other threads:[~2022-06-30  6:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-30  6:42 [FFmpeg-devel] [PATCH v5 0/7] avformat/movenc: normalize on AC-3 parser usage Jan Ekström
2022-06-30  6:42 ` [FFmpeg-devel] [PATCH v5 1/7] avcodec/ac3_parser{, _internal}: expose AC-3 bit_rate_code Jan Ekström
2022-06-30  6:42 ` [FFmpeg-devel] [PATCH v5 2/7] {configure, avformat/movenc}: enable AC-3 parser for movenc Jan Ekström
2022-06-30  6:42 ` [FFmpeg-devel] [PATCH v5 3/7] avformat/movenc: enable handle_eac3 to handle AC-3 tracks Jan Ekström
2022-06-30  6:42 ` [FFmpeg-devel] [PATCH v5 4/7] avformat/movenc: move eac3_info definition so that it can be used for AC-3 Jan Ekström
2022-06-30  6:42 ` [FFmpeg-devel] [PATCH v5 5/7] avformat/movenc: utilize existing AC-3 parsing workflow " Jan Ekström
2022-06-30  6:42 ` [FFmpeg-devel] [PATCH v5 6/7] avformat/movenc: handle OOM situations when parsing AC-3 headers Jan Ekström
2022-06-30  6:42 ` Jan Ekström [this message]
2022-06-30 13:18 ` [FFmpeg-devel] [PATCH v5 0/7] avformat/movenc: normalize on AC-3 parser usage Jan Ekström

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220630064238.45315-8-jeebjp@gmail.com \
    --to=jeebjp@gmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git