From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 25CA5437E6 for ; Tue, 28 Jun 2022 19:57:30 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 70CDF68B997; Tue, 28 Jun 2022 22:57:28 +0300 (EEST) Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1FA0F68B8A3 for ; Tue, 28 Jun 2022 22:57:22 +0300 (EEST) Received: from localhost (213-47-68-29.cable.dynamic.surfer.at [213.47.68.29]) (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 32E821BF208 for ; Tue, 28 Jun 2022 19:57:20 +0000 (UTC) Date: Tue, 28 Jun 2022 21:57:20 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20220628195720.GU396728@pb2> References: <20220628134110.87770-1-ffmpeg@haasn.xyz> <20220628134110.87770-5-ffmpeg@haasn.xyz> MIME-Version: 1.0 In-Reply-To: <20220628134110.87770-5-ffmpeg@haasn.xyz> Subject: Re: [FFmpeg-devel] [PATCH 4/6] avcodec: add common fflcms2 boilerplate X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============0741963810715168550==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============0741963810715168550== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="db8DWWv/lfL7k8Nd" Content-Disposition: inline --db8DWWv/lfL7k8Nd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 28, 2022 at 03:41:09PM +0200, Niklas Haas wrote: > From: Niklas Haas >=20 > Handling this in general code makes more sense than handling it in > individual codec files, because it would be a lot of unnecessary code > duplication for the plenty of formats that support exporting ICC > profiles (jpg, png, tiff, webp, jxl, ...). >=20 > encode.c and decode.c will be in charge of initializing this state as > needed, so we merely need to make sure to uninit it afterwards from the > common destructor path. >=20 > Signed-off-by: Niklas Haas > --- > configure | 2 +- > libavcodec/Makefile | 1 + > libavcodec/avcodec.c | 4 ++++ > libavcodec/decode.c | 4 ++++ > libavcodec/internal.h | 8 ++++++++ > 5 files changed, 18 insertions(+), 1 deletion(-) doesnt build here: (ubuntu x86) CC libavformat/4xm.o In file included from ./libavcodec/internal.h:37:0, from libavformat/4xm.c:32: =2E/libavcodec/fflcms2.h:32:10: fatal error: lcms2.h: No such file or direc= tory #include ^~~~~~~~~ compilation terminated. ffbuild/common.mak:81: recipe for target 'libavformat/4xm.o' failed make: *** [libavformat/4xm.o] Error 1 thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I have never wished to cater to the crowd; for what I know they do not approve, and what they approve I do not know. -- Epicurus --db8DWWv/lfL7k8Nd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCYrtdHAAKCRBhHseHBAsP q13sAKCEIqNwqy4H9WH/SGnq2H8Qjnoy1wCeM1xdEKRZA7ADzzYRlulUETbF2Rk= =PYmi -----END PGP SIGNATURE----- --db8DWWv/lfL7k8Nd-- --===============0741963810715168550== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============0741963810715168550==--