Re: [FFmpeg-devel] [PATCH 4/6] avcodec: add common fflcms2 boilerplate

[Michael Niedermayer <michael@niedermayer.cc>]

[-- Attachment #1.1: Type: text/plain, Size: 1459 bytes --]

On Tue, Jun 28, 2022 at 03:41:09PM +0200, Niklas Haas wrote:
> From: Niklas Haas <git@haasn.dev>
> 
> Handling this in general code makes more sense than handling it in
> individual codec files, because it would be a lot of unnecessary code
> duplication for the plenty of formats that support exporting ICC
> profiles (jpg, png, tiff, webp, jxl, ...).
> 
> encode.c and decode.c will be in charge of initializing this state as
> needed, so we merely need to make sure to uninit it afterwards from the
> common destructor path.
> 
> Signed-off-by: Niklas Haas <git@haasn.dev>
> ---
>  configure             | 2 +-
>  libavcodec/Makefile   | 1 +
>  libavcodec/avcodec.c  | 4 ++++
>  libavcodec/decode.c   | 4 ++++
>  libavcodec/internal.h | 8 ++++++++
>  5 files changed, 18 insertions(+), 1 deletion(-)

doesnt build here: (ubuntu x86)
CC	libavformat/4xm.o
In file included from ./libavcodec/internal.h:37:0,
                 from libavformat/4xm.c:32:
./libavcodec/fflcms2.h:32:10: fatal error: lcms2.h: No such file or directory
 #include <lcms2.h>
          ^~~~~~~~~
compilation terminated.
ffbuild/common.mak:81: recipe for target 'libavformat/4xm.o' failed
make: *** [libavformat/4xm.o] Error 1

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have never wished to cater to the crowd; for what I know they do not
approve, and what they approve I do not know. -- Epicurus

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".