From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id 084B5437B0
	for <ffmpegdev@gitmailbox.com>; Tue, 28 Jun 2022 13:42:16 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BC69668B957;
	Tue, 28 Jun 2022 16:42:13 +0300 (EEST)
Received: from haasn.dev (haasn.dev [78.46.187.166])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 84BBB68B876
 for <ffmpeg-devel@ffmpeg.org>; Tue, 28 Jun 2022 16:42:07 +0300 (EEST)
Received: from haasn.dev (unknown [10.30.0.2])
 by haasn.dev (Postfix) with ESMTP id AB67A4245E
 for <ffmpeg-devel@ffmpeg.org>; Tue, 28 Jun 2022 15:42:06 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=haasn.xyz; s=mail;
 t=1656423726; bh=OiZJTy9EfWkbr7/p1+7mdOkbyHlbOgxZGUy5Uqk31HA=;
 h=From:To:Subject:Date:From;
 b=F5SmqRP0knrhsZ7Ht9rVZfj0DONoigKD5RfXTC3Qkja/uGCCWqQqJ5qQRlvP0iLwX
 s50lJ5KK7lpsFgmaLdWd4skivNMjQGaMFXoDQMbma3W0k3VAWW1r00j4ME8RqEFh5e
 ZlfO96ImVoK1Ywa4QfWkRfSXH19bo8PJsQZ4ROMg=
From: Niklas Haas <ffmpeg@haasn.xyz>
To: ffmpeg-devel@ffmpeg.org
Date: Tue, 28 Jun 2022 15:41:05 +0200
Message-Id: <20220628134110.87770-1-ffmpeg@haasn.xyz>
X-Mailer: git-send-email 2.36.1
MIME-Version: 1.0
Subject: [FFmpeg-devel] ICC profile support in avcodec
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/20220628134110.87770-1-ffmpeg@haasn.xyz/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

Hi,

I'm not entirely sure I'm happy with this series. I would appreciate any
sort of comment.

The motivating use case is given in #9672 and #9673 - basically, it's
somewhat expected that ffmpeg should, out of the box, handle files with
embedded ICC profiles, mapping between them and its internal color enums
as possible/needed.

The ICC profile *decoding* code works well as-is as far as I'm
concerned, but I might end up deciding to scrap the ICC *encoding* code
in avcodec/encode.c in favor of letting encoders handle that themselves,
simply because it allows mjpegenc/apng do the correct thing (as opposed
to the status quo of an ICC profile being attached to every single
frame, which might not be the smartest choice).

I'm also not entirely happy with the way fflcms2 is being shared between
libavcodec and libavfilter, but we have a precedent here (vulkan.c) and
it's probably still better than locking this API into ABI hell for all
eternity. I can see myself wanting to make more changes to it, in the
future.


_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".