From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id AB198436FE for ; Sat, 25 Jun 2022 11:35:03 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5896968B8C7; Sat, 25 Jun 2022 14:35:01 +0300 (EEST) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B8F9D68B658 for ; Sat, 25 Jun 2022 14:34:54 +0300 (EEST) Received: from localhost (213-47-68-29.cable.dynamic.surfer.at [213.47.68.29]) (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id A924E240003 for ; Sat, 25 Jun 2022 11:34:53 +0000 (UTC) Date: Sat, 25 Jun 2022 13:34:52 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20220625113452.GR396728@pb2> References: <2645a1a8426d406de339813d97a69aed1d205967.1656151077.git.ffmpegagent@gmail.com> MIME-Version: 1.0 In-Reply-To: <2645a1a8426d406de339813d97a69aed1d205967.1656151077.git.ffmpegagent@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH v5 24/25] fftools/ffmpeg: Introduce subtitle filtering and new frame-based subtitle encoding X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============1778662916043278092==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============1778662916043278092== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="MzBafMtx5eI/BDwD" Content-Disposition: inline --MzBafMtx5eI/BDwD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jun 25, 2022 at 09:57:56AM +0000, softworkz wrote: > From: softworkz >=20 > This commit actually enables subtitle filtering in ffmpeg by > sending and receiving subtitle frames to and from a filtergraph. >=20 > The heartbeat functionality from the previous sub2video implementation > is removed and now provided by the 'subfeed' filter. > The other part of sub2video functionality is retained by > auto-insertion of the new graphicsub2video filter. >=20 > Justification for changed test refs: >=20 > - sub2video > The previous results were incorrect. The command line for this test > specifies -r 5 (5 frames per second), which is now fulfilled by the > additional frames in the reference output. > Example: The first subtitle time is 499000, the second is 15355000, > which means 0.5s and 15.35s with a difference of 14.85s. > 15s * 5fps =3D 75 frames and that's now the exact number of video > frames between these two subtitle events. >=20 > - sub2video_basic > The previous results had some incorrect output because multiple > frames had the same dts > The non-empty content frames are visually identical, the different > CRC is due to the different blending algorithm that is being used. >=20 > - sub2video_time_limited > Subtitle frames are emitted to the filter graphs at a 5 fps rate > by default. The time limit for this test is 15s * 5fps =3D 75 frames > which matches the count in the new ref. >=20 > - sub-dvb > Running ffprobe -show_frames on the source file shows that there > are 7 subtitle frames with 0 rects in the source at the start > and 2 at the end. This translates to the 14 and 4 additional > entries in the new test results. >=20 > - filter-overlay-dvdsub-2397 > Overlay results have slightly different CRCs due to different > blending implementation >=20 > - sub-scc > The first entry is no longer in the output because it is before > the actual start time and the strim filter removes such entries > now (like for video and audio) >=20 > Signed-off-by: softworkz > --- > fftools/ffmpeg.c | 613 +++++----- > fftools/ffmpeg.h | 17 +- > fftools/ffmpeg_filter.c | 270 +++-- > fftools/ffmpeg_hw.c | 2 +- > fftools/ffmpeg_opt.c | 28 +- > tests/ref/fate/filter-overlay-dvdsub-2397 | 182 +-- > tests/ref/fate/sub-dvb | 162 +-- > tests/ref/fate/sub-scc | 1 - > tests/ref/fate/sub2video | 1091 +++++++++++++++++- > tests/ref/fate/sub2video_basic | 1238 +++++++++++++++++++-- > tests/ref/fate/sub2video_time_limited | 78 +- > 11 files changed, 3010 insertions(+), 672 deletions(-) seems to break fate Input #0, ass, from 'fate-suite//sub/1ededcbd7b.ass': Duration: N/A, bitrate: N/A Stream #0:0: Subtitle: ass Codec AVOption threads (set the number of threads) specified for input file= #0 (fate-suite//sub/1ededcbd7b.ass) has not been used for any stream. The = most likely reason is either wrong type (e.g. a video option with no video = streams) or that it is a private option of some decoder which was not actua= lly used for any stream. Codec AVOption thread_type (select multithreading type) specified for input= file #0 (fate-suite//sub/1ededcbd7b.ass) has not been used for any stream.= The most likely reason is either wrong type (e.g. a video option with no v= ideo streams) or that it is a private option of some decoder which was not = actually used for any stream. Stream mapping: Stream #0:0 -> #0:0 (ass (ssa) -> ass (ssa)) cur_dts is invalid st:0 (0) [init:0 i_done:0 finish:0] (this is harmless if= it occurs once at the start per stream) subtitle input filter: decoding size 1280x720 [out_0_0 @ 0x557cab64bbc0] Subtitle format change from 1 to 3 Assertion c > 0 failed at libavutil/mathematics.c:61 Aborted (core dumped) tests/Makefile:304: recipe for target 'fate-sub-ass-to-ass-transcode' failed make: *** [fate-sub-ass-to-ass-transcode] Error 134 thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The day soldiers stop bringing you their problems is the day you have stopp= ed=20 leading them. They have either lost confidence that you can help or conclud= ed=20 you do not care. Either case is a failure of leadership. - Colin Powell --MzBafMtx5eI/BDwD Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCYrby2AAKCRBhHseHBAsP q6rrAJ0dJIVQLNRBoyk98NzBrBRrYloZLwCeMxx6g15KJnd3Fm7ZHvhYTExSLpw= =z3iu -----END PGP SIGNATURE----- --MzBafMtx5eI/BDwD-- --===============1778662916043278092== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============1778662916043278092==--