From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3A8F1436E3 for ; Fri, 24 Jun 2022 06:01:30 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 73A7668B701; Fri, 24 Jun 2022 09:01:27 +0300 (EEST) Received: from smtpbg.qq.com (smtpbg123.qq.com [175.27.65.52]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7794668B335 for ; Fri, 24 Jun 2022 09:01:20 +0300 (EEST) X-QQ-mid: bizesmtp70t1656050403tm4iimfz Received: from localhost ( [103.107.217.226]) by bizesmtp.qq.com (ESMTP) with id ; Fri, 24 Jun 2022 14:00:01 +0800 (CST) X-QQ-SSF: 01100000002000Z0Z000000A0000000 X-QQ-FEAT: 73SlNYRUNlJnEryBeZtJbvTb7WL1wNFSm74Jg72H1aXVkwMXmn6Yb9bfSXyX4 la1ljDAq7j5ZKuPR4uhU+yO0xLRS4sJHOSkkR4id1yA2pcKddVliG9YCUaxsCt2aA3NoXBi o0dXCfF3l03TYVoXrel4hjJKdnvk+77XlTjY1iCAH5HBRA8R+14wVIqnsfN3t75j/Nevw0z WIA7w45bb9JN8lEw13M0w9SkNxeiaiauoL9eEcPWUKnxP1RfbXbgVyqj2RB0lSPScNeJbEt ZiM/VD4V1tLR6f1Nt5nl+EhNYv9MWaIbwCjIYI17nyY7sIHs+8JMeh+2VZ25xvh0E6TtTQS eTD4cXz X-QQ-GoodBg: 0 From: Steven Liu To: ffmpeg-devel@ffmpeg.org Date: Fri, 24 Jun 2022 13:59:57 +0800 Message-Id: <20220624055957.48149-1-lq@chinaffmpeg.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: References: MIME-Version: 1.0 X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:chinaffmpeg.org:qybgspam:qybgspam8 Subject: [FFmpeg-devel] [PATCH v2] avcodec/audiotoolboxenc: return external error if encode failed X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Steven Liu Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: because the AudioConverterFillComplexBuffer can return 0 or 1 if success. so set the ret to 0 it AudioConverterFillComplexBuffer success and return ret value for success or return AVERROR_EXTERNAL when AudioConverterFillComplexBuffer failed. BTW change the error message log level from warning to error. Signed-off-by: Steven Liu --- libavcodec/audiotoolboxenc.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavcodec/audiotoolboxenc.c b/libavcodec/audiotoolboxenc.c index f8305ab89b..00293154bf 100644 --- a/libavcodec/audiotoolboxenc.c +++ b/libavcodec/audiotoolboxenc.c @@ -554,11 +554,13 @@ static int ffat_encode(AVCodecContext *avctx, AVPacket *avpkt, avctx->frame_size, &avpkt->pts, &avpkt->duration); + ret = 0; } else if (ret && ret != 1) { - av_log(avctx, AV_LOG_WARNING, "Encode error: %i\n", ret); + av_log(avctx, AV_LOG_ERROR, "Encode error: %i\n", ret); + ret = AVERROR_EXTERNAL; } - return 0; + return ret; } static av_cold void ffat_encode_flush(AVCodecContext *avctx) -- 2.25.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".