From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C980F4043E for ; Thu, 23 Jun 2022 23:31:16 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 617B168B6A3; Fri, 24 Jun 2022 02:31:13 +0300 (EEST) Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BB46968B056 for ; Fri, 24 Jun 2022 02:31:07 +0300 (EEST) Received: from localhost (213-47-68-29.cable.dynamic.surfer.at [213.47.68.29]) (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id B3DFE1BF203 for ; Thu, 23 Jun 2022 23:31:06 +0000 (UTC) Date: Fri, 24 Jun 2022 01:31:05 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20220623233105.GN396728@pb2> References: MIME-Version: 1.0 In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] avformat/mpegts: correct timestamp overflow on multiple pcr loopback X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============2630434744443970030==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============2630434744443970030== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="BB5Gmd4dKzFH7LVg" Content-Disposition: inline --BB5Gmd4dKzFH7LVg Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 23, 2022 at 05:45:52PM +0200, S=E9bastien Rossi wrote: > - Detect and count PCR loopback > - Correct DTS and PTS with PCR loopback count to avoid timestamp overflow > and preserve timestamp continuity > libavformat/mpegts.c | 45 + > tests/ref/fate/ts-opus-demux | 1028 +++++++++++++++++++++---------------= ------- > 2 files changed, 556 insertions(+), 517 deletions(-) > 43462e655164b7eda6d3a5e8a85bc42556891742 0001-avformat-mpegts-correct-ti= mestamp-overflow-on-multip.patch > From 19305e9c1beffb34b73c71f721a6dea2b9fc483f Mon Sep 17 00:00:00 2001 > From: sebastien_rossi > Date: Thu, 23 Jun 2022 17:20:06 +0200 > Subject: [PATCH] avformat/mpegts: correct timestamp overflow on multiple = pcr > loopback not entirely sure what you are trying to do, did you look at the timestamp handling in the generic code? also this sort of timestamp modification can have issues with seeking=20 also this segfaults =3D=3D13685=3D=3D Invalid read of size 8 =3D=3D13685=3D=3D at 0x690357: new_pes_packet (in ffmpeg/ffmpeg_g) =3D=3D13685=3D=3D by 0x6937AB: mpegts_push_data (in ffmpeg/ffmpeg_g) =3D=3D13685=3D=3D by 0x690CE7: handle_packet (in ffmpeg/ffmpeg_g) =3D=3D13685=3D=3D by 0x6911A4: handle_packets (in ffmpeg/ffmpeg_g) =3D=3D13685=3D=3D by 0x6912E1: mpegts_read_packet (in ffmpeg/ffmpeg_g) =3D=3D13685=3D=3D by 0x5F42D4: ff_read_packet (in ffmpeg/ffmpeg_g) =3D=3D13685=3D=3D by 0x5F50C4: read_frame_internal (in ffmpeg/ffmpeg_g) =3D=3D13685=3D=3D by 0x5F6EA0: avformat_find_stream_info (in ffmpeg/ffmp= eg_g) =3D=3D13685=3D=3D by 0x2F1644: open_input_file (in ffmpeg/ffmpeg_g) =3D=3D13685=3D=3D by 0x2F7C5B: ffmpeg_parse_options (in ffmpeg/ffmpeg_g) =3D=3D13685=3D=3D by 0x2E60F4: main (in ffmpeg/ffmpeg_g) =3D=3D13685=3D=3D Address 0x10 is not stack'd, malloc'd or (recently) free= 'd [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Avoid a single point of failure, be that a person or equipment. --BB5Gmd4dKzFH7LVg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCYrT3tgAKCRBhHseHBAsP qzmWAJ9gB7xX1hq7pmZPgCRoX1PFqVAEKACfc2EWukLJN6UZbHQhkkfbKrNIEyo= =8v62 -----END PGP SIGNATURE----- --BB5Gmd4dKzFH7LVg-- --===============2630434744443970030== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============2630434744443970030==--