[FFmpeg-devel] [PATCH] avcodec/mfenc: set frame size for audio encoders.

[FFmpeg-devel] [PATCH] avcodec/mfenc: set frame size for audio encoders.

[Gyan Doshi]

Default avctx->frame_size is 0 which leads to init failure for
audio MediaFoundation encoders.
---
 libavcodec/mfenc.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/libavcodec/mfenc.c b/libavcodec/mfenc.c
index 13ed7b3e11..ff9ffe4827 100644
--- a/libavcodec/mfenc.c
+++ b/libavcodec/mfenc.c
@@ -1066,6 +1066,9 @@ static int mf_init_encoder(AVCodecContext *avctx)
 
     c->main_subtype = *subtype;
 
+    if (c->is_audio && !avctx->frame_size)
+        avctx->frame_size = 1024;
+
     if ((ret = mf_create(avctx, &c->functions, &c->mft, avctx->codec, use_hw)) < 0)
         return ret;
 
-- 
2.36.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec/mfenc: set frame size for audio encoders.

[Gyan Doshi]

On 2022-06-17 11:14 am, Gyan Doshi wrote:
> Default avctx->frame_size is 0 which leads to init failure for
> audio MediaFoundation encoders.

Plan to push tonight.

> ---
>   libavcodec/mfenc.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/libavcodec/mfenc.c b/libavcodec/mfenc.c
> index 13ed7b3e11..ff9ffe4827 100644
> --- a/libavcodec/mfenc.c
> +++ b/libavcodec/mfenc.c
> @@ -1066,6 +1066,9 @@ static int mf_init_encoder(AVCodecContext *avctx)
>   
>       c->main_subtype = *subtype;
>   
> +    if (c->is_audio && !avctx->frame_size)
> +        avctx->frame_size = 1024;
> +
>       if ((ret = mf_create(avctx, &c->functions, &c->mft, avctx->codec, use_hw)) < 0)
>           return ret;
>   

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec/mfenc: set frame size for audio encoders.

[Andreas Rheinhardt]

Gyan Doshi:
> Default avctx->frame_size is 0 which leads to init failure for
> audio MediaFoundation encoders.
> ---
>  libavcodec/mfenc.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/libavcodec/mfenc.c b/libavcodec/mfenc.c
> index 13ed7b3e11..ff9ffe4827 100644
> --- a/libavcodec/mfenc.c
> +++ b/libavcodec/mfenc.c
> @@ -1066,6 +1066,9 @@ static int mf_init_encoder(AVCodecContext *avctx)
>  
>      c->main_subtype = *subtype;
>  
> +    if (c->is_audio && !avctx->frame_size)
> +        avctx->frame_size = 1024;
> +
>      if ((ret = mf_create(avctx, &c->functions, &c->mft, avctx->codec, use_hw)) < 0)
>          return ret;
>  

1. You forgot to mention the ticket that this is supposed to fix; you
should also add that this a regression and the commit
(827d6fe73d2f5472c1c2128eb14fab6a4db29032) that supposedly introduced
the regression (if this is indeed true).
2. Where does this number come from (apart from the user-provided error
message)? How did it work before said commit?
(It seems that frame_size was unset before this commit, but did it
somehow just not matter?)

- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec/mfenc: set frame size for audio encoders.

[Gyan Doshi]

On 2022-06-18 12:19 pm, Andreas Rheinhardt wrote:
> Gyan Doshi:
>> Default avctx->frame_size is 0 which leads to init failure for
>> audio MediaFoundation encoders.
>> ---
>>   libavcodec/mfenc.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/libavcodec/mfenc.c b/libavcodec/mfenc.c
>> index 13ed7b3e11..ff9ffe4827 100644
>> --- a/libavcodec/mfenc.c
>> +++ b/libavcodec/mfenc.c
>> @@ -1066,6 +1066,9 @@ static int mf_init_encoder(AVCodecContext *avctx)
>>   
>>       c->main_subtype = *subtype;
>>   
>> +    if (c->is_audio && !avctx->frame_size)
>> +        avctx->frame_size = 1024;
>> +
>>       if ((ret = mf_create(avctx, &c->functions, &c->mft, avctx->codec, use_hw)) < 0)
>>           return ret;
>>   
> 1. You forgot to mention the ticket that this is supposed to fix; you
> should also add that this a regression and the commit
> (827d6fe73d2f5472c1c2128eb14fab6a4db29032) that supposedly introduced
> the regression (if this is indeed true).
  I initially became aware due to a user query. Saw ticket later. Will 
add details.

> 2. Where does this number come from (apart from the user-provided error
> message)? How did it work before said commit?
> (It seems that frame_size was unset before this commit, but did it
> somehow just not matter?)

The MF encoders accept any number of samples per frame. They reframe as 
necessary for DSP.
I choose 1024 as its the most common frame size emitted (PCM/AAC decoders).

Regards,
Gyan
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec/mfenc: set frame size for audio encoders.

[Anton Khirnov]

Quoting Gyan Doshi (2022-06-18 10:28:38)
> 
> 
> On 2022-06-18 12:19 pm, Andreas Rheinhardt wrote:
> > Gyan Doshi:
> >> Default avctx->frame_size is 0 which leads to init failure for
> >> audio MediaFoundation encoders.
> >> ---
> >>   libavcodec/mfenc.c | 3 +++
> >>   1 file changed, 3 insertions(+)
> >>
> >> diff --git a/libavcodec/mfenc.c b/libavcodec/mfenc.c
> >> index 13ed7b3e11..ff9ffe4827 100644
> >> --- a/libavcodec/mfenc.c
> >> +++ b/libavcodec/mfenc.c
> >> @@ -1066,6 +1066,9 @@ static int mf_init_encoder(AVCodecContext *avctx)
> >>   
> >>       c->main_subtype = *subtype;
> >>   
> >> +    if (c->is_audio && !avctx->frame_size)
> >> +        avctx->frame_size = 1024;
> >> +
> >>       if ((ret = mf_create(avctx, &c->functions, &c->mft, avctx->codec, use_hw)) < 0)
> >>           return ret;
> >>   
> > 1. You forgot to mention the ticket that this is supposed to fix; you
> > should also add that this a regression and the commit
> > (827d6fe73d2f5472c1c2128eb14fab6a4db29032) that supposedly introduced
> > the regression (if this is indeed true).
>   I initially became aware due to a user query. Saw ticket later. Will 
> add details.
> 
> > 2. Where does this number come from (apart from the user-provided error
> > message)? How did it work before said commit?
> > (It seems that frame_size was unset before this commit, but did it
> > somehow just not matter?)
> 
> The MF encoders accept any number of samples per frame. They reframe as 
> necessary for DSP.

So set AV_CODEC_CAP_VARIABLE_FRAME_SIZE instead? Or does it have to be
constant?

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH v2] avcodec/mfenc: set variable frame size flag.

[Gyan Doshi]

Default avctx->frame_size is 0 which led to init failure for
audio MediaFoundation encoders since 827d6fe73d.

The MF audio encoders accept variable frame size input buffers.

Fixes #9802
---
 libavcodec/mfenc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavcodec/mfenc.c b/libavcodec/mfenc.c
index 13ed7b3e11..8618e54ea3 100644
--- a/libavcodec/mfenc.c
+++ b/libavcodec/mfenc.c
@@ -1239,7 +1239,7 @@ static int mf_init(AVCodecContext *avctx)
         FF_CODEC_RECEIVE_PACKET_CB(mf_receive_packet),                         \
         EXTRA                                                                  \
         .p.capabilities = AV_CODEC_CAP_DELAY | AV_CODEC_CAP_HYBRID |           \
-                          AV_CODEC_CAP_DR1,                                    \
+                          AV_CODEC_CAP_DR1 | AV_CODEC_CAP_VARIABLE_FRAME_SIZE, \
         .caps_internal  = FF_CODEC_CAP_INIT_THREADSAFE |                       \
                           FF_CODEC_CAP_INIT_CLEANUP,                           \
     };
-- 
2.36.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2] avcodec/mfenc: set variable frame size flag.

[Andreas Rheinhardt]

Gyan Doshi:
> Default avctx->frame_size is 0 which led to init failure for
> audio MediaFoundation encoders since 827d6fe73d.
> 
> The MF audio encoders accept variable frame size input buffers.
> 
> Fixes #9802
> ---
>  libavcodec/mfenc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavcodec/mfenc.c b/libavcodec/mfenc.c
> index 13ed7b3e11..8618e54ea3 100644
> --- a/libavcodec/mfenc.c
> +++ b/libavcodec/mfenc.c
> @@ -1239,7 +1239,7 @@ static int mf_init(AVCodecContext *avctx)
>          FF_CODEC_RECEIVE_PACKET_CB(mf_receive_packet),                         \
>          EXTRA                                                                  \
>          .p.capabilities = AV_CODEC_CAP_DELAY | AV_CODEC_CAP_HYBRID |           \
> -                          AV_CODEC_CAP_DR1,                                    \
> +                          AV_CODEC_CAP_DR1 | AV_CODEC_CAP_VARIABLE_FRAME_SIZE, \
>          .caps_internal  = FF_CODEC_CAP_INIT_THREADSAFE |                       \
>                            FF_CODEC_CAP_INIT_CLEANUP,                           \
>      };

This will add this capability to both audio and video encoders, although
it makes no sense for the latter.

- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2] avcodec/mfenc: set variable frame size flag.

[Andreas Rheinhardt]

Andreas Rheinhardt:
> Gyan Doshi:
>> Default avctx->frame_size is 0 which led to init failure for
>> audio MediaFoundation encoders since 827d6fe73d.
>>
>> The MF audio encoders accept variable frame size input buffers.
>>
>> Fixes #9802
>> ---
>>  libavcodec/mfenc.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/libavcodec/mfenc.c b/libavcodec/mfenc.c
>> index 13ed7b3e11..8618e54ea3 100644
>> --- a/libavcodec/mfenc.c
>> +++ b/libavcodec/mfenc.c
>> @@ -1239,7 +1239,7 @@ static int mf_init(AVCodecContext *avctx)
>>          FF_CODEC_RECEIVE_PACKET_CB(mf_receive_packet),                         \
>>          EXTRA                                                                  \
>>          .p.capabilities = AV_CODEC_CAP_DELAY | AV_CODEC_CAP_HYBRID |           \
>> -                          AV_CODEC_CAP_DR1,                                    \
>> +                          AV_CODEC_CAP_DR1 | AV_CODEC_CAP_VARIABLE_FRAME_SIZE, \
>>          .caps_internal  = FF_CODEC_CAP_INIT_THREADSAFE |                       \
>>                            FF_CODEC_CAP_INIT_CLEANUP,                           \
>>      };
> 
> This will add this capability to both audio and video encoders, although
> it makes no sense for the latter.
> 

This should actually been covered by the libavcodec-avcodec FATE test.
How did you test your patch?

- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2] avcodec/mfenc: set variable frame size flag.

[Gyan Doshi]

On 2022-06-19 02:54 pm, Andreas Rheinhardt wrote:
> Andreas Rheinhardt:
>> Gyan Doshi:
>>> Default avctx->frame_size is 0 which led to init failure for
>>> audio MediaFoundation encoders since 827d6fe73d.
>>>
>>> The MF audio encoders accept variable frame size input buffers.
>>>
>>> Fixes #9802
>>> ---
>>>   libavcodec/mfenc.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/libavcodec/mfenc.c b/libavcodec/mfenc.c
>>> index 13ed7b3e11..8618e54ea3 100644
>>> --- a/libavcodec/mfenc.c
>>> +++ b/libavcodec/mfenc.c
>>> @@ -1239,7 +1239,7 @@ static int mf_init(AVCodecContext *avctx)
>>>           FF_CODEC_RECEIVE_PACKET_CB(mf_receive_packet),                         \
>>>           EXTRA                                                                  \
>>>           .p.capabilities = AV_CODEC_CAP_DELAY | AV_CODEC_CAP_HYBRID |           \
>>> -                          AV_CODEC_CAP_DR1,                                    \
>>> +                          AV_CODEC_CAP_DR1 | AV_CODEC_CAP_VARIABLE_FRAME_SIZE, \
>>>           .caps_internal  = FF_CODEC_CAP_INIT_THREADSAFE |                       \
>>>                             FF_CODEC_CAP_INIT_CLEANUP,                           \
>>>       };
>> This will add this capability to both audio and video encoders, although
>> it makes no sense for the latter.
>>
> This should actually been covered by the libavcodec-avcodec FATE test.
> How did you test your patch?

Manually. I didn't expect HW / ext lib encoders to be covered by FATE, 
and indeed I don't find anything for MF.

Regards,
Gyan
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2] avcodec/mfenc: set variable frame size flag.

[Gyan Doshi]

On 2022-06-19 03:36 pm, Gyan Doshi wrote:
>
>
> On 2022-06-19 02:54 pm, Andreas Rheinhardt wrote:
>> Andreas Rheinhardt:
>>> Gyan Doshi:
>>>> Default avctx->frame_size is 0 which led to init failure for
>>>> audio MediaFoundation encoders since 827d6fe73d.
>>>>
>>>> The MF audio encoders accept variable frame size input buffers.
>>>>
>>>> Fixes #9802
>>>> ---
>>>>   libavcodec/mfenc.c | 2 +-
>>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/libavcodec/mfenc.c b/libavcodec/mfenc.c
>>>> index 13ed7b3e11..8618e54ea3 100644
>>>> --- a/libavcodec/mfenc.c
>>>> +++ b/libavcodec/mfenc.c
>>>> @@ -1239,7 +1239,7 @@ static int mf_init(AVCodecContext *avctx)
>>>> FF_CODEC_RECEIVE_PACKET_CB(mf_receive_packet), \
>>>> EXTRA \
>>>>           .p.capabilities = AV_CODEC_CAP_DELAY | 
>>>> AV_CODEC_CAP_HYBRID |           \
>>>> - AV_CODEC_CAP_DR1,                                    \
>>>> +                          AV_CODEC_CAP_DR1 | 
>>>> AV_CODEC_CAP_VARIABLE_FRAME_SIZE, \
>>>>           .caps_internal  = FF_CODEC_CAP_INIT_THREADSAFE 
>>>> |                       \
>>>> FF_CODEC_CAP_INIT_CLEANUP,                           \
>>>>       };
>>> This will add this capability to both audio and video encoders, 
>>> although
>>> it makes no sense for the latter.
>>>
>> This should actually been covered by the libavcodec-avcodec FATE test.
>> How did you test your patch?
>
> Manually. I didn't expect HW / ext lib encoders to be covered by FATE, 
> and indeed I don't find anything for MF.

And Patchwork FATE does not show any fails for v2.
I do see lavc/avcodec testprog, but I rarely do avcodec so didn't 
remember that.

Regards,
Gyan
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2] avcodec/mfenc: set variable frame size flag.

[Andreas Rheinhardt]

Gyan Doshi:
> 
> 
> On 2022-06-19 03:36 pm, Gyan Doshi wrote:
>>
>>
>> On 2022-06-19 02:54 pm, Andreas Rheinhardt wrote:
>>> Andreas Rheinhardt:
>>>> Gyan Doshi:
>>>>> Default avctx->frame_size is 0 which led to init failure for
>>>>> audio MediaFoundation encoders since 827d6fe73d.
>>>>>
>>>>> The MF audio encoders accept variable frame size input buffers.
>>>>>
>>>>> Fixes #9802
>>>>> ---
>>>>>   libavcodec/mfenc.c | 2 +-
>>>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/libavcodec/mfenc.c b/libavcodec/mfenc.c
>>>>> index 13ed7b3e11..8618e54ea3 100644
>>>>> --- a/libavcodec/mfenc.c
>>>>> +++ b/libavcodec/mfenc.c
>>>>> @@ -1239,7 +1239,7 @@ static int mf_init(AVCodecContext *avctx)
>>>>> FF_CODEC_RECEIVE_PACKET_CB(mf_receive_packet), \
>>>>> EXTRA \
>>>>>           .p.capabilities = AV_CODEC_CAP_DELAY |
>>>>> AV_CODEC_CAP_HYBRID |           \
>>>>> - AV_CODEC_CAP_DR1,                                    \
>>>>> +                          AV_CODEC_CAP_DR1 |
>>>>> AV_CODEC_CAP_VARIABLE_FRAME_SIZE, \
>>>>>           .caps_internal  = FF_CODEC_CAP_INIT_THREADSAFE
>>>>> |                       \
>>>>> FF_CODEC_CAP_INIT_CLEANUP,                           \
>>>>>       };
>>>> This will add this capability to both audio and video encoders,
>>>> although
>>>> it makes no sense for the latter.
>>>>
>>> This should actually been covered by the libavcodec-avcodec FATE test.
>>> How did you test your patch?
>>
>> Manually. I didn't expect HW / ext lib encoders to be covered by FATE,
>> and indeed I don't find anything for MF.
> 
> And Patchwork FATE does not show any fails for v2.
> I do see lavc/avcodec testprog, but I rarely do avcodec so didn't
> remember that.
> 

Patchwork doesn't have a Windows box, i.e. mediafoundation is not
covered by them.

- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".