From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id 684B14357A
	for <ffmpegdev@gitmailbox.com>; Thu, 16 Jun 2022 23:38:18 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id EE80568B87F;
	Fri, 17 Jun 2022 02:38:14 +0300 (EEST)
Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net
 [217.70.183.193])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8B48F68B7C5
 for <ffmpeg-devel@ffmpeg.org>; Fri, 17 Jun 2022 02:38:08 +0300 (EEST)
Received: from localhost (213-47-68-29.cable.dynamic.surfer.at [213.47.68.29])
 (Authenticated sender: michael@niedermayer.cc)
 by mail.gandi.net (Postfix) with ESMTPSA id E9156240002
 for <ffmpeg-devel@ffmpeg.org>; Thu, 16 Jun 2022 23:38:07 +0000 (UTC)
Date: Fri, 17 Jun 2022 01:38:07 +0200
From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Message-ID: <20220616233807.GS396728@pb2>
References: <07b64fb90f72d9bc4b5aa154b715ae121f849c71.camel@acc.umu.se>
 <20220616182749.GP396728@pb2>
 <2bfa8365a382c01dc71a01b8a9b2271356aa528b.camel@acc.umu.se>
MIME-Version: 1.0
In-Reply-To: <2bfa8365a382c01dc71a01b8a9b2271356aa528b.camel@acc.umu.se>
Subject: Re: [FFmpeg-devel] [PATCH] Make execute() and execute2() return
 FFMIN() of thread return codes
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: multipart/mixed; boundary="===============7353699710153040011=="
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/20220616233807.GS396728@pb2/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>


--===============7353699710153040011==
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="xFtL08i6nTCC+lE2"
Content-Disposition: inline


--xFtL08i6nTCC+lE2
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jun 16, 2022 at 11:04:01PM +0200, Tomas H=E4rdin wrote:
> tor 2022-06-16 klockan 20:27 +0200 skrev Michael Niedermayer:
> >=20
> > > =A0
> > > =A0void avpriv_slicethread_free(AVSliceThread **pctx)
> > > @@ -236,8 +244,8 @@ void avpriv_slicethread_free(AVSliceThread
> > > **pctx)
> > > =A0#else /* HAVE_PTHREADS || HAVE_W32THREADS || HAVE_OS32THREADS */
> > > =A0
> > > =A0int avpriv_slicethread_create(AVSliceThread **pctx, void *priv,
> > > -=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=
=A0=A0=A0=A0=A0=A0=A0 void (*worker_func)(void *priv, int
> > > jobnr, int threadnr, int nb_jobs, int nb_threads),
> > > -=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=
=A0=A0=A0=A0=A0=A0=A0 void (*main_func)(void *priv),
> > > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=
=A0=A0=A0=A0=A0=A0=A0 int (*worker_func)(void *priv, int
> > > jobnr, int threadnr, int nb_jobs, int nb_threads),
> > > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=
=A0=A0=A0=A0=A0=A0=A0 int (*main_func)(void *priv),
> > > =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=
=A0=A0=A0=A0=A0=A0=A0 int nb_threads)
> > > =A0{
> > > =A0=A0=A0=A0 *pctx =3D NULL;
> >=20
> > You forgot to update the fallback code when threads are disabled
>=20
> Uhm, the existing code just abort()s if threads are disabled? I'm not
> really sure if there anything that can or should be done there

Before your patches fate passes with --disable-pthreads
afterwards it will fail during build because the function mismatches,
the abort should not be reachable i hope

thx

[...]
--=20
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire

--xFtL08i6nTCC+lE2
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCYqu+3wAKCRBhHseHBAsP
q+flAJ9lKRdsZN/yarP/YDpLsJzyjxGV4QCeNyafOA5o8dLJJNqwkS34o4z7fL8=
=cg/x
-----END PGP SIGNATURE-----

--xFtL08i6nTCC+lE2--

--===============7353699710153040011==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

--===============7353699710153040011==--