From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 319A74353C for ; Thu, 16 Jun 2022 20:01:20 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 99A3E68B7B3; Thu, 16 Jun 2022 23:01:18 +0300 (EEST) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3C6E868B735 for ; Thu, 16 Jun 2022 23:01:12 +0300 (EEST) Received: from localhost (213-47-68-29.cable.dynamic.surfer.at [213.47.68.29]) (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 29714240004 for ; Thu, 16 Jun 2022 20:01:10 +0000 (UTC) Date: Thu, 16 Jun 2022 22:01:10 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20220616200110.GQ396728@pb2> References: <23aa6fad-bd13-6aeb-cc27-8b2bd3497b8d@mail.de> MIME-Version: 1.0 In-Reply-To: <23aa6fad-bd13-6aeb-cc27-8b2bd3497b8d@mail.de> Subject: Re: [FFmpeg-devel] [PATCH] lavc/libx264.c: Fix possible UB by NULL pointer LHS X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============4686211265297424159==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============4686211265297424159== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ftsvpRfm7AHRcupw" Content-Disposition: inline --ftsvpRfm7AHRcupw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 16, 2022 at 05:58:09PM +0200, Thilo Borgmann wrote: > Hi, >=20 > the LHS pointer might be NULL so that +=3D would be UB. >=20 > Thanks, > Thilo > libx264.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > 558de1ca7a30aa728193297a7d605c051b5bbfc0 0001-lavc-libx264.c-Fix-possibl= e-UB-by-NULL-pointer-LHS.patch > From cfb7ce8092c34436fae3120645aa96fe082af4ea Mon Sep 17 00:00:00 2001 > From: Michael Goulet > Date: Thu, 16 Jun 2022 17:52:56 +0200 > Subject: [PATCH] lavc/libx264.c: Fix possible UB by NULL pointer LHS >=20 > It is UB to attempt to do pointer arithmetic on NULL pointer LHS, even if= that pointer arithmetic ends up being "+=3D 0" (i.e. !!p =3D=3D 0 if p =3D= =3D NULL). > --- > libavcodec/libx264.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) should be ok [...] thx --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Whats the most studid thing your enemy could do ? Blow himself up Whats the most studid thing you could do ? Give up your rights and freedom because your enemy blew himself up. --ftsvpRfm7AHRcupw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCYquMAgAKCRBhHseHBAsP q2/0AJ9vvyo0NMG0yCXGbCbEg47tdwCE1gCZATSL5QAtaA0nBJim2a3dftmBhTU= =NfJl -----END PGP SIGNATURE----- --ftsvpRfm7AHRcupw-- --===============4686211265297424159== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============4686211265297424159==--