From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7BF5942A34 for ; Sat, 11 Jun 2022 07:32:35 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5678368B571; Sat, 11 Jun 2022 10:32:34 +0300 (EEST) Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 98F6168B2D1 for ; Sat, 11 Jun 2022 10:32:27 +0300 (EEST) Received: by mail-ej1-f46.google.com with SMTP id n10so1906301ejk.5 for ; Sat, 11 Jun 2022 00:32:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=09TpiaL5k5YvjEFgHuutWZA2HIcCK/cR3YiAEg8XEdE=; b=PKpmaU27CQgPnuEnmi5/B90vXr1rhRadS64yxZ8itGDsJseJ08sOkP1mhnR1JjUpIG dRX6Jt2ya4MEDJSB8gYCdbpek1D+iF445iLzu5zwD/Z4jraLHZEuh2tOm+gt1Qv5f2S5 YBjJIMwoL6SzpzEkVlaw8D+mWJ+IXjTT1cT+sgab14kIYwkRI91MWnbFiMsW0aAL8WFe xkHPwvvX8BnhAHIUcMD8gfobH7qk0WdzISsz9eIyOnW0dGdSBK746qpJ5TmC9VowD0wQ rIT5rg+ey9OFAOdKxsNh12QbFxB7uN8q70KNlqq0iGJz8C5+uQBeODLwWBt5Tj5II8HU 47Cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=09TpiaL5k5YvjEFgHuutWZA2HIcCK/cR3YiAEg8XEdE=; b=lLF2z2AKrgKOE97LEpB2RG7bSdjRE4HF1Dmti7TmrmZ0nNiP46SR5TlxWO3CCU780X LzU6skLM7SUDLcNpkxeOdjo6ufYo5MfMBigtx73ZeI6EDa0PCMWB9ph7U44Q+J2GUveP GeE9lO5hqoHNIa/rsZrCWQ0Tx64eQ2j1vBimp2yISHK9vmbE9hs3zuMkZijK4hklo99n lxqboA0ySHvbehyfprsfFTj2l343xETOKFGiIV9WnT5973JoVP5sKQlDHuRDIdUJVyBA EsqxnXg42+gTq5bcvc4pI/GYH9ksowPofffSw3A7mghljqm+7D9y5pi0ch2IzgxgJthV T/Dw== X-Gm-Message-State: AOAM533KX4ocR6cqTdjgiNJYgvoAWl88tMEY/dDcXa4y5Cwxr5b4DE+3 7Lu++Ed+F9oQ+FymbVahAY+knuhtnb8Z4w== X-Google-Smtp-Source: ABdhPJwbJu6li40cr6DpSM5Ic9lr6Jjo8aU8JjegF8T/pxWXTDqfyYP7ZVYUWhKf/CfwWdQCvt6mtw== X-Received: by 2002:a17:907:c202:b0:710:8d0c:6e89 with SMTP id ti2-20020a170907c20200b007108d0c6e89mr33549187ejc.141.1654932746830; Sat, 11 Jun 2022 00:32:26 -0700 (PDT) Received: from localhost.localdomain (92-64-99-37.biz.kpn.net. [92.64.99.37]) by smtp.googlemail.com with ESMTPSA id t19-20020a056402525300b004333e3e3199sm907337edd.63.2022.06.11.00.32.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Jun 2022 00:32:26 -0700 (PDT) From: Martijn van Beurden To: ffmpeg-devel@ffmpeg.org Date: Sat, 11 Jun 2022 09:32:16 +0200 Message-Id: <20220611073216.1930852-1-mvanb1@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220604103507.1822192-2-mvanb1@gmail.com> References: <20220604103507.1822192-2-mvanb1@gmail.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v3 2/2] avformat/mov: prevent potential use of uninitialized value X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Martijn van Beurden Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --- libavformat/mov.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index d7be593a86..51c0f6f9d8 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -6772,7 +6772,10 @@ static int mov_read_dfla(MOVContext *c, AVIOContext *pb, MOVAtom atom) avio_rb24(pb); /* Flags */ - avio_read(pb, buf, sizeof(buf)); + if (avio_read(pb, buf, sizeof(buf)) != sizeof(buf)) { + av_log(c->fc, AV_LOG_ERROR, "failed to read FLAC metadata block header\n"); + return (pb->error < 0 ? pb->error : AVERROR_INVALIDDATA); + } flac_parse_block_header(buf, &last, &type, &size); if (type != FLAC_METADATA_TYPE_STREAMINFO || size != FLAC_STREAMINFO_SIZE) { -- 2.30.2 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".