From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v1 2/4] lavc/hevcdec: do not let missing ref frames invovled in dpb process
Date: Thu, 9 Jun 2022 16:04:33 +0200
Message-ID: <20220609140433.GY396728@pb2> (raw)
In-Reply-To: <PH0PR11MB5030E061C9961C8B2F238DB3CDA79@PH0PR11MB5030.namprd11.prod.outlook.com>
[-- Attachment #1.1: Type: text/plain, Size: 1474 bytes --]
On Thu, Jun 09, 2022 at 05:34:47AM +0000, Wang, Fei W wrote:
> > -----Original Message-----
> > From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of
> > Michael Niedermayer
> > Sent: Tuesday, June 7, 2022 8:07 PM
> > To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
> > Subject: Re: [FFmpeg-devel] [PATCH v1 2/4] lavc/hevcdec: do not let missing ref
> > frames invovled in dpb process
> >
> > On Tue, Jun 07, 2022 at 03:08:28PM +0800, Fei Wang wrote:
> > > From: Xu Guangxin <guangxin.xu@intel.com>
> > >
> > > We will generate a new frame for a missed reference. The frame can
> > > only be used for reference. We assign an invalid decode sequence to
> > > it, so it will not be involved in any dpb process.
> > >
> > > Tested-by: Fei Wang <fei.w.wang@intel.com>
> > > Signed-off-by: Xu Guangxin <guangxin.xu@intel.com>
> > > ---
> > > libavcodec/hevc_refs.c | 13 ++++++++++++-
> > > libavcodec/hevcdec.c | 4 ++--
> > > libavcodec/hevcdec.h | 3 +++
> > > 3 files changed, 17 insertions(+), 3 deletions(-)
> >
> > This causes segfaults
>
> Thanks Michael, could you share your clip to me? I can't reproduce this with all my clips.
file sent by private mail
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
The smallest minority on earth is the individual. Those who deny
individual rights cannot claim to be defenders of minorities. - Ayn Rand
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-06-09 14:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 7:08 [FFmpeg-devel] [PATCH v1 1/4] lavc/hevc_refs: fix dpb logical for IRAP Fei Wang
2022-06-07 7:08 ` [FFmpeg-devel] [PATCH v1 2/4] lavc/hevcdec: do not let missing ref frames invovled in dpb process Fei Wang
2022-06-07 12:06 ` Michael Niedermayer
2022-06-09 5:34 ` Wang, Fei W
2022-06-09 14:04 ` Michael Niedermayer [this message]
2022-06-14 1:50 ` Wang, Fei W
2022-06-07 7:08 ` [FFmpeg-devel] [PATCH v1 3/4] lavc/hevc_refs: exclude current frame from long term refs Fei Wang
2022-06-07 7:08 ` [FFmpeg-devel] [PATCH v1 4/4] lavc/hevcdec: respect the value of no_output_of_prior_pics_flag Fei Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220609140433.GY396728@pb2 \
--to=michael@niedermayer.cc \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git