From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A73FD42D43 for ; Tue, 7 Jun 2022 12:07:02 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E1E0F68B663; Tue, 7 Jun 2022 15:07:00 +0300 (EEST) Received: from relay10.mail.gandi.net (relay10.mail.gandi.net [217.70.178.230]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 12CAC68B4A1 for ; Tue, 7 Jun 2022 15:06:54 +0300 (EEST) Received: from localhost (213-47-68-29.cable.dynamic.surfer.at [213.47.68.29]) (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 39477240009 for ; Tue, 7 Jun 2022 12:06:52 +0000 (UTC) Date: Tue, 7 Jun 2022 14:06:52 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20220607120652.GV396728@pb2> References: <20220607070830.2654218-1-fei.w.wang@intel.com> <20220607070830.2654218-2-fei.w.wang@intel.com> MIME-Version: 1.0 In-Reply-To: <20220607070830.2654218-2-fei.w.wang@intel.com> Subject: Re: [FFmpeg-devel] [PATCH v1 2/4] lavc/hevcdec: do not let missing ref frames invovled in dpb process X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============0717856238169153066==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============0717856238169153066== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="L6+lUPd1XOsaFBch" Content-Disposition: inline --L6+lUPd1XOsaFBch Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 07, 2022 at 03:08:28PM +0800, Fei Wang wrote: > From: Xu Guangxin >=20 > We will generate a new frame for a missed reference. The frame can only > be used for reference. We assign an invalid decode sequence to it, so > it will not be involved in any dpb process. >=20 > Tested-by: Fei Wang > Signed-off-by: Xu Guangxin > --- > libavcodec/hevc_refs.c | 13 ++++++++++++- > libavcodec/hevcdec.c | 4 ++-- > libavcodec/hevcdec.h | 3 +++ > 3 files changed, 17 insertions(+), 3 deletions(-) This causes segfaults Thread 9 "ffmpeg_g" received signal SIGSEGV, Segmentation fault. [Switching to Thread 0x7fffcc5ad700 (LWP 14108)] 0x00005555564b88c0 in ff_emu_edge_vfix19_sse () (gdb) bt #0 0x00005555564b88c0 in ff_emu_edge_vfix19_sse () #1 0x00005555561c515c in emulated_edge_mc_avx2 () #2 0x0000555555d21bc8 in hls_prediction_unit.isra () #3 0x0000555555d2420b in hls_coding_quadtree () #4 0x0000555555d2338d in hls_coding_quadtree () #5 0x0000555555d25371 in hls_decode_entry () #6 0x0000555555bd77e5 in avcodec_default_execute () #7 0x0000555555d2a00f in hevc_decode_frame () #8 0x0000555555edc5a3 in frame_worker_thread () #9 0x00007ffff75fc6db in start_thread (arg=3D0x7fffcc5ad700) at pthread_cr= eate.c:463 #10 0x00007fffed17061f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clo= ne.S:95 [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I do not agree with what you have to say, but I'll defend to the death your right to say it. -- Voltaire --L6+lUPd1XOsaFBch Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCYp8/WAAKCRBhHseHBAsP qzSdAJ9nvCrCNkLmb9LXOqpkFQ53uozQsQCfaPtwlIB6jmc1GApluuanfNoy6vQ= =A4b0 -----END PGP SIGNATURE----- --L6+lUPd1XOsaFBch-- --===============0717856238169153066== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============0717856238169153066==--