From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8CE1742CD8 for ; Fri, 3 Jun 2022 14:58:38 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 825A368B84A; Fri, 3 Jun 2022 17:58:36 +0300 (EEST) Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 44C8B68B838 for ; Fri, 3 Jun 2022 17:58:29 +0300 (EEST) Received: from localhost (213-47-68-29.cable.dynamic.surfer.at [213.47.68.29]) (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 54D2B20008 for ; Fri, 3 Jun 2022 14:58:28 +0000 (UTC) Date: Fri, 3 Jun 2022 16:58:27 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20220603145827.GT396728@pb2> References: <152f94f0779c645542f5a678d9392ee53584d45a.camel@acc.umu.se> <20220601162119.GI396728@pb2> <20220601162308.GJ396728@pb2> <81755d6b2376e8f9ffb0898e328e6977cde04043.camel@acc.umu.se> <20220602191957.GS396728@pb2> <83c617739b1a10dd73d27196ae15d89d95cc82dd.camel@acc.umu.se> MIME-Version: 1.0 In-Reply-To: <83c617739b1a10dd73d27196ae15d89d95cc82dd.camel@acc.umu.se> Subject: Re: [FFmpeg-devel] [PATCH 1/8] libavcodec/jpeg2000_parser: Speed up long skips X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============8310153363846337132==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============8310153363846337132== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="yahdd2r5OMEJJ+pI" Content-Disposition: inline --yahdd2r5OMEJJ+pI Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 03, 2022 at 11:17:54AM +0200, Tomas H=E4rdin wrote: > tor 2022-06-02 klockan 21:19 +0200 skrev Michael Niedermayer: > > On Thu, Jun 02, 2022 at 11:54:39AM +0200, Tomas H=E4rdin wrote: > > > ons 2022-06-01 klockan 18:23 +0200 skrev Michael Niedermayer: > > > > On Wed, Jun 01, 2022 at 06:21:19PM +0200, Michael Niedermayer > > > > wrote: > > > > > On Tue, May 31, 2022 at 11:58:39AM +0200, Tomas H=E4rdin wrote: > > > > > >=20 > > > > >=20 > > > > > > =A0jpeg2000_parser.c |=A0=A0 11 +++++++++++ > > > > > > =A01 file changed, 11 insertions(+) > > > > > > 634546fb5a0eb281eea87ad7471c503f5bc9e8ab=A0 0001-libavcodec- > > > > > > jpeg2000_parser-Speed-up-long-skips.patch > > > > > > From fedd7f9ae2c691a25c37be935d7547be61d46017 Mon Sep 17 > > > > > > 00:00:00 > > > > > > 2001 > > > > > > From: =3D?UTF-8?q?Tomas=3D20H=3DC3=3DA4rdin?=3D > > > > > > Date: Fri, 20 May 2022 11:38:25 +0200 > > > > > > Subject: [PATCH 1/8] libavcodec/jpeg2000_parser: Speed up > > > > > > long > > > > > > skips > > > > > >=20 > > > > > > --- > > > > > > =A0libavcodec/jpeg2000_parser.c | 11 +++++++++++ > > > > > > =A01 file changed, 11 insertions(+) > > > > >=20 > > > > > breaks > > > > > j2kref/codestreams_profile1/p1_04.j2k > > > >=20 > > > > [jpeg2000 @ 0x7fb0b8002600] Psot 66195 too big > > > > [jpeg2000 @ 0x7fb0b8002600] error during processing marker > > > > segment > > > > ff90 > > > > Input #0, j2k_pipe, from 'j2kref/codestreams_profile1/p1_04.j2k': > > > > =A0 Duration: N/A, bitrate: N/A > > > > =A0 Stream #0:0: Video: jpeg2000 (JPEG 2000 codestream restriction > > > > 1), > > > > gray16le(12 bpc), 1024x1024, 25 fps, 25 tbr, 25 tbn > > > > [jpeg2000 @ 0x7fb0b8003240] unsupported marker 0x97C8 at pos > > > > 0x6F0 > > > > [jpeg2000 @ 0x7fb0b8003240] Missing EOC Marker. > > > > [jpeg2000 @ 0x7fb0b8032280] unsupported marker 0x97C8 at pos > > > > 0x6F0 > > > > [jpeg2000 @ 0x7fb0b8032280] Missing EOC Marker. > > > > [jpeg2000 @ 0x7fb0b8006280] Psot 66195 too big > > > > [jpeg2000 @ 0x7fb0b8006280] error during processing marker > > > > segment > > > > ff90 > > >=20 > > > Took a while to figure out, but this is due to buf_size - i - 9 > > > being > > > changed to unsigned because of the uint32_t. Try attached patch. > > > The > > > rest of the set should work with it. > >=20 > > works fine here >=20 > Great >=20 > > > Can we roll these tests into FATE? > >=20 > > feel free to do so.=20 > > ill test if someone posts a patch >=20 > How are you testing them? Just decoding and checking that the output is > the same as some reference output?=20 yes > Just looking for non-zero exit code? [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Any man who breaks a law that conscience tells him is unjust and willingly= =20 accepts the penalty by staying in jail in order to arouse the conscience of= =20 the community on the injustice of the law is at that moment expressing the= =20 very highest respect for law. - Martin Luther King Jr --yahdd2r5OMEJJ+pI Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCYpohjwAKCRBhHseHBAsP q2PWAJ9eKUjbGP/Xw2aqdWo81W7ILMpDMQCeNSlOqE5wtEJIP5rKvKadDtEH92g= =WDEG -----END PGP SIGNATURE----- --yahdd2r5OMEJJ+pI-- --===============8310153363846337132== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============8310153363846337132==--