From: Michael Niedermayer <michael@niedermayer.cc> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Subject: [FFmpeg-devel] [PATCH 2/2] avcodec/ffv1enc: Alpha workaround Date: Mon, 30 May 2022 21:09:11 +0200 Message-ID: <20220530190911.20843-2-michael@niedermayer.cc> (raw) In-Reply-To: <20220530190911.20843-1-michael@niedermayer.cc> alpha-linux-gnu-gcc-5 (Ubuntu 5.5.0-12ubuntu1) 5.5.0 20171010 with qemu-alpha version 2.11.1(Debian 1:2.11+dfsg-1ubuntu7.39) trigger a FPE on the first iteration None of the intermediate values when printed shows an anomaly nor does casting the final value. I did not investigate this further by looking at the asm but that would be probably where to continue looking at this if someone is interrested in alpha. Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> --- libavcodec/ffv1enc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/ffv1enc.c b/libavcodec/ffv1enc.c index 9849082e44..9609877498 100644 --- a/libavcodec/ffv1enc.c +++ b/libavcodec/ffv1enc.c @@ -142,8 +142,10 @@ static void find_best_state(uint8_t best_state[256][256], int i, j, k, m; uint32_t l2tab[256]; - for (i = 1; i < 256; i++) + l2tab[1] = -log2(1 / 256.0) * ((1U << 31) / 8); + for (i = 2; i < 256; i++) { l2tab[i] = -log2(i / 256.0) * ((1U << 31) / 8); + } for (i = 0; i < 256; i++) { uint64_t best_len[256]; -- 2.17.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-05-30 19:09 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-30 19:09 [FFmpeg-devel] [PATCH 1/2] avutil/opt: " Michael Niedermayer 2022-05-30 19:09 ` Michael Niedermayer [this message] 2022-06-01 10:38 ` Anton Khirnov 2022-06-01 17:01 ` Michael Niedermayer 2022-06-06 7:55 ` Anton Khirnov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220530190911.20843-2-michael@niedermayer.cc \ --to=michael@niedermayer.cc \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git