From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3A8A642690 for ; Wed, 25 May 2022 15:53:23 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A816A68B53E; Wed, 25 May 2022 18:53:20 +0300 (EEST) Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D61DC68B461 for ; Wed, 25 May 2022 18:53:13 +0300 (EEST) Received: from localhost (213-47-68-29.cable.dynamic.surfer.at [213.47.68.29]) (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 23E7D1BF20A for ; Wed, 25 May 2022 15:53:12 +0000 (UTC) Date: Wed, 25 May 2022 17:53:12 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20220525155312.GZ396728@pb2> References: <20220524000615.5264-1-michael@niedermayer.cc> MIME-Version: 1.0 In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 1/2] avcodec/vc1_loopfilter: Factor duplicate code in vc1_b_h_intfi_loop_filter() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============4612057595766138777==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============4612057595766138777== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nbhonbzV/xpXxmuC" Content-Disposition: inline --nbhonbzV/xpXxmuC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 24, 2022 at 08:50:51PM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Fixes: CID1435168 > >=20 > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/vc1_loopfilter.c | 5 +---- > > 1 file changed, 1 insertion(+), 4 deletions(-) > >=20 > > diff --git a/libavcodec/vc1_loopfilter.c b/libavcodec/vc1_loopfilter.c > > index 0f990cccef..ee694ede28 100644 > > --- a/libavcodec/vc1_loopfilter.c > > +++ b/libavcodec/vc1_loopfilter.c > > @@ -1125,10 +1125,7 @@ static av_always_inline void vc1_b_h_intfi_loop_= filter(VC1Context *v, uint8_t *d > > dst =3D dest + (block_num & 2) * 4 * s->linesize + (block_num = & 1) * 8; > > =20 > > if (!(flags & RIGHT_EDGE) || !(block_num & 5)) { > > - if (block_num > 3) > > - v->vc1dsp.vc1_h_loop_filter8(dst + 8, linesize, pq); > > - else > > - v->vc1dsp.vc1_h_loop_filter8(dst + 8, linesize, pq); > > + v->vc1dsp.vc1_h_loop_filter8(dst + 8, linesize, pq); > > } > > =20 > > tt =3D ttblk[0] >> (block_num * 4) & 0xf; >=20 > Are you certain that the current code is actually correct or whether > something else was intended? iam not certain no but the vc1_b_v_intfi_loop_filter() function also treats luma and chroma the same if(!(flags & BOTTOM_EDGE) || block_num < 2) v->vc1dsp.vc1_v_loop_filter8(dst + 8 * linesize, linesize, pq); this is just the matching function for horizontal instead of vertical also whan looking at the 4x4 4x8 and 8x4 cases i see no difference between horizontal and vertical for intfi. But ultimately yes of course it could be buggy and something else could be correct. but if i replace this by an abort() make: *** [fate-vc1_sa10143] Error 134 make: *** [fate-vc1_ilaced_twomv] Error 134 Fate fails, so it should be tested thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB You can kill me, but you cannot change the truth. --nbhonbzV/xpXxmuC Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCYo5Q5AAKCRBhHseHBAsP q8RgAJ42f9+ieWZoU7mZXc5kM4PHnW5xnACfe/nzuOMfKF0ekkQzzxcIImj8k78= =HH6Z -----END PGP SIGNATURE----- --nbhonbzV/xpXxmuC-- --===============4612057595766138777== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============4612057595766138777==--