From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id D04E9404F7
	for <ffmpegdev@gitmailbox.com>; Wed, 25 May 2022 15:16:06 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 697CD68B53E;
	Wed, 25 May 2022 18:16:04 +0300 (EEST)
Received: from relay10.mail.gandi.net (relay10.mail.gandi.net [217.70.178.230])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 12D5068B19D
 for <ffmpeg-devel@ffmpeg.org>; Wed, 25 May 2022 18:15:58 +0300 (EEST)
Received: from localhost (213-47-68-29.cable.dynamic.surfer.at [213.47.68.29])
 (Authenticated sender: michael@niedermayer.cc)
 by mail.gandi.net (Postfix) with ESMTPSA id 23D54240005
 for <ffmpeg-devel@ffmpeg.org>; Wed, 25 May 2022 15:15:56 +0000 (UTC)
Date: Wed, 25 May 2022 17:15:55 +0200
From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Message-ID: <20220525151555.GY396728@pb2>
References: <pull.30.v3.ffstaging.FFmpeg.1653471298766.ffmpegagent@gmail.com>
 <pull.30.v4.ffstaging.FFmpeg.1653476739751.ffmpegagent@gmail.com>
MIME-Version: 1.0
In-Reply-To: <pull.30.v4.ffstaging.FFmpeg.1653476739751.ffmpegagent@gmail.com>
Subject: Re: [FFmpeg-devel] [PATCH v4] libx264: Set min build version to 158
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: multipart/mixed; boundary="===============3933752850982786142=="
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/20220525151555.GY396728@pb2/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>


--===============3933752850982786142==
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="F41/6/O0EvKTfNqT"
Content-Disposition: inline


--F41/6/O0EvKTfNqT
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, May 25, 2022 at 11:05:39AM +0000, Matt Oliver wrote:
> From: Matt Oliver <protogonoi@gmail.com>
>=20
> Was "[PATCH] libx264: Do not explicitly set X264_API_IMPORTS"
>=20
> Setting X264_API_IMPORTS only affects msvc builds and it breaks
> linking to static builds (although is required for shared builds).
> This flag is set by x264 in its pkgconfig as required since build
> 158 (a615f027ed172e2dd5380e736d487aa858a0c4ff) from July 2019.
> So this patch updates configure to require a newer x264 build that
> correctly sets the imports flag.
>=20
> The requirement for 158 is applied for msvc builds only,
> no change is made for all other cases.
>=20
> Co-authored-by: softworkz <softworkz@hotmail.com>
> Signed-off-by: softworkz <softworkz@hotmail.com>
> Signed-off-by: Matt Oliver <protogonoi@gmail.com>
> ---
>     libx264: Set min build version to 158
>    =20
>     I'm submitting this patch on behalf of Matt with his permission.
>    =20
>     There was agreement that the >=3D 158 version requirement should be
>     applied to MSVC builds only.
>    =20
>     v2: restrict the version requirement to msvc builds
>     v3: fix unintended author change
>     v4: add missing braces
>=20
> Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr-ffstagi=
ng-30%2Fsoftworkz%2Fsubmit_x264_api_imports_matt-v4
> Fetch-It-Via: git fetch https://github.com/ffstaging/FFmpeg pr-ffstaging-=
30/softworkz/submit_x264_api_imports_matt-v4
> Pull-Request: https://github.com/ffstaging/FFmpeg/pull/30
>=20
> Range-diff vs v3:
>=20
>  1:  374130a09e ! 1:  0d1bee35b0 libx264: Set min build version to 158
>      @@ configure: enabled libvpx            && {
>       -                             require_cpp_condition libx264 x264.h =
"X264_BUILD >=3D 118" &&
>       -                             check_cpp_condition libx262 x264.h "X=
264_MPEG2"
>       +enabled libx264           && check_pkg_config libx264 x264 "stdint=
=2Eh x264.h" x264_encoder_encode &&
>      -+                             require_cpp_condition libx264 x264.h =
"X264_BUILD >=3D 158" ||
>      -+                             { "$toolchain" !=3D msvc && require_c=
pp_condition libx264 x264.h "X264_BUILD >=3D 118"; }
>      ++                             { require_cpp_condition libx264 x264.=
h "X264_BUILD >=3D 158" ||
>      ++                             { "$toolchain" !=3D msvc && require_c=
pp_condition libx264 x264.h "X264_BUILD >=3D 118"; }; }
>        enabled libx265           && require_pkg_config libx265 x265 x265.=
h x265_api_get &&
>                                     require_cpp_condition libx265 x265.h =
"X265_BUILD >=3D 70"
>        enabled libxavs           && require libxavs "stdint.h xavs.h" xav=
s_encoder_encode "-lxavs $pthreads_extralibs $libm_extralibs"
>=20
>=20
>  configure            | 8 +++-----
>  libavcodec/libx264.c | 4 ----
>  2 files changed, 3 insertions(+), 9 deletions(-)
>=20
> diff --git a/configure b/configure
> index f115b21064..129473c75c 100755
> --- a/configure
> +++ b/configure
> @@ -6656,11 +6656,9 @@ enabled libvpx            && {
>  enabled libwebp           && {
>      enabled libwebp_encoder      && require_pkg_config libwebp "libwebp =
>=3D 0.2.0" webp/encode.h WebPGetEncoderVersion
>      enabled libwebp_anim_encoder && check_pkg_config libwebp_anim_encode=
r "libwebpmux >=3D 0.4.0" webp/mux.h WebPAnimEncoderOptionsInit; }
> -enabled libx264           && { check_pkg_config libx264 x264 "stdint.h x=
264.h" x264_encoder_encode ||
> -                               { require libx264 "stdint.h x264.h" x264_=
encoder_encode "-lx264 $pthreads_extralibs $libm_extralibs" &&
> -                                 warn "using libx264 without pkg-config"=
; } } &&
> -                             require_cpp_condition libx264 x264.h "X264_=
BUILD >=3D 118" &&
> -                             check_cpp_condition libx262 x264.h "X264_MP=
EG2"
> +enabled libx264           && check_pkg_config libx264 x264 "stdint.h x26=
4.h" x264_encoder_encode &&
> +                             { require_cpp_condition libx264 x264.h "X26=
4_BUILD >=3D 158" ||
> +                             { "$toolchain" !=3D msvc && require_cpp_con=
dition libx264 x264.h "X264_BUILD >=3D 118"; }; }

On ubuntu LTS:

ERROR: X264_BUILD >=3D 158 not satisfied

If you think configure made a mistake, make sure you are using the latest
version from Git.  If the latest version fails, report the problem to the
ffmpeg-user@ffmpeg.org mailing list or IRC #ffmpeg on irc.libera.chat.
Include the log file "ffbuild/config.log" produced by configure as this wil=
l help
solve the problem.

[...]
--=20
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Nations do behave wisely once they have exhausted all other alternatives.=
=20
-- Abba Eban

--F41/6/O0EvKTfNqT
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCYo5IJwAKCRBhHseHBAsP
qy/yAJ4gxoyPZEEdnNjY2juxNK9Zs4jjxQCeO9NhMIUhyYBi3up3iQpANk+uxdo=
=8zYr
-----END PGP SIGNATURE-----

--F41/6/O0EvKTfNqT--

--===============3933752850982786142==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

--===============3933752850982786142==--