From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1297D407C3 for ; Mon, 23 May 2022 23:24:53 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CFF7668B506; Tue, 24 May 2022 02:24:50 +0300 (EEST) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8CC0368B000 for ; Tue, 24 May 2022 02:24:44 +0300 (EEST) Received: from localhost (213-47-68-29.cable.dynamic.surfer.at [213.47.68.29]) (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id A21FC240002 for ; Mon, 23 May 2022 23:24:43 +0000 (UTC) Date: Tue, 24 May 2022 01:24:42 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20220523232442.GW396728@pb2> References: <20170101232833.24472-1-michael@niedermayer.cc> <2cbd676e-ab01-741f-3233-7971414f5525@gmail.com> <20170104000650.GS4749@nb4> MIME-Version: 1.0 In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] avcodec/texturedspenc: Fix indexing in color distribution determination X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============6976494388193481701==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============6976494388193481701== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="/iGx3h4bc2ZI981g" Content-Disposition: inline --/iGx3h4bc2ZI981g Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jan 04, 2017 at 11:52:50PM +0100, Vittorio Giovara wrote: > On Wed, Jan 4, 2017 at 1:06 AM, Michael Niedermayer > wrote: > > On Tue, Jan 03, 2017 at 02:15:20PM +0100, Vittorio Giovara wrote: > >> On Mon, Jan 2, 2017 at 2:00 AM, James Almer wrote: > >> > On 1/1/2017 8:28 PM, Michael Niedermayer wrote: > >> >> Fixes CID1396405 > >> > >> What is the CID about? > > > > sorry for not quoting this prviously, it isnt very interresting. > > my patch is based on just this and guesswork, which is why it should > > be tested. > > > > 257 for (y =3D 0; y < 4; y++) { > > assignment: Assigning: x =3D 4. > > const: At condition x < 4, the value of x must be equal to 4. > > dead_error_condition: The condition x < 4 cannot be true. > > 258 for (x =3D 4; x < 4; x +=3D 4) { > > CID 1396405 (#1 of 1): Logically dead code (DEADCODE)dead_error_begi= n: Execution cannot reach this statement: muv +=3D bp[x * 4 + y * stride];. >=20 > Ah, yes that seems wrong, probably a leftover of the code conversion > (from https://github.com/nothings/stb/blob/master/stb_dxt.h#L293-L298) > I believe it should be sufficient to do `for (x =3D 0; x < 4; x++)` but > I won't be able to test that for a while I'm afraid This issue seems stil open, i just stumbled accross the CID again when looking at coverity anyone has means to test this ? thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Never trust a computer, one day, it may think you are the virus. -- Compn --/iGx3h4bc2ZI981g Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCYowXtgAKCRBhHseHBAsP q79GAJ9tzIRpBqOHuKcd3DWd504ey0RCOQCgg54/G+A0gSu8FxWQ31M3xfqccrI= =El7m -----END PGP SIGNATURE----- --/iGx3h4bc2ZI981g-- --===============6976494388193481701== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============6976494388193481701==--